chore: update puppeteer #4964
Closed
chore: update puppeteer #4964
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
BREAKING CHANGE: minimum supported Nodejs version is 14.15.0
* refactor!: allow only Array for the proxy option * test: fix ci * chore: fix lint
* chore: update core dependencies * chore: update webpack merge * chore: update snapshots
snitin315 requested review from alexander-akait, anshumanv and hiroppy as code owners snitin315 force-pushed the update-puppeteer branch from 94b586a to 4b4acfb Compare 
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@ ## next #4964 +/- ## =========================================== - Coverage 92.04% 57.71% -34.33% =========================================== Files 15 11 -4 Lines 1571 1374 -197 Branches 595 541 -54 =========================================== - Hits 1446 793 -653 - Misses 116 480 +364 - Partials 9 101 +92 ☔ View full report in Codecov by Sentry. |
snitin315 commented Aug 6, 2023
| exports[`historyApiFallback option as object with static set to false historyApiFallback should work and ignore static content: console messages 1`] = `[]`; | ||
| exports[`historyApiFallback option as object with static set to false historyApiFallback should work and ignore static content: console messages 1`] = ` | ||
| [ | ||
| "Failed to load resource: the server responded with a status of 404 (Not Found)", |
Member Author
There was a problem hiding this comment.
- The new headless mode captures this when favicon is not present. It's valid here as static is false.
Member
| @snitin315 still flacky, what we should fix/look? |
Member Author
| Hmm, I think we should invest time in migration to the playwright. I'll evaluate the efforts. |
Member
| Done in master, anyway thank you |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
No
Motivation / Use-Case
page._clientchanged topage._client()Failed to load resource: the server responded with a status of 404 (Not Found)error if favicon is not present hence I've added thefaviconin our static/public directory fixtures.publicdirectory at the root (default path) withfaviconso that tests can pick up the favicon automatically.Breaking Changes
None
Additional Info
No