refactor: remove deprecated listen and close methods #4659
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
snitin315 requested review from alexander-akait, anshumanv and hiroppy as code owners snitin315 changed the title listen and close methods 
Codecov ReportBase: 92.07% // Head: 92.51% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@ ## next #4659 +/- ## ========================================== + Coverage 92.07% 92.51% +0.43% ========================================== Files 15 15 Lines 1628 1590 -38 Branches 611 596 -15 ========================================== - Hits 1499 1471 -28 + Misses 118 110 -8 + Partials 11 9 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
alexander-akait approved these changes Nov 27, 2022
Member
| @snitin315 Feel free to merge when CI will be green |
snitin315 force-pushed the remove-listen-method branch from 7f4a432 to 612db16 Compare snitin315 added a commit that referenced this pull request Mar 16, 2023
snitin315 added a commit that referenced this pull request Apr 7, 2023
snitin315 added a commit that referenced this pull request May 6, 2023
snitin315 added a commit that referenced this pull request May 25, 2023
snitin315 added a commit that referenced this pull request Jan 13, 2024
alexander-akait pushed a commit that referenced this pull request Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
Remove deprecated listen and close methods.
Motivation / Use-Case
Breaking Changes
BREAKING CHANGE:
Server.listen()andServer.close()were removed in favor ofServer.start()andServer.stop()respectivelyAdditional Info
No