refactor!: remove the --web-socket-server cli option #4680
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
snitin315 requested review from alexander-akait, anshumanv and hiroppy as code owners 
Codecov ReportBase: 92.28% // Head: 92.28% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@ ## next #4680 +/- ## ======================================= Coverage 92.28% 92.28% ======================================= Files 15 15 Lines 1569 1569 Branches 586 586 ======================================= Hits 1448 1448 Misses 112 112 Partials 9 9
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
alexander-akait approved these changes Dec 12, 2022
snitin315 added a commit that referenced this pull request Mar 16, 2023
snitin315 added a commit that referenced this pull request Apr 7, 2023
snitin315 added a commit that referenced this pull request May 6, 2023
snitin315 added a commit that referenced this pull request May 25, 2023
snitin315 added a commit that referenced this pull request Jan 13, 2024
alexander-akait pushed a commit that referenced this pull request Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
Added test case for
--no-web-socket-server.Motivation / Use-Case
Remove the deprecated
--web-socket-serveroption.Breaking Changes
BREAKING CHANGE: the
--web-socket-server <value>cli option was removed in favor of the--web-socket-server-type <value>cli optionAdditional Info
NO