refactor!: remove the https and the http2 option #4661
Conversation
snitin315 requested review from alexander-akait, anshumanv and hiroppy as code owners 
Codecov ReportBase: 92.38% // Head: 92.45% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@ ## next #4661 +/- ## ========================================== + Coverage 92.38% 92.45% +0.06% ========================================== Files 15 15 Lines 1590 1578 -12 Branches 596 590 -6 ========================================== - Hits 1469 1459 -10 + Misses 112 110 -2 Partials 9 9
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
| I'll fix CI. |
| expect(pageErrors).toMatchSnapshot("page errors"); | ||
| }); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Just for check - do we have the same test cases for the other options (same for https)
There was a problem hiding this comment.
Yes, all test cases are present for the server option.
| Thank you, I think we will write the small migration guide before release to avoid many question and issues |
For Bugs and Features; did you add new tests?
Removed tests.
Motivation / Use-Case
Remove the deprecated
httpsandhttp2optionBreaking Changes
BREAKING CHANGES: the deprecated
httpsandhttp2options were removed in favor of theserveroptionAdditional Info
No