v14.17.4 proposal #39466
Merged
v14.17.4 proposal #39466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Original commit message: tracing: Update proto library build rule and roll Perfetto This patch removes use of the deprecated sources_assignment_filter GN feature from gni/proto_library.gni, since the extra descriptor files are no longer being generated. We also roll Perfetto to match the version used in Chrome and update test expectations accordingly. Bug: v8:10995 Change-Id: I65cb3b79feb6e5a7e5c8d99fdb8bf999a6048539 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2454079 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by: Peter Marshall <petermarshall@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#70381} Refs: v8/v8@1b1eda0 PR-URL: #39244 Refs: nodejs/build#2696 Reviewed-By: Richard Lau <rlau@redhat.com>
Original commit message: build: Remove no-op calls to set_sources_assignment_filter Chromiun no longer use set_sources_assignment_filter() anywhere in the build, so these are no longer needed. Bug: chromium:1018739 Change-Id: I7b33612d925563ebca0d93a7d3c9183d7305b7b0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2456988 Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#70405} Refs: v8/v8@92e6d33 PR-URL: #39244 Refs: nodejs/build#2696 Reviewed-By: Richard Lau <rlau@redhat.com>
Original commit message: Fix visiblity rules for configs enforced by the latest GN version. Prior versions of GN had a bug (gn:22) where visibility rules for configs weren't being enforced properly. This CL tweaks the visibility settings of some configs to conform to the latest version. Change-Id: Ic5d827a1f2774278d3894f67fe52bfca836c0409 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2360909 Commit-Queue: Dirk Pranke <dpranke@google.com> Reviewed-by: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#69463} Refs: v8/v8@7c182bd PR-URL: #39244 Refs: nodejs/build#2696 Reviewed-By: Richard Lau <rlau@redhat.com>
Original commit message: Fix implicit conversion loses integer precision warning The type of m is long in 64 bits build, and results implicit conversion loses integer precision, which was found by improved clang warning (-Wshorten-64-to-32) Bug: chromium:1124085 Change-Id: Ic9f22508bd817a06d5c90162b1ac3554a7171529 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2391323 Commit-Queue: Zequan Wu <zequanwu@google.com> Auto-Submit: Zequan Wu <zequanwu@google.com> Reviewed-by: Nico Weber <thakis@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#69686} Refs: v8/v8@0b3a4ec PR-URL: #39244 Refs: nodejs/build#2696 Reviewed-By: Richard Lau <rlau@redhat.com>
Original commit message: Add -Wno-string-concatenation to test/cctest:cctest_sources v8/test/cctest/interpreter/test-bytecode-generator.cc contains lots of string arrays with intentional concatenation. Bug: chromium:1114873 Change-Id: Ie9d35c3849b5b0a6d1d01b6ce21fb80a320d8736 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2366829 Commit-Queue: Arthur Eubanks <aeubanks@google.com> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#69625} Refs: v8/v8@8959494 PR-URL: #39244 Refs: nodejs/build#2696 Reviewed-By: Richard Lau <rlau@redhat.com>
These updates are necessary to build V8 with recent GN versions. PR-URL: #39244 Refs: nodejs/build#2696 Reviewed-By: Richard Lau <rlau@redhat.com>
This modifies 40df0dc so that the changes it applies are only used if ICU 67 or greater is used, and restores the previous code path for versions of ICU below 67. The minimum ICU version was bumped to 67 in Node.js 14.6.0 by #34356 but the referenced V8 commit[1] isn't on `v14.x-staging` and appears to have been reverted on V8 8.4[2] so this PR also restores the minimum ICU version to 65. [1] v8/v8@611e412 [2] v8/v8@eeccede PR-URL: #39068 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Original commit message: [JSON] Fix GC issue in BuildJsonObject We must ensure that the sweeper is not running or has already swept mutable_double_buffer. Otherwise the GC can add it to the free list. Bug: v8:11837 Change-Id: Ifd9cf15f1c94f664fd6489c70bb38b59730cdd78 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2928181 Commit-Queue: Victor Gomes <victorgomes@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/master@{#74859} Refs: v8/v8@81181a8 PR-URL: #39187 Fixes: #37553 Refs: v8/v8@81181a8 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
node-inspect developers have agreed to move node-inspect into core rather than vendor it as a dependency. Refs: https://github.com/nodejs/node/discussions/36481 PR-URL: #38161 Backport-PR-URL: #38858 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Michaël Zasso <targos@protonmail.com>
PR-URL: #38161 Backport-PR-URL: #38858 Refs: https://github.com/nodejs/node/discussions/36481 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Remove code that was for when `node-inspect` was called as a standalone process. PR-URL: #38161 Backport-PR-URL: #38858 Refs: https://github.com/nodejs/node/discussions/36481 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Fixes: #37224 PR-URL: #38161 Backport-PR-URL: #38858 Refs: https://github.com/nodejs/node/discussions/36481 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Michaël Zasso <targos@protonmail.com>
PR-URL: #38161 Backport-PR-URL: #38858 Refs: https://github.com/nodejs/node/discussions/36481 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Make five attempts with a timeout of 1 second each rather than 10 attempts with a timeout of 500ms each. This is to allow for slower-connecting devices like Raspberry Pi. PR-URL: #38161 Backport-PR-URL: #38858 Refs: https://github.com/nodejs/node/discussions/36481 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Michaël Zasso <targos@protonmail.com>
The test was assuming that the entire string being sought would arrive in a single data chunk, but it can be split across multiple chunks. PR-URL: #38161 Backport-PR-URL: #38858 Refs: https://github.com/nodejs/node/discussions/36481 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Migrate the node-inspect tests to core (where node-inspect code now lives) and remove node-inspect from deps directory. PR-URL: #38161 Backport-PR-URL: #38858 Refs: https://github.com/nodejs/node/discussions/36481 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Change process.binding() use to internalBinding(). PR-URL: #38161 Backport-PR-URL: #38858 Refs: https://github.com/nodejs/node/discussions/36481 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Michaël Zasso <targos@protonmail.com>
PR-URL: #38161 Backport-PR-URL: #38858 Refs: https://github.com/nodejs/node/discussions/36481 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Michaël Zasso <targos@protonmail.com>
PR-URL: #38161 Backport-PR-URL: #38858 Refs: https://github.com/nodejs/node/discussions/36481 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Michaël Zasso <targos@protonmail.com>
PR-URL: #38161 Backport-PR-URL: #38858 Refs: https://github.com/nodejs/node/discussions/36481 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Michaël Zasso <targos@protonmail.com>
PR-URL: #38431 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com>
There are many things called `url` in this page including `url` module, `URL` instances, etc. The original example was not clear where these methods come from. PR-URL: #38645 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #38644 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
The convention for js-native-api/<test_name>: * <test_name>.c or <test_name>.cc has the entry point * The name of the target is <test_name> PR-URL: #38692 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #38724 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: James M Snell <jasnell@gmail.com>
The implementation of the `fs.lchmod` method has been moved to JS-land PR-URL: #38693 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Added JSDoc typings for the `events` lib module. PR-URL: #38712 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Refs: https://coverage.nodejs.org/coverage-36bb31be5f0b85a0/lib/_http_outgoing.js.html#L351 Refs: https://coverage.nodejs.org/coverage-36bb31be5f0b85a0/lib/_http_outgoing.js.html#L609 PR-URL: #38734 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
richardlau force-pushed the v14.17.4-proposal branch from a531e49 to b07b7ce Compare richardlau added a commit that referenced this pull request Jul 22, 2021
Notable Changes: This releases fixes some regressions with internationalization introduced by the ICU updates in Node.js 14.17.0 and 14.17.1. PR-URL: #39466
Collaborator
Collaborator
richardlau added a commit that referenced this pull request Jul 23, 2021
Notable Changes: This releases fixes some regressions with internationalization introduced by the ICU updates in Node.js 14.17.0 and 14.17.1. PR-URL: #39466
richardlau force-pushed the v14.17.4-proposal branch from b07b7ce to ce03190 Compare Collaborator
Collaborator
Member Author
| The release will be delayed until at least tomorrow as I'm waiting on clarification on some commits. |
PR-URL: #39553 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com>
richardlau added a commit that referenced this pull request Jul 28, 2021
Notable Changes: - CVE-2021-22930: Use after free on close http2 on stream canceling (High) This releases fixes some regressions with internationalization introduced by the ICU updates in Node.js 14.17.0 and 14.17.1. PR-URL: #39466
richardlau force-pushed the v14.17.4-proposal branch from ce03190 to 8f3f617 Compare Collaborator
This is a security release. Notable Changes: - CVE-2021-22930: Use after free on close http2 on stream canceling (High) This releases fixes some regressions with internationalization introduced by the ICU updates in Node.js 14.17.0 and 14.17.1. PR-URL: #39466
richardlau force-pushed the v14.17.4-proposal branch from 8f3f617 to 488c27f Compare Collaborator
richardlau added a commit that referenced this pull request Jul 29, 2021
This is a security release. Notable Changes: - CVE-2021-22930: Use after free on close http2 on stream canceling (High) This releases fixes some regressions with internationalization introduced by the ICU updates in Node.js 14.17.0 and 14.17.1. PR-URL: #39466
richardlau added a commit to richardlau/nodejs.org that referenced this pull request Jul 29, 2021
richardlau added a commit to nodejs/nodejs.org that referenced this pull request Jul 29, 2021
foxxyz pushed a commit to foxxyz/node that referenced this pull request Oct 18, 2021
This is a security release. Notable Changes: - CVE-2021-22930: Use after free on close http2 on stream canceling (High) This releases fixes some regressions with internationalization introduced by the ICU updates in Node.js 14.17.0 and 14.17.1. PR-URL: nodejs#39466
foxxyz pushed a commit to foxxyz/node that referenced this pull request Oct 18, 2021
PR-URL: nodejs#39466
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
2021-07-29, Version 14.17.4 'Fermium' (LTS), @richardlau
This is a security release.
Notable Changes
This releases also fixes some regressions with internationalization introduced by the ICU updates in Node.js 14.17.0 and 14.17.1.
Commits
86477b2b53] - benchmark: output JSON-compatible numbers (Michaël Zasso) #38778f9693cf0a0] - benchmark: fix http elapsed time (Antoine du Hamel) #387431ab4f81abc] - build: fix building with external builtins (Momtchil Momtchev) #39091a657f250f1] - build: reconfigure when gyp files change on Windows (Joyee Cheung) #390666962c647d6] - Revert "build: work around bug in MSBuild v16.10.0" (Michaël Zasso) #38977069cf59e56] - build: make build-addons errors fail the build (Richard Lau) #38983d341561ae0] - build: fix commit-queue default branch (Mary Marchini) #389980736dd833a] - build: don't pass python override to V8 build (Richard Lau) #3896949a000683a] - build: correct Xcode spelling in .gitignore (bl-ue) #388951ffbe3d5da] - build: remove outdated dont-land-on-v6.x label (Michaël Zasso) #388867f53a0b349] - build: add lto build to CI (Jiawen Geng) #38567a6f8ba8f0c] - build: allow LTO with Clang 3.9.1+ (Jesse Chan) #38751b5b1d1fb79] - build: replace non-POSIX test -a|o (Issam E. Maghni) #38731fc2b1ec308] - child_process: refactor to usevalidateBoolean(Qingyu Deng) #3892755ea29eedd] - child_process: retain reference to data with advanced serialization (Anna Henningsen) #38728716ee1531c] - debugger: rename internal library for clarity (Rich Trott) #39080b7ee9d8287] - debugger: use ERR_DEBUGGER_STARTUP_ERROR in _inspect.js (Rich Trott) #390245d4d23dcf3] - debugger: use error codes in debugger REPL (Rich Trott) #39024a3991d7c18] - debugger: use ERR_DEBUGGER_ERROR in debugger client (Rich Trott) #39024052e1c5385] - debugger: removed unused function argument (Rich Trott) #38850f9a4dcb30c] - debugger: refactorinspect_replto use primordials (Antoine du Hamel) #38551ad8056659f] - debugger: refactor to use internal modules (Antoine du Hamel) #38550b5724a1984] - debugger: disable only the lint rules required by current file state (Rich Trott) #3852934659f2b7a] - debugger: avoid non-ASCII char in code file (Rich Trott) #38529ae90756582] - debugger: wrap lines longer than 80 chars (Rich Trott) #38529b30ff35a36] - debugger: align message with Node.js standard (Rich Trott) #38400d74d67f207] - debugger: remove unnecessary boilerplate copyright comment (Rich Trott) #38952e58f938ab3] - debugger: enable linter oninternal/inspector/inspect_client(Antoine du Hamel) #38417249acd5e69] - debugger: reduce scope of eslint disable comment (Rich Trott) #389460ef5e088c0] - debugger: revise async iterator usage to comply with lint rules (Rich Trott) #3884779bfb0416b] - debugger: wait for V8 debugger to be enabled (Michaël Zasso) #38811721edeffd3] - debugger: refactorinternal/inspector/_inspectto use more primordials (Antoine du Hamel) #3840621ecee1b4b] - debugger: add usage example for--port(Rafael Gonzaga) #38400cde72213d1] - Revert "debugger: rename internal library for clarity" (Antoine du Hamel) #394464c2b813799] - debugger: rename internal library for clarity (Rich Trott) #3908061da371251] - debugger: apply automatic lint fixes for inspect_repl.js (Rich Trott) #384118dd1f70fe3] - debugger: apply automatic lint fixes for _inspect.js (Rich Trott) #38411fb0ab4c034] - debugger: removed unused function argument (Rich Trott) #388509e28c6c946] - debugger: fix race condition/deadlock on initialization (Rich Trott) #38161a8924fa0fb] - debugger: replace internal use of deprecated API (Rich Trott) #3816122afb7cbe6] - debugger: allow longer time to connect (Rich Trott) #38161b172e6f436] - debugger: accommodate line chunking in Windows (Rich Trott) #381611da692185a] - debugger: fix inspect restart on Windows (Rich Trott) #381610321c5b194] - debugger: remove unused code (Rich Trott) #381618bd2a3926a] - debugger: move node-inspect to internal library (Rich Trott) #38161acf5279c39] - deps: upgrade npm to 6.14.14 (Darcy Clarke) #395534efefe02a8] - deps: V8: backport ae7bfb3f03b3 (Michaël Zasso) #390515039f21396] - deps: V8: backport 16ffec97e5eb (Michaël Zasso) #390519b69069f71] - deps: V8: cherry-pick b0a7f5691113 (Michaël Zasso) #390514213e97d26] - deps: V8: cherry-pick 81181a8ad80a (thomasmichaelwallace) #39187ccecea5f72] - deps: restore minimum ICU version to 65 (Richard Lau) #390687557e74cf4] - deps: V8: update build dependencies (Michaël Zasso) #39244a60a960406] - deps: V8: cherry-pick 895949419186 (Michaël Zasso) #392447fdd6ecbb4] - deps: V8: cherry-pick 0b3a4ecf7083 (Michaël Zasso) #392444be2e878b7] - deps: V8: cherry-pick 7c182bd65f42 (Michaël Zasso) #39244a83b01a4af] - deps: V8: cherry-pick 92e6d3317082 (Michaël Zasso) #3924417eb561184] - deps: V8: backport 1b1eda0876aa (Michaël Zasso) #3924404032fa1a3] - doc: remove references to deleted freenode channels (devsnek) #39047797bd73849] - doc: add missing parameter types (Voltrex) #39013e474e984e5] - doc: clarify that only one Python version is required to build (bl-ue) #38894cd48ee71d9] - doc: fixed typo in process.md (Derevianchenko Maksym) #3894141fcbad2b2] - doc: add missing semis after classes (Darshan Sen) #38931b40529643b] - doc: mark util.inherits as legacy (Voltrex) #38896b2d836b1ea] - doc: clarify whenreadable._read(...)is called (Shaun Keys) #38726e36d2a6d6a] - doc: fixed typo in n-api.md (julianjany) #38822b4f60bb523] - doc: use "Long Term Support" in collaborator guide (Rich Trott) #388417a9850a5fb] - doc: use "Long Term Support" in technical values doc (Rich Trott) #38841dfe9698db0] - doc: use "Long Term Support" in README (Philip) #388398699e622fc] - doc: fix grammar infs.md(yotamselementor) #38818826ae9b2e2] - doc: fixup code sample in http.md (TodorTotev) #387768049b69b7f] - doc: document null target pattern (Guy Bedford) #387244d9129eb71] - doc: update code examples fornode:urlmodule (fisker Cheung) #386452ff671e4c4] - doc,url: clarify domainTo* when built without ICU (Darshan Sen) #387899b993edca8] - errors: add ERR_DEBUGGER_STARTUP_ERROR (Rich Trott) #39024cfccf13e84] - errors: add ERR_DEBUGGER_ERROR (Rich Trott) #39024bb9a9adc2b] - errors: don't rekey on primitive type (Benjamin Coe) #39025d48b91ea2b] - http2: on receiving rst_stream with cancel code add it to pending list (Akshay K) #39423d8cc2fffd6] - lib: add primordials.SafeArrayIterator (Antoine du Hamel) #36532e3223edb89] - lib: harden lint checks for globals (Antoine du Hamel) #38419d4f96bb926] - lib: enforce usingprimordials.globalThisinstead ofglobal(Antoine du Hamel) #38230ea9003a559] - lib: addglobalThisto primordials (Antoine du Hamel) #38211097a7874d3] - lib: remove semicolon in preparation for babel/eslint-parser update (Rich Trott) #39094199fe32cbc] - lib: make internal/options lazy (Joyee Cheung) #389932bc2a232af] - lib: add JSDoc typings for child_process (Voltrex) #38222b0a1984d4d] - lib: fix typos (bl-ue) #388466c061d5f2c] - meta: update label-pr-config (Michaël Zasso) #38950afb61786b9] - module: fix legacynodespecifier resolution to resolve"main"field (Antoine du Hamel) #38979cd3305a9e4] - node-api: avoid SecondPassCallback crash (Michael Dawson) #38899e7f266e93d] - src: use SPrintF in ProcessEmitWarning (Darshan Sen) #3875843fe6c1d27] - src: cleanup uv_fs_t regardless of success or not (legendecas) #38996dcfb182546] - src: refactor to use locale functions (Darshan Sen) #39014bee477b000] - src: throw error in LoadBuiltinModuleSource when reading fails (Joyee Cheung) #38904ff7cc8f9ef] - src: add not-weak DCHECK to PersistentToLocal::Strong (Anna Henningsen) #38875981217e48a] - src: replaceautos in node_api.cc (Khaidi Chu) #3885273e199d963] - src: fix typos (bl-ue) #388452d32031724] - src: use HandleScope in StreamReq::Done() (Darshan Sen) #387202c11d3ec0a] - src: remove commented code innode_file.cc(Juan José Arboleda) #38693846a138f54] - src: write named pipe info in diagnostic report (legendecas) #386377d82200861] - src: replaceautos in node_contextify.cc (Khaidi Chu) #3864451da7d2048] - src,url: separate some tables out of node_url.cc (Khaidi Chu) #3898845c2ea3b72] - test: add NumberFormat resolvedOptions test (Richard Lau) #394016b2fea38d1] - test: move inspector-cli tests to sequential (Rich Trott) #390796447cab7be] - test: improve buffer coverage (Rongjian Zhang) #385386f1862eab3] - test: fix name of variable in inspector-cli test (Tobias Nießen) #3886940093504bc] - test: fix typo (Houssem Chebab) #39045ab28f9b9a1] - test: remove obsolete TLS test (Rich Trott) #39001b3b59953fe] - test: improve coverage of lib/events.js (Rongjian Zhang) #38582c99a09f05f] - test: http outgoing _headers setter null (ycjcl868) #38881660a97b1d5] - test: suppress warning in test_environment.cc (Daniel Bevenius) #388680cca16ac4c] - test: improve coverage of fs internal utils (Rongjian Zhang) #38746fecad40f27] - test: fix writefile with fd (Nitzan Uziely) #3882001f00faaa8] - test: simplify test-path-resolve.js (himself65) #38671504bfd7a88] - test: improve coverage forquestionin readline (Qingyu Deng) #38799eb91932e77] - test: os, replace custom flatten method with built-in Array.flat (Wael Almattar) #38770aeea252b96] - test: improve coverage of lib/_http_outgoing.js (Rongjian Zhang) #38734e265d8ee1b] - test: give js-native-api tests consistent names (Gabriel Schulhof) #3869299fd8bfc6a] - test: fix flaky inspector-cli tests when breakpionts are restored (Rich Trott) #384314d3a1fad28] - test: extend timeout on debugger tests for slower machines (Rich Trott) #38161dd2642b5db] - test: fix comment typo (Rich Trott) #38161193ea8fd91] - test: fix test-inspector-cli-address (Rich Trott) #38161a62826bbe6] - test,debugger: migrate node-inspect tests to core (Rich Trott) #38161ab45ace9bd] - tools: update babel-eslint-parser to 7.14.5 (Rich Trott) #39094b8e63b3c08] - tools: update ESLint to 7.29.0 (Rich Trott) #3908354a250e79c] - tools: update doctool dependencies, migrate to ESM (Michaël Zasso) #38966443db64eed] - tools: avoid crashing CQ when git push fails (Antoine du Hamel) #36861547f88b149] - tools: fix typo in commit-queue.sh (bl-ue) #390001023433a81] - tools: update ESLint to 7.28.0 (Luigi Pinca) #389559b4ae8fbb0] - tools: bump remark-preset-lint-node to 2.3.0 (Rich Trott) #389102ad0719e86] - tools: refloat 7 Node.js patches to cpplint.py (Rich Trott) #38851b7686d0c1e] - tools: bump cpplint to 1.5.5 (Rich Trott) #388512ec7c9de57] - tools: remove exception for Node.js 8 and earlier (Rich Trott) #388401dc71da302] - tools: update setup-node to setup-node@v2 (pengjie) #38825fc219d862c] - tools: remove node-inspect from license (Rich Trott) #381614bb0bd0f0e] - tools,doc: forbid CJS globals in ESM code snippets (Antoine du Hamel) #3888958154ce426] - typings: add JSDoc typings for https (Voltrex) #385896ea1368a67] - typings: add JSDoc typings for events (Voltrex) #38712b6942a6138] - url,src: simplify ipv6 logic by using uv_inet_pton (Khaidi Chu) #38842dd00547ada] - vm: use missing validator (Voltrex) #389352c28e00685] - worker: do not look up context twice in PostMessage (Anna Henningsen) #38784