doc: document null target pattern #38724
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
1 task
Member
| To confirm, this works with any node version that supports the object form? |
Contributor Author
| @ljharb yes it's supported in all versions. |
aduh95 approved these changes May 19, 2021
Contributor
aduh95 left a comment
aduh95 left a comment There was a problem hiding this comment.
Do we have a test for this? If not we probably should, but that's not blocking this PR anyway.
Contributor Author
| There's a bunch of these tests in https://github.com/nodejs/node/blob/master/test/fixtures/node_modules/pkgexports/package.json. Not for subpath patterns though, but it's a straightforward extension. |
DerekNonGeneric approved these changes May 19, 2021
Contributor
DerekNonGeneric left a comment
DerekNonGeneric left a comment There was a problem hiding this comment.
I vaguely remember you telling me about this on the call we had last year.
jasnell approved these changes May 19, 2021
guybedford added a commit that referenced this pull request May 20, 2021
PR-URL: #38724 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: James M Snell <jasnell@gmail.com>
Contributor Author
| Landed in 01940ee. |
danielleadams pushed a commit that referenced this pull request May 31, 2021
PR-URL: #38724 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
richardlau pushed a commit that referenced this pull request Jul 16, 2021
PR-URL: #38724 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: James M Snell <jasnell@gmail.com>
richardlau pushed a commit that referenced this pull request Jul 19, 2021
PR-URL: #38724 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: James M Snell <jasnell@gmail.com>
richardlau pushed a commit that referenced this pull request Jul 20, 2021
PR-URL: #38724 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
foxxyz pushed a commit to foxxyz/node that referenced this pull request Oct 18, 2021
PR-URL: nodejs#38724 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
We don't currently document
nulltargets in package "exports", which provide a useful exclude functionality when used in subpath patterns. This extends the subpath patterns docs with a short description and example of this behaviour.@nodejs/modules