Fix building with external builtins #39090 #39091
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
github-actions bot added c++ 
addaleax approved these changes Jun 20, 2021
addaleax added request-ci github-actions bot removed the request-ci 
Collaborator
aduh95 approved these changes Jun 20, 2021
aduh95 added the author ready Collaborator
cjihrig approved these changes Jun 20, 2021
RaisinTen approved these changes Jun 21, 2021
lpinca approved these changes Jun 21, 2021
aduh95 added the commit-queue github-actions bot added commit-queue-failed 
Contributor
Commit Queue failed- Loading data for nodejs/node/pull/39091 ✔ Done loading data for nodejs/node/pull/39091 ----------------------------------- PR info ------------------------------------ Title Fix building with external builtins #39090 (#39091) Author Momtchil Momtchev (@mmomtchev) Branch mmomtchev:nobuiltins-build -> nodejs:master Labels author ready, c++ Commits 1 - Fix building with external builtins #39090 Committers 1 - Momtchil Momtchev PR-URL: https://github.com/nodejs/node/pull/39091 Fixes: https://github.com/nodejs/node/issues/39090 Reviewed-By: Anna Henningsen Reviewed-By: Antoine du Hamel Reviewed-By: Colin Ihrig Reviewed-By: Darshan Sen Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/39091 Fixes: https://github.com/nodejs/node/issues/39090 Reviewed-By: Anna Henningsen Reviewed-By: Antoine du Hamel Reviewed-By: Colin Ihrig Reviewed-By: Darshan Sen Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Sat, 19 Jun 2021 14:53:26 GMT ✔ Approvals: 5 ✔ - Anna Henningsen (@addaleax): https://github.com/nodejs/node/pull/39091#pullrequestreview-687920755 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/39091#pullrequestreview-687938982 ✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/39091#pullrequestreview-687944992 ✔ - Darshan Sen (@RaisinTen): https://github.com/nodejs/node/pull/39091#pullrequestreview-688500108 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/39091#pullrequestreview-688798418 ✔ Last GitHub Actions successful ℹ Last Full PR CI on 2021-06-20T20:43:28Z: https://ci.nodejs.org/job/node-test-pull-request/38707/ - Querying data for job/node-test-pull-request/38707/ ✔ Build data downloaded ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/master up to date... From https://github.com/nodejs/node * branch master -> FETCH_HEAD ✔ origin/master is now up-to-date - Downloading patch for 39091 From https://github.com/nodejs/node * branch refs/pull/39091/merge -> FETCH_HEAD ✔ Fetched commits as 520ad586584a..74b12e6d13de -------------------------------------------------------------------------------- [master 2e821ef066] Fix building with external builtins #39090 Author: Momtchil Momtchev Date: Sat Jun 19 16:52:59 2021 +0200 1 file changed, 1 insertion(+) ✔ Patches applied -------------------------------------------------------------------------------- --------------------------------- New Message ---------------------------------- Fix building with external builtins #39090https://github.com/nodejs/node/actions/runs/974315611 |
PR-URL: nodejs#39091 Fixes: nodejs#39090 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Contributor
| Landed in 19b80cc |
RaisinTen pushed a commit to RaisinTen/node that referenced this pull request Jul 18, 2021
PR-URL: nodejs#39091 Fixes: nodejs#39090 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
richardlau pushed a commit to RaisinTen/node that referenced this pull request Jul 19, 2021
PR-URL: nodejs#39091 Fixes: nodejs#39090 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
richardlau pushed a commit that referenced this pull request Jul 19, 2021
PR-URL: #39091 Backport-PR-URL: #39419 Fixes: #39090 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
richardlau pushed a commit that referenced this pull request Jul 20, 2021
PR-URL: #39091 Backport-PR-URL: #39419 Fixes: #39090 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
targos removed the commit-queue-failed foxxyz pushed a commit to foxxyz/node that referenced this pull request Oct 18, 2021
PR-URL: nodejs#39091 Backport-PR-URL: nodejs#39419 Fixes: nodejs#39090 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes: #39090