module: fix legacy node specifier resolution to resolve "main" field #38979
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
github-actions bot added esm 
RaisinTen reviewed Jun 9, 2021
RaisinTen reviewed Jun 9, 2021
bmeck approved these changes Jun 9, 2021
Collaborator
Collaborator
Collaborator
aduh95 added the author ready Contributor Author
| @nodejs/modules FYI |
guybedford approved these changes Jun 11, 2021
| what's the rationale for allowing this? iirc (+0 on this change, if curious; i do not wish to block anything) |
Member
| “exports” isn’t required; packages aren’t going to be forced to use it and its encapsulation feature. “main” isn’t deprecated. |
PR-URL: nodejs#38979 Fixes: nodejs#32103 Fixes: nodejs#38739 Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com>
aduh95 force-pushed the resolve-main-node branch from aa99628 to 4e17ffc Compare Contributor Author
| Landed in 4e17ffc |
3 tasks
Merged
Merged
aduh95 added a commit to aduh95/node that referenced this pull request Jul 23, 2021
PR-URL: nodejs#38979 Fixes: nodejs#32103 Fixes: nodejs#38739 Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com>
aduh95 added a commit to aduh95/node that referenced this pull request Jul 28, 2021
PR-URL: nodejs#38979 Fixes: nodejs#32103 Fixes: nodejs#38739 Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com>
richardlau pushed a commit that referenced this pull request Jul 28, 2021
richardlau pushed a commit that referenced this pull request Jul 28, 2021
Merged
foxxyz pushed a commit to foxxyz/node that referenced this pull request Oct 18, 2021
PR-URL: nodejs#38979 Fixes: nodejs#32103 Fixes: nodejs#38739 Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes: #38739
Fixes: #32103