Skip to content

Conversation

@dsnopek
Copy link
Collaborator

@dsnopek dsnopek commented Jan 27, 2025

The 3rd batch of PR's marked with cherrypick:4.3

Copy link
Member

@Ivorforce Ivorforce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested 50cc828 with my 4.3 GDExtension. Compiled and ran fine!

dsnopek and others added 7 commits January 28, 2025 10:37
The use of .components is deprecated. (cherry picked from commit 23c9d41)
A global alias of godot::real_t is defined for backward compatibility (cherry picked from commit 450c3d6)
Repiteo and others added 11 commits January 28, 2025 10:37
…e'. If a user attempts to call either of these it will introduce a linker error and it may not be immediately clear to them why. Also, variant interpolation can already be accessed via 'UtilityFunctions::lerp', making at least the interpolate function unecessary here. (cherry picked from commit 42a35a1)
Due to how caches are accessed this cache is almost useless, it only matters if it is from the same branch or a base branch, and is identical between branches, so caching it just clutters the build cache (cherry picked from commit 1e3b24f)
This allows removing dependencies that are not explicitly unused by the gdextension being built and is implemented using an intermediate json API file with the methods and classes stripped (i.e. without touching the file generators). (cherry picked from commit c4f1abe)
@dsnopek
Copy link
Collaborator Author

dsnopek commented Jan 28, 2025

@Ivorforce @paddy-exe Thanks for reviewing!

@dsnopek dsnopek merged commit f3a1a2f into godotengine:4.3 Jan 28, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug This has been identified as a bug enhancement This is an enhancement on the current functionality

10 participants