Rename Vector4.components -> coords. #1609
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Should be made in the same PR, ether we add compatibility or we don't, it should be decided and done in one PR |
| Yes, in the current state of the PR the 'components' union case is retained, with a deprecation note. |
AThousandShips added the enhancement | Parent PR is merged, so we're good to go. |
dsnopek approved these changes Oct 29, 2024
| I was about to merge this and then realized it's 2 commits. This'll need to be squashed to a single commit before it can merged. |
The use of .components is deprecated.
| Ok, fixed. |
| Thanks! |
| Cherry-picked for 4.2 in PR #1694 |
| Cherry-picked for 4.3 in PR #1695 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Follow-up of godotengine/godot#97487 (review)
Fixes #1608
As mentioned, a discussion could be had about just removing the 'components' alias, but I think there's no harm just using deprecations as is usually done.