Skip to content

Conversation

@ruffenman
Copy link
Contributor

If a user attempts to call either of these it will introduce a linker error and it may not be immediately clear to them why. Also, variant interpolation can already be accessed via 'UtilityFunctions::lerp', making at least the interpolate function unnecessary here.

…e'. If a user attempts to call either of these it will introduce a linker error and it may not be immediately clear to them why. Also, variant interpolation can already be accessed via 'UtilityFunctions::lerp', making at least the interpolate function unecessary here.
@ruffenman ruffenman requested a review from a team as a code owner October 15, 2024 00:36
@dsnopek dsnopek added bug This has been identified as a bug cherrypick:4.2 cherrypick:4.3 labels Oct 29, 2024
@dsnopek dsnopek added this to the 4.x milestone Oct 29, 2024
Copy link
Collaborator

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I looks like Godot doesn't have these functions on its version of Variant, so I think removing them is the right way to go.

@dsnopek dsnopek merged commit 688ed4b into godotengine:master Oct 30, 2024
12 checks passed
@dsnopek
Copy link
Collaborator

dsnopek commented Jan 27, 2025

Cherry-picked for 4.2 in PR #1694

@dsnopek
Copy link
Collaborator

dsnopek commented Jan 27, 2025

Cherry-picked for 4.3 in PR #1695

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug This has been identified as a bug

2 participants