Skip to content

Conversation

georgewallace
Copy link
Contributor

Added various features and fixes related to search functionality, APM metrics, and security enhancements in the Elastic Cloud Serverless release notes.

Added various features and fixes related to search functionality, APM metrics, and security enhancements in the Elastic Cloud Serverless release notes.
Copy link
Collaborator

@shainaraskas shainaraskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added some initial comments

Comment on lines +119 to +136
* Add relevant attributes to search took time APM metrics [#134232](https://github.com/elastic/elasticsearch/pull/134232)
* [ML] Adding headers support for OpenAI chat completion [#134504](https://github.com/elastic/elasticsearch/pull/134504)
* Extend kibana-system permissions to manage security entities [#133968](https://github.com/elastic/elasticsearch/pull/133968)
* Track shardStarted events for simulation in DesiredBalanceComputer [#133630](https://github.com/elastic/elasticsearch/pull/133630)
* Add file extension metadata to cache miss counter from SharedBlobCacheService [#134374](https://github.com/elastic/elasticsearch/pull/134374)
* Remove ingest conditionals _type deprecation warning [#134851](https://github.com/elastic/elasticsearch/pull/134851)
* Allow including semantic field embeddings in _source [#134717](https://github.com/elastic/elasticsearch/pull/134717)
* Integrate weights into simplified RRF retriever syntax [#132680](https://github.com/elastic/elasticsearch/pull/132680)
* DLM: Better `max_age` rollover for tiny retentions [#134941](https://github.com/elastic/elasticsearch/pull/134941)
* ES|QL: add support for include_execution_metadata parameter [#134446](https://github.com/elastic/elasticsearch/pull/134446)
* ESQL: Add telemetry support for Lookup Join On Expression [#134942](https://github.com/elastic/elasticsearch/pull/134942)
* Improve block loader for source only runtime fields of type keyword [#135026](https://github.com/elastic/elasticsearch/pull/135026)
* Optimize BytesArray::indexOf, which is used heavily in ndjson parsing [#135087](https://github.com/elastic/elasticsearch/pull/135087)
* Make SecureString comparisons constant time [#135053](https://github.com/elastic/elasticsearch/pull/135053)
* ESQL: URL encoding changes [#134503](https://github.com/elastic/elasticsearch/pull/134503)
* Add new `/_security/stats` endpoint [#134835](https://github.com/elastic/elasticsearch/pull/134835)
* Have last source shard to complete remove reshard metadata
* Add a monitor for estimated heap usage
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other items in this list use 3rd person verbs ("Adds" rather than "Add") so these should all be updated to relfect that

I worry that some of these are not relevant to expose to end users, but I'm not sure who would be the right person to validate this list

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

best guess (lots of bad assumptions though)

I think this raises a lot of questions about what types of changes we want to expose in these release notes - do we expose refactoring that has a positive impact on the performance of the product? do we expose info related to shards (not a serverless concept)? or do we only list things that the user can go use? do we perhaps categorize these so the list is a little more parseable?

  • Add relevant attributes to search took time APM metrics #134232
  • [ML] Adding headers support for OpenAI chat completion #134504
    * Extend kibana-system permissions to manage security entities #133968
    * Track shardStarted events for simulation in DesiredBalanceComputer #133630
    * Add file extension metadata to cache miss counter from SharedBlobCacheService #134374
  • Remove ingest conditionals _type deprecation warning #134851 (sounds like a bug fix)
  • Allow including semantic field embeddings in _source #134717
  • Integrate weights into simplified RRF retriever syntax #132680
  • DLM: Better max_age rollover for tiny retentions #134941
  • ES|QL: add support for include_execution_metadata parameter #134446
  • ESQL: Add telemetry support for Lookup Join On Expression #134942 (this might be missing from other docs?)
  • Improve block loader for source only runtime fields of type keyword #135026
  • Optimize BytesArray::indexOf, which is used heavily in ndjson parsing #135087
  • Make SecureString comparisons constant time #135053
  • ESQL: URL encoding changes #134503
  • Add new /_security/stats endpoint #134835
  • Have last source shard to complete remove reshard metadata
    * Add a monitor for estimated heap usage
* Integrate weights into simplified RRF retriever syntax [#132680](https://github.com/elastic/elasticsearch/pull/132680)
* DLM: Better `max_age` rollover for tiny retentions [#134941](https://github.com/elastic/elasticsearch/pull/134941)
* ES|QL: add support for include_execution_metadata parameter [#134446](https://github.com/elastic/elasticsearch/pull/134446)
* ESQL: Add telemetry support for Lookup Join On Expression [#134942](https://github.com/elastic/elasticsearch/pull/134942)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* ESQL: Add telemetry support for Lookup Join On Expression [#134942](https://github.com/elastic/elasticsearch/pull/134942)
* ES|QL: Add telemetry support for Lookup Join On Expression [#134942](https://github.com/elastic/elasticsearch/pull/134942)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants