DLM: Better max_age rollover for tiny retentions #134941
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
szybia added v9.2.0 >enhancement :Data Management/Data streams 
Collaborator
| Hi @szybia, I've created a changelog YAML for you. |
Collaborator
| Hi @szybia, I've updated the changelog YAML for you. |
elasticsearchmachine added the Team:Data Management Collaborator
| Pinging @elastic/es-data-management (Team:Data Management) |
dakrone approved these changes Sep 18, 2025
Member
dakrone left a comment
dakrone left a comment There was a problem hiding this comment.
LGTM, I left one minor comment, thanks Szymon!
docs/changelog/134941.yaml Outdated
| @@ -0,0 +1,6 @@ | |||
| pr: 134941 | |||
| summary: "Streams: Adjust `max_age` for tiny retentions" | |||
Member
There was a problem hiding this comment.
Let's change this since it's not specific to streams:
Suggested change
| summary: "Streams: Adjust `max_age` for tiny retentions" | |
| summary: "DLM: Improve automatic `max_age` rollover condition for tiny retentions" |
Contributor Author
There was a problem hiding this comment.
updated to best of my ability to keep title under 50 chars
Member
There was a problem hiding this comment.
We don't have to keep the summaries under 50 chars I think? That limit is usually for GH PR titles I believe.
Contributor Author
There was a problem hiding this comment.
ah, assumed we want to keep these the same
i'll keep this in mind for the future
szybia changed the title max_age rollover for tiny retentions * upstream/main: (43 commits) Unmute testAckedIndexing to see if it still fails on main (elastic#134682) Silence time zone ID deprecation warning for JDK 25 due to log4j2 bug. (elastic#134719) Adding a getUnmodifiableSourceAndMetadata() method to IngestDocument (elastic#134816) Mark the create-index-from-source action as publicly available on Serverless (elastic#134953) ESQL: Rename command from INLINESTATS to INLINE STATS (elastic#134827) Document multi index query support for simplified retrievers (elastic#134980) [ML] Fix YAMl test to use correct query parameter type (elastic#134999) [Transform] Wait for PIT to close (elastic#134955) Add XPath to XmlUtils (elastic#134923) Fixing conditional processor mutability bugs (elastic#134936) [Transform] Lower loglevel of 3 transform-related error messages from ERROR to WARN (elastic#134985) Unmute pattern text tests. (elastic#134981) Integrate weights into simplified RRF retriever syntax (elastic#132680) Mute org.elasticsearch.xpack.esql.qa.mixed.MixedClusterEsqlSpecIT test {csv-spec:stats.CountDistinctWithConditions} elastic#134993 Update periodic java-ea build to test java 26 pre-release (elastic#134983) Mute org.elasticsearch.xpack.esql.ccq.MultiClusterSpecIT test {csv-spec:stats.CountDistinctWithConditions} elastic#134984 Fix and unmute testIndexSettingProviderPrivateSetting (elastic#134861) Add missing common cat params (elastic#134870) Support querying multiple indices with the simplified RRF retriever (elastic#134822) Allow including semantic field embeddings in _source (elastic#134717) ...
phananh1010 added a commit to phananh1010/elasticsearch that referenced this pull request Sep 23, 2025
BASE=6a1d6bf45243b971e81384c6edb3d9a44a0580b8 HEAD=cdd8ceeee7541f2657e7528f58c5dffd4e5adc2e Branch=main
phananh1010 added a commit to phananh1010/elasticsearch that referenced this pull request Oct 2, 2025
BASE=6a1d6bf45243b971e81384c6edb3d9a44a0580b8 HEAD=cdd8ceeee7541f2657e7528f58c5dffd4e5adc2e Branch=main
phananh1010 added a commit to phananh1010/elasticsearch that referenced this pull request Oct 2, 2025
BASE=6a1d6bf45243b971e81384c6edb3d9a44a0580b8 HEAD=cdd8ceeee7541f2657e7528f58c5dffd4e5adc2e Branch=main
phananh1010 added a commit to phananh1010/elasticsearch that referenced this pull request Oct 7, 2025
BASE=6a1d6bf45243b971e81384c6edb3d9a44a0580b8 HEAD=cdd8ceeee7541f2657e7528f58c5dffd4e5adc2e Branch=main
phananh1010 added a commit to phananh1010/elasticsearch that referenced this pull request Oct 17, 2025
BASE=6a1d6bf45243b971e81384c6edb3d9a44a0580b8 HEAD=cdd8ceeee7541f2657e7528f58c5dffd4e5adc2e Branch=main
phananh1010 added a commit to phananh1010/elasticsearch that referenced this pull request Oct 23, 2025
BASE=6a1d6bf45243b971e81384c6edb3d9a44a0580b8 HEAD=cdd8ceeee7541f2657e7528f58c5dffd4e5adc2e Branch=main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Context for change in issue below.
Closes #130960