Skip to content

ESQL: Rename command from INLINESTATS to INLINE STATS #134827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Sep 18, 2025
Merged

ESQL: Rename command from INLINESTATS to INLINE STATS #134827

merged 16 commits into from
Sep 18, 2025

Conversation

bpintea
Copy link
Contributor

@bpintea bpintea commented Sep 16, 2025 •
edited
Loading

This simply renames INLINESTATS to INLINE STATS.

The INLINESTATS is still kept working for now, but it emits a deprecation warning.

Closes #133998
@github-actions GitHub Actions
Copy link
Contributor

ℹ️ Important: Docs version tagging

👋 Thanks for updating the docs! Just a friendly reminder that our docs are now cumulative. This means all 9.x versions are documented on the same page and published off of the main branch, instead of creating separate pages for each minor version.

We use applies_to tags to mark version-specific features and changes.

Expand for a quick overview

When to use applies_to tags:

✅ At the page level to indicate which products/deployments the content applies to (mandatory)
✅ When features change state (e.g. preview, ga) in a specific version
✅ When availability differs across deployments and environments

What NOT to do:

❌ Don't remove or replace information that applies to an older version
❌ Don't add new information that applies to a specific version without an applies_to tag
❌ Don't forget that applies_to tags can be used at the page, section, and inline level

🤔 Need help?
@bpintea bpintea added the ES|QL-ui Impacts ES|QL UI label Sep 16, 2025
bpintea
bpintea commented Sep 17, 2025
View reviewed changes
x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/parser/StatementParserTests.java
);
}

public void testInlineStatsParsing() {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added tests.
bpintea
bpintea commented Sep 17, 2025
View reviewed changes
x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/analysis/AnalyzerTests.java
""", "Found 1 problem\n" + "line 2:50: Unknown column [x]", "mapping-default.json");
}

public void testInlineStatsStats() {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added test. The rest, besides the grammar changes, are mostly just renames.
@bpintea bpintea marked this pull request as ready for review September 17, 2025 11:18
@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Sep 17, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/kibana-esql (ES|QL-ui)
@vadimkibana vadimkibana mentioned this pull request Sep 15, 2025
Closed
8 tasks
@stratoula stratoula mentioned this pull request Sep 18, 2025
Closed
2 tasks
alex-spies
alex-spies approved these changes Sep 18, 2025
View reviewed changes
Copy link
Contributor

@alex-spies alex-spies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't perform a terribly deep review, but had a look at the grammar change. Looks right to me! As this change is mostly mechanical, it LGTM.

And I appreciate updating the error messages and comments as well!
docs/reference/query-languages/esql/kibana/definition/commands/inline_stats.json
{
"comment" : "This is generated by ESQL’s DocsV3Support. Do not edit it. See ../README.md for how to regenerate it.",
"type" : "command",
"name" : "inline_stats"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thought: Huh, interesting. We also have commands that have proper underscores in them, I wonder if that's an issue with our docs generation.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume not, lookup_join didn't trigger any yet.
astefan
astefan approved these changes Sep 18, 2025
View reviewed changes
Copy link
Contributor

@astefan astefan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@bpintea bpintea added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Sep 18, 2025
@bpintea
Copy link
Contributor Author

bpintea commented Sep 18, 2025

Many thanks for the quick review Alex, Andrei!
@elasticsearchmachine elasticsearchmachine merged commit 1ef55bb into elastic:main Sep 18, 2025
34 checks passed
@bpintea bpintea deleted the enh/rename_inline_stats branch September 18, 2025 15:17
szybia added a commit to szybia/elasticsearch that referenced this pull request Sep 18, 2025
@szybia
Merge remote-tracking branch 'upstream/main' into dlm-tiny-retentions
23d05ac 
* upstream/main: (43 commits) Unmute testAckedIndexing to see if it still fails on main (elastic#134682) Silence time zone ID deprecation warning for JDK 25 due to log4j2 bug. (elastic#134719) Adding a getUnmodifiableSourceAndMetadata() method to IngestDocument (elastic#134816) Mark the create-index-from-source action as publicly available on Serverless (elastic#134953) ESQL: Rename command from INLINESTATS to INLINE STATS (elastic#134827) Document multi index query support for simplified retrievers (elastic#134980) [ML] Fix YAMl test to use correct query parameter type (elastic#134999) [Transform] Wait for PIT to close (elastic#134955) Add XPath to XmlUtils (elastic#134923) Fixing conditional processor mutability bugs (elastic#134936) [Transform] Lower loglevel of 3 transform-related error messages from ERROR to WARN (elastic#134985) Unmute pattern text tests. (elastic#134981) Integrate weights into simplified RRF retriever syntax (elastic#132680) Mute org.elasticsearch.xpack.esql.qa.mixed.MixedClusterEsqlSpecIT test {csv-spec:stats.CountDistinctWithConditions} elastic#134993 Update periodic java-ea build to test java 26 pre-release (elastic#134983) Mute org.elasticsearch.xpack.esql.ccq.MultiClusterSpecIT test {csv-spec:stats.CountDistinctWithConditions} elastic#134984 Fix and unmute testIndexSettingProviderPrivateSetting (elastic#134861) Add missing common cat params (elastic#134870) Support querying multiple indices with the simplified RRF retriever (elastic#134822) Allow including semantic field embeddings in _source (elastic#134717) ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Analytics/ES|QL AKA ESQL auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) ES|QL-ui Impacts ES|QL UI >non-issue Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v9.2.0

4 participants

@bpintea @elasticsearchmachine @astefan @alex-spies