Add file extension metadata to cache miss counter from SharedBlobCacheService #134374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
tteofili added :Search Foundations/Search 
| Hi @tteofili, I've created a changelog YAML for you. |
elasticsearchmachine added the Team:Search Foundations | Pinging @elastic/es-search-foundations (Team:Search Foundations) |
…search into cachemiss_metric_filext
andreidan approved these changes Sep 15, 2025
...ugin/blob-cache/src/main/java/org/elasticsearch/blobcache/shared/SharedBlobCacheService.java Outdated Show resolved Hide resolved
elasticsearchmachine added the serverless-linked andreidan reviewed Sep 15, 2025
Comment on lines +168 to +170
| @Nullable | ||
| public static boolean isLuceneExtension(String ext) { | ||
| return extensions.containsKey(ext); |
There was a problem hiding this comment.
nit: this is not nullable
There was a problem hiding this comment.
if I'm not mistaken, IndexFileNames#getExtension might return null in case the fileName doesn't contain a ., that's why I had put the @Nullable annotation.
There was a problem hiding this comment.
Oh yes. I see what you mean.
We should @Nullable the ext method parameter ++
Being on the method it indicates the method can return null.
andreidan reviewed Sep 15, 2025
...ugin/blob-cache/src/main/java/org/elasticsearch/blobcache/shared/SharedBlobCacheService.java Outdated Show resolved Hide resolved
andreidan reviewed Sep 15, 2025
| return LuceneFilesExtensions.CFS.getExtension(); | ||
| } | ||
| try { | ||
| String extension = IndexFileNames.getExtension(resourceDescription); |
There was a problem hiding this comment.
extension can be null here
There was a problem hiding this comment.
this is considered in the if statement
if (LuceneFilesExtensions.isLuceneExtension(extension)) ...
so a null here will result in other extension.
andreidan reviewed Sep 15, 2025
...ugin/blob-cache/src/main/java/org/elasticsearch/blobcache/shared/SharedBlobCacheService.java Outdated Show resolved Hide resolved
mridula-s109 pushed a commit to mridula-s109/elasticsearch that referenced this pull request Sep 17, 2025
szybia added a commit to szybia/elasticsearch that referenced this pull request Sep 17, 2025
* upstream/main: Add additional logging to make spotting stats issues easier (elastic#133972) [ESQL] Clean up ESQL enrich landing page (elastic#134820) ES|QL: Make kibana docs for Query settings more consistent (elastic#134881) Add file extension metadata to cache miss counter from SharedBlobCacheService (elastic#134374) Add IT for num_reduced_phases with batched query execution (elastic#134312) Remove `SizeValue` (elastic#134871)
gmjehovich pushed a commit to gmjehovich/elasticsearch that referenced this pull request Sep 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This adds file extension metadata to cache miss counter when that's updated by
SharedBlobCacheService.In particular this updates the
es.blob_cache.miss_that_triggered_read.totalcounter with file extensions.At the moment, we don't introspect into compound files, we might do it or not in the future.