Skip to content

ESQL: Add telemetry support for Lookup Join On Expression #134942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 19, 2025
Merged

ESQL: Add telemetry support for Lookup Join On Expression #134942

merged 4 commits into from
Sep 19, 2025

Conversation

julian-elastic
Copy link
Contributor

@julian-elastic julian-elastic commented Sep 17, 2025 •
edited
Loading

  • Add telemetry support for Lookup Join On Expression, adding LOOKUP JOIN ON EXPRESSION label
  • Keep the existing LOOKUP JOIN telemetry label for lookup join on fields to provide BWC
  • Add unit tests for the change
@elasticsearchmachine elasticsearchmachine added needs:triage Requires assignment of a team area label v9.2.0 labels Sep 17, 2025
@julian-elastic julian-elastic added Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >enhancement and removed needs:triage Requires assignment of a team area label labels Sep 17, 2025
@elasticsearchmachine elasticsearchmachine added needs:triage Requires assignment of a team area label and removed Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) labels Sep 17, 2025
@julian-elastic julian-elastic added Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) :Analytics/ES|QL AKA ESQL test-release Trigger CI checks against release build and removed needs:triage Requires assignment of a team area label labels Sep 17, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)
@elasticsearchmachine
Copy link
Collaborator

Hi @julian-elastic, I've created a changelog YAML for you.
luigidellaquila
luigidellaquila approved these changes Sep 18, 2025
View reviewed changes
Copy link
Contributor

@luigidellaquila luigidellaquila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @julian-elastic, the implementation looks correct, so I'm approving this.

My only concern is about BWC: telemetry is exposed with a public API (_xpach/usage), and we are changing the results returned for an existing command.

Also, removing the "lookup join" label and replacing it with "lookup join on fields" will break some dashboards. That could be a minor problem, as we can easily fix them.

I wonder if it makes sense to consider this a breaking change.

An alternative could be to keep the existing "lookup join" label and add "lookup join on expressions". It doesn't seem very future-proof though, as I expect more and more users will use JOINs with expressions, also for a simple JOIN on fields.
@julian-elastic julian-elastic self-assigned this Sep 18, 2025
luigidellaquila
luigidellaquila approved these changes Sep 19, 2025
View reviewed changes
Copy link
Contributor

@luigidellaquila luigidellaquila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!
@julian-elastic julian-elastic merged commit f1ff526 into elastic:main Sep 19, 2025
35 checks passed
@shainaraskas shainaraskas mentioned this pull request Oct 10, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Analytics/ES|QL AKA ESQL >enhancement Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) test-release Trigger CI checks against release build v9.2.0

3 participants

@julian-elastic @elasticsearchmachine @luigidellaquila