Skip to content

Conversation

@cmonfortep
Copy link
Contributor

@cmonfortep cmonfortep commented Oct 29, 2025

Task/Issue URL: https://app.asana.com/1/137249556945/project/72649045549333/task/1211382557175162?focus=true

Description

Steps to test this PR

Use logcat filter tag~:"AttributedMetrics"

➡️ Go to PrivacyFeatureName class and replace url by https://api.jsonblob.com/019a4fb1-89b3-7971-8c77-ab77969a5874

Feature 1

Feature 2

  • Go to AuthRepository method isFreeTrialActive and hardcode false
  • fire button to restart app
  • Ensure Fired pixel user_subscribed with params {month=1}
  • Go to internal Settings and update subscription date to the past >1 month ago
  • fire button to restart app
  • Ensure Fired pixel user_subscribed with params {month=2}

UI changes

Before After
!(Upload before screenshot) (Upload after screenshot)
@cmonfortep cmonfortep force-pushed the feature/cristian/duck_ai_attributed_metric branch from d3ce0d5 to 7a065ec Compare October 29, 2025 21:24
@cmonfortep cmonfortep force-pushed the feature/cristian/subscription_attributed_metric branch from c806241 to ae51b0a Compare October 29, 2025 21:24
@cmonfortep cmonfortep force-pushed the feature/cristian/duck_ai_attributed_metric branch from 7a065ec to b571b15 Compare October 29, 2025 22:32
@cmonfortep cmonfortep force-pushed the feature/cristian/subscription_attributed_metric branch from ae51b0a to 2a80cb9 Compare October 29, 2025 22:32
@cmonfortep cmonfortep force-pushed the feature/cristian/duck_ai_attributed_metric branch from b571b15 to cafc989 Compare October 29, 2025 23:11
@cmonfortep cmonfortep force-pushed the feature/cristian/subscription_attributed_metric branch from 2a80cb9 to 25fae75 Compare October 29, 2025 23:11
@cmonfortep cmonfortep force-pushed the feature/cristian/duck_ai_attributed_metric branch from cafc989 to 4316a72 Compare October 30, 2025 09:01
@cmonfortep cmonfortep force-pushed the feature/cristian/subscription_attributed_metric branch from 25fae75 to e756157 Compare October 30, 2025 09:01
@cmonfortep cmonfortep force-pushed the feature/cristian/duck_ai_attributed_metric branch from 4316a72 to 893affe Compare October 31, 2025 11:56
@cmonfortep cmonfortep force-pushed the feature/cristian/subscription_attributed_metric branch from e756157 to 2d26775 Compare October 31, 2025 11:57
@cmonfortep cmonfortep force-pushed the feature/cristian/duck_ai_attributed_metric branch from 893affe to 5e1bfbd Compare November 4, 2025 12:40
@cmonfortep cmonfortep force-pushed the feature/cristian/subscription_attributed_metric branch from 2d26775 to b3c04fc Compare November 4, 2025 12:40
@cmonfortep cmonfortep marked this pull request as ready for review November 4, 2025 13:47
@cmonfortep cmonfortep force-pushed the feature/cristian/duck_ai_attributed_metric branch from 5e1bfbd to 966feda Compare November 4, 2025 13:48
@cmonfortep cmonfortep force-pushed the feature/cristian/subscription_attributed_metric branch from b3c04fc to ae26108 Compare November 4, 2025 13:48
pixelSender.reportSubscriptionActivated()
emitEntitlementsValues()
_currentPurchaseState.emit(CurrentPurchase.Success)
authRepository.registerLocalPurchasedAt()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lmac012 this is what I asked you last week. A place where to store purchase date. FYI

authRepository.setAccount(null)
authRepository.setSubscription(null)
authRepository.setEntitlements(emptyList())
authRepository.removeLocalPurchasedAt()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lmac012 related to my question last week, this is where I'm removing purchased at date.

Copy link
Contributor

@marcosholgado marcosholgado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left one comment but nothing that needs changing.

}

override suspend fun registerLocalPurchasedAt() {
subscriptionsDataStore.localPurchasedAt = System.currentTimeMillis()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just FYI you are directly storing the system time rather than storing it in ET. Nothing wrong with that but we will have to convert to ET every time we want to compare it.

@marcosholgado marcosholgado self-assigned this Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants