- Notifications
You must be signed in to change notification settings - Fork 1.1k
Adding search related attributed metrics #6899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feature/cristian/attributed_metrics_internal_dev_settings
Are you sure you want to change the base?
Adding search related attributed metrics #6899
Conversation
| Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
831e0ec to c8c63fb Compare 12d236a to 6a65b73 Compare 2106b08 to bedf6b7 Compare 6a65b73 to 6129721 Compare bedf6b7 to 5fd75af Compare 6129721 to 83ab535 Compare 5fd75af to 6a6bd27 Compare 4738c79 to e0ba965 Compare app/src/internal/java/com/duckduckgo/app/statistics/StatisticsInternalInfoView.kt Show resolved Hide resolved
...-impl/src/main/java/com/duckduckgo/app/attributed/metrics/impl/RealAttributedMetricClient.kt Show resolved Hide resolved
542fd17 to ec70268 Compare ...d-metrics-impl/src/main/java/com/duckduckgo/app/attributed/metrics/SearchAttributedMetric.kt Show resolved Hide resolved
...trics-impl/src/main/java/com/duckduckgo/app/attributed/metrics/SearchDaysAttributedMetric.kt Show resolved Hide resolved
...ed-metrics-impl/src/main/java/com/duckduckgo/app/attributed/metrics/store/EventRepository.kt Outdated Show resolved Hide resolved
673c16c to 2f3357b Compare 6a6bd27 to 56ec903 Compare 2f3357b to 28ebece Compare | import dagger.SingleInstanceIn | ||
| import javax.inject.Inject | ||
| | ||
| @ContributesBinding(AppScope::class) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missed this bit on a different PR. "Unrelated"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
78547d9 to 5e2e3da Compare 28ebece to 90dafbc Compare 5e2e3da to b0525e6 Compare 90dafbc to a8eb8a7 Compare b0525e6 to 78c4bd9 Compare a8eb8a7 to efb097e Compare 78c4bd9 to 075c16c Compare efb097e to 287bc5e Compare 
Task/Issue URL: https://app.asana.com/1/137249556945/project/488551667048375/task/1211382557175158?focus=true
and: https://app.asana.com/1/137249556945/project/488551667048375/task/1211382557175159?focus=true
Description
Introduces 2 attributed metrics and their initial implementation.
Steps to test this PR
While testing this PR you need to add the following in your logcat filter:
tag~:"AttributedMetrics"Note: Test cases should be executed in order
Not enough data
Client status running: true -> isActive: true, isEnabled: trueAttributed Metrics Dev Settingsv502-1(and click save)v502-1(and click save)SearchCount7d: Skip emitting, atb not changedSending data
Attributed Metrics Dev Settingsv502-1(and click save)v502-1(and click save)Fired pixel user_average_searches_past_week_first_month with params {count=0}(Note: 0 is the bucket, not value. Notice first_month in pixel name)Fired pixel user_active_past_week with params {days=2}(note: 2 is the bucket, not the value)Trigger only if search atb refreshes
SearchCount7d: Skip emitting, atb not changedddg_search_daysandddg_search)Trigger only if app retention atb refreshes
SearchDays: Skip emitting atb not changed)installation >1mo ago
Attributed Metrics Dev Settingsv402-1(and click save)v402-1(and click save)Fired pixel user_average_searches_past_week with params {count=0}(Note: 0 is the bucket, not value. Notice this is not first_month)Fired pixel user_active_past_week with params {days=2}(note: 2 is the bucket, not the value)Client not active
Client status running: false -> isActive: false, isEnabled: trueDiscard collect event....client not activeUI changes