Add attributed metrics internal dev settings #6901
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
16 tasks
| Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
40 tasks
cmonfortep force-pushed the feature/cristian/attributed_metrics_internal_dev_settings branch 2 times, most recently from bedf6b7 to 5fd75af Compare 
marcosholgado approved these changes Oct 8, 2025
| import java.util.* | ||
| import javax.inject.Inject | ||
| | ||
| @InjectWith(ViewScope::class) |
There was a problem hiding this comment.
I'm gonna guess these 2 files and the layout are here rather than in the attributed internal module because some dependencies are within the app module?
There was a problem hiding this comment.
Correct, there's some stored data that belongs to other modules and our logic depends on those values. So allowing other modules to include internal views here. I was about to create an statistics-internal setting, but some data also belongs to :app module, and it was too much to create several new settings.
cmonfortep force-pushed the feature/cristian/attributed_metrics_module branch from 0602cd7 to 1e2a8db Compare cmonfortep force-pushed the feature/cristian/attributed_metrics_internal_dev_settings branch from 5fd75af to 6a6bd27 Compare cmonfortep force-pushed the feature/cristian/attributed_metrics_module branch from 1e2a8db to 8c38c24 Compare cmonfortep force-pushed the feature/cristian/attributed_metrics_internal_dev_settings branch from 6a6bd27 to 56ec903 Compare This was referenced Oct 17, 2025
cmonfortep force-pushed the feature/cristian/attributed_metrics_module branch from 7bc82de to 9877907 Compare cmonfortep force-pushed the feature/cristian/attributed_metrics_internal_dev_settings branch from 56ec903 to 78547d9 Compare cmonfortep force-pushed the feature/cristian/attributed_metrics_module branch from 9877907 to a93f92a Compare cmonfortep force-pushed the feature/cristian/attributed_metrics_internal_dev_settings branch from 78547d9 to 5e2e3da Compare 38 tasks
cmonfortep force-pushed the feature/cristian/attributed_metrics_module branch from a93f92a to a79e076 Compare cmonfortep force-pushed the feature/cristian/attributed_metrics_internal_dev_settings branch from 5e2e3da to b0525e6 Compare This was referenced Oct 29, 2025
cmonfortep force-pushed the feature/cristian/attributed_metrics_module branch from a79e076 to ec2ac1f Compare cmonfortep force-pushed the feature/cristian/attributed_metrics_internal_dev_settings branch from b0525e6 to 78c4bd9 Compare cmonfortep force-pushed the feature/cristian/attributed_metrics_module branch from ec2ac1f to f4a53c4 Compare cmonfortep force-pushed the feature/cristian/attributed_metrics_internal_dev_settings branch from 78c4bd9 to 075c16c Compare 
cmonfortep force-pushed the feature/cristian/attributed_metrics_module branch from f4a53c4 to 8935fae Compare cmonfortep force-pushed the feature/cristian/attributed_metrics_internal_dev_settings branch from 075c16c to 8342549 Compare Task/Issue URL: https://app.asana.com/1/137249556945/project/488551667048375/task/1211382557175158?focus=true and: https://app.asana.com/1/137249556945/project/488551667048375/task/1211382557175159?focus=true ### Description Introduces 2 attributed metrics and their initial implementation. ### Steps to test this PR While testing this PR you need to add the following in your logcat filter: `tag~:"AttributedMetrics"` Note: Test cases should be executed in order _Not enough data_ - [x] We need fresh install (including removing DDG folder in file system) - [x] Open the app - [x] wait until "skip onboarding" appears - [x] After downloading privacy config and atb init, you should see `Client status running: true -> isActive: true, isEnabled: true` - [x] Skip onboarding, and go to the browser - [x] Go to settings -> `Attributed Metrics Dev Settings` - [x] Update app retention atb with `v502-1` (and click save) - [x] Update search atb with `v502-1` (and click save) - [x] Update installation date with 10-8d ago (and click save) - [x] Go back to the browser - [x] Perform a search - [x] No pixels are emitted, `SearchCount7d: Skip emitting, atb not changed` _Sending data_ - [x] Go to settings -> `Attributed Metrics Dev Settings` - [x] Click on "Add Search Events" - [x] Update app retention atb with `v502-1` (and click save) - [x] Update search atb with `v502-1` (and click save) - [x] Go back to the browser - [x] Perform a NEW search - [x] Ensure you see `Fired pixel user_average_searches_past_week_first_month with params {count=0}` (Note: 0 is the bucket, not value. Notice first_month in pixel name) - [x] Close the app, open it again (or fire button) - [x] Ensure you see `Fired pixel user_active_past_week with params {days=2}`(note: 2 is the bucket, not the value) _Trigger only if search atb refreshes_ - [x] Perform a new search - [x] No pixels are emitted, `SearchCount7d: Skip emitting, atb not changed` - [x] You should see 2 collected events (both `ddg_search_days` and `ddg_search`) _Trigger only if app retention atb refreshes_ - [x] Close app, open it again (or fire button) - [x] No pixel emitted, `SearchDays: Skip emitting atb not changed`) _installation >1mo ago_ - [ ] Go to settings -> `Attributed Metrics Dev Settings` - [x] Update app retention atb with `v402-1` (and click save) - [x] Update search atb with `v402-1` (and click save) - [x] Update installation date with some day in August (and click save) - [x] Perform a new search - [x] Ensure you see `Fired pixel user_average_searches_past_week with params {count=0}` (Note: 0 is the bucket, not value. Notice this is not first_month) - [x] Close app, open it again (or fire button) - [x] Ensure you see `Fired pixel user_active_past_week with params {days=2}`(note: 2 is the bucket, not the value) _Client not active_ - [x] Clear storage - [x] Open the app - [x] After downloading privacy config and atb init, you should see `Client status running: false -> isActive: false, isEnabled: true` - [x] Skip onboarding, and go to the browser - [x] Perform a search - [x] Ensure nothing collected `Discard collect event....client not active` ### UI changes | Before | After | | ------ | ----- | !(Upload before screenshot)|(Upload after screenshot)|
cmonfortep merged commit 75480f7 into feature/cristian/attributed_metrics_module 5 of 6 checks passed
cmonfortep deleted the feature/cristian/attributed_metrics_internal_dev_settings branch Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/488551667048375/task/1211578504512146?focus=true
Description
Includes a dev setting screen for testing purposes. It will allow you to:
Steps to test this PR
Feature 1
UI changes