Added Manifest file for AWS SDK Bundle #120
Conversation
| region: us-east-1 | ||
| credentials: | ||
| key: not-a-real-key | ||
| secret: "@@not-a-real-secret" |
There was a problem hiding this comment.
key and secret should probably be env vars instead.
There was a problem hiding this comment.
Really helpful. Thanks
| @@ -0,0 +1,10 @@ | |||
| # Basic configuration for AWS SDK | |||
| # Please visit http://docs.aws.amazon.com/aws-sdk-php/v3/guide/guide/configuration.html | |||
| # for more information | |||
There was a problem hiding this comment.
For the comment, can you get some inspiration from existing comments in for other packages (just that they are all consistent?).
There was a problem hiding this comment.
Thanks you. I think I should simply remove it, like the other packages for consistent.
| Thanks @fabpot for your comments. I fixed all of them like your suggestions, but still waiting for approval from the gents at AWS. We could come back to this PR later. |
| "config/": "%CONFIG_DIR%/" | ||
| }, | ||
| "env": { | ||
| "AWS_CREDENTIAL_KEY": "not-a-real-key", |
There was a problem hiding this comment.
Could we use just AWS_KEY and AWS_SECRET or are those names recommended by AWS? Shorter is better IMHO.
| Blocked by aws/aws-sdk-php-symfony#30 |
| Hi @fabpot and team. Please re-execute the checking, thanks so much |
| @symfony-flex-server review please |
| @symfony-flex-server review please |
ghost deployed to 2 participants
Manifest for AWS SDK. This one closes for an issue: symfony/flex#193