Skip to content

Conversation

trandangtri
Copy link
Contributor

Dear guys,

From Symfony version 3.3 there is new way of building Symfony apps, that's Symfony Flex. It requires the type of package should be "symfony-bundle", but "library".

For your information, I created a receipt to work with your bundle at:
symfony/recipes-contrib#120

The conversation here:
symfony/flex#193

Please help me review this PR.

Regards.

@fabpot
Copy link

fabpot commented Oct 30, 2017

👍

@christophe-mailfert
Copy link

👍

@trandangtri
Copy link
Contributor Author

CC @jeskew

@jeskew
Copy link
Contributor

jeskew commented Nov 2, 2017

Hi @trandangtri,

Is there any way to test this to make sure it's working correctly? The tests/fixtures folder contains a full Symfony application that uses the AWS SDK for PHP bundle if that's necessary.

@trandangtri
Copy link
Contributor Author

Hi @jeskew

Thanks for your feedback. Basically we used this declaration to define this package will tie to a specified framework/platform, in this case it's Symfony.
https://getcomposer.org/doc/04-schema.md#type

I'm not sure 100% there are anyway to make a test. But this declaration was confirmed by founder of Symfony (CC @fabpot) in our conversation which related to Symfony Flex. You could take a look at the conversation for more information.

Regards.

@fabpot
Copy link

fabpot commented Nov 3, 2017

Indeed, there is no way to "test" this.

@christophe-mailfert
Copy link

any news ?

@jeskew jeskew merged commit e11e987 into aws:master Nov 10, 2017
@trandangtri trandangtri deleted the flex branch December 19, 2017 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants