Skip to content

[WIP] Added Manifest for TriTranSqsQueueBundle #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[WIP] Added Manifest for TriTranSqsQueueBundle #130

wants to merge 1 commit into from

Conversation

trandangtri
Copy link
Contributor

Q A
License MIT

This bundle provides an easy way to work with AWS SQS.

https://github.com/trandangtri/sqs-queue-bundle
ghost
ghost approved these changes Nov 2, 2017
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.
@trandangtri
Copy link
Contributor Author

Blocked by #120
Nyholm
Nyholm reviewed Dec 17, 2017
View reviewed changes
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

I just have a minor question.
tritran/sqs-queue-bundle/2.0/config/packages/sqs_queue.yaml
@@ -0,0 +1,3 @@
tritran_sqs_queue:
sqs_queue:
queues: ~
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would happen if this config was removed?
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, It's just a sample structure of configuration. Basically, there are not any error which belongs to.
BTW, this PR is still WIP, sorry about that. I need to update something else. Thanks
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okey. So if I understand you correctly, you could remove this line and still get the same results?

If so, (Looking at the current state of the PR) I would suggest closing this PR because Flex is smart enough to install this bundle without a recipe.

However, I would love if you added some good default config that will make sense for 90% of the users. If so, I'll be happy to merge this PR.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your comments. Seems I should close this PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@trandangtri @Nyholm