v20.4.0 proposal #48643

RafaelGSS · 2023-07-03T14:00:29Z

2023-07-05, Version 20.4.0 (Current), @RafaelGSS

Notable Changes

Mock Timers

The new feature allows developers to write more reliable and predictable tests for time-dependent functionality.
It includes MockTimers with the ability to mock setTimeout, setInterval from globals, node:timers, and node:timers/promises.

The feature provides a simple API to advance time, enable specific timers, and release all timers.

import assert from 'node:assert'; import { test } from 'node:test'; test('mocks setTimeout to be executed synchronously without having to actually wait for it', (context) => { const fn = context.mock.fn(); // Optionally choose what to mock context.mock.timers.enable(['setTimeout']); const nineSecs = 9000; setTimeout(fn, nineSecs); const threeSeconds = 3000; context.mock.timers.tick(threeSeconds); context.mock.timers.tick(threeSeconds); context.mock.timers.tick(threeSeconds); assert.strictEqual(fn.mock.callCount(), 1); });

This feature was contributed by Erick Wendel in #47775.

Support to the explicit resource management proposal

Node is adding support to the explicit resource management
proposal to its resources allowing users of TypeScript/babel to use using/await using with
V8 support for everyone else on the way.

This feature was contributed by Moshe Atlow and Benjamin Gruenbaum in #48518.

Other notable changes

[fe333d2584] - crypto: update root certificates to NSS 3.90 (Node.js GitHub Bot) #48416
[60c2ea4e79] - doc: add vmoroz to collaborators (Vladimir Morozov) #48527
[5cacdf9e6b] - doc: add kvakil to collaborators (Keyhan Vakil) #48449
[504d1d7bdc] - (SEMVER-MINOR) tls: add ALPNCallback server option for dynamic ALPN negotiation (Tim Perry) #45190

Commits

[8a611a387f] - benchmark: add bar.R (Rafael Gonzaga) #47729
[12fa716cf9] - benchmark: refactor crypto oneshot (Filip Skokan) #48267
[d6ecbde592] - benchmark: add crypto.create*Key (Filip Skokan) #48284
[e60b6dedd8] - bootstrap: unify snapshot builder and embedder entry points (Joyee Cheung) #48242
[40662957b1] - bootstrap: simplify initialization of source map handlers (Joyee Cheung) #48304
[6551538079] - build: fix configure --link-module (Richard Lau) #48522
[f7f32089e7] - build: sync libuv header change (Jiawen Geng) #48429
[f60205c915] - build: update action to close stale PRs (Michael Dawson) #48196
[4f4d0b802e] - child_process: improve spawn performance on Linux (Keyhan Vakil) #48523
[fe333d2584] - crypto: update root certificates to NSS 3.90 (Node.js GitHub Bot) #48416
[89aaf16237] - crypto: remove OPENSSL_FIPS guard for OpenSSL 3 (Richard Lau) #48392
[6199e1946c] - deps: upgrade to libuv 1.46.0 (Santiago Gimeno) #48618
[1b2b930fda] - deps: add loong64 config into openssl gypi (Shi Pujin) #48043
[ba8d048929] - deps: update acorn to 8.9.0 (Node.js GitHub Bot) #48484
[d96f921d06] - deps: update zlib to 1.2.13.1-motley-f81f385 (Node.js GitHub Bot) #48541
[ed1d047e8f] - deps: update googletest to ec4fed9 (Node.js GitHub Bot) #48538
[f43d718c67] - deps: update minimatch to 9.0.2 (Node.js GitHub Bot) #48542
[2f66147cbf] - deps: update corepack to 0.19.0 (Node.js GitHub Bot) #48540
[d91b0fde73] - deps: V8: cherry-pick 1a782f6543ae (Keyhan Vakil) #48523
[112335e342] - deps: update corepack to 0.18.1 (Node.js GitHub Bot) #48483
[2b141c413f] - deps: update icu to 73.2 (Node.js GitHub Bot) #48502
[188b34d4a1] - deps: upgrade npm to 9.7.2 (npm team) #48514
[bf0444b5d9] - deps: update zlib to 1.2.13.1-motley-3ca9f16 (Node.js GitHub Bot) #48413
[b339d80a56] - deps: upgrade npm to 9.7.1 (npm team) #48378
[4132931b87] - deps: update simdutf to 3.2.14 (Node.js GitHub Bot) #48344
[8cd56c1e85] - deps: update ada to 2.5.1 (Node.js GitHub Bot) #48319
[78cffcd645] - deps: update zlib to 982b036 (Node.js GitHub Bot) #48327
[6d00c2e33b] - doc: fix options order (Luigi Pinca) #48617
[7ad2d3a5d1] - doc: update security release stewards (Rafael Gonzaga) #48569
[cc3a056fdd] - doc: update return type for describe (Shrujal Shah) #48572
[99ae0b98af] - doc: run license-builder (github-actions[bot]) #48552
[9750d8205c] - doc: add description of autoAllocateChunkSize in ReadableStream (Debadree Chatterjee) #48004
[417927bb41] - doc: fix filename type in watch result (Dmitry Semigradsky) #48032
[ca2ae86bd7] - doc: unnest mime and MIMEParams from MIMEType constructor (Dmitry Semigradsky) #47950
[bda1228135] - doc: update security-release-process.md (Rafael Gonzaga) #48504
[60c2ea4e79] - doc: add vmoroz to collaborators (Vladimir Morozov) #48527
[37bc0eac4a] - doc: improve inspector.close() description (mary marchini) #48494
[2a403cdad5] - doc: link to Runtime Keys in export conditions (Jacob Hummer) #48408
[e2d579e644] - doc: update fs flags documentation (sinkhaha) #48463
[38bf290115] - doc: revise error.md introduction (Antoine du Hamel) #48423
[641a2e9c6d] - doc: add preveen-stack to triagers (Preveen P) #48387
[4ab5e8d2e3] - doc: refine when file is undefined in test events (Moshe Atlow) #48451
[5cacdf9e6b] - doc: add kvakil to collaborators (Keyhan Vakil) #48449
[b9c643e3ef] - doc: add additional info on TSFN dispatch (Michael Dawson) #48367
[17a0e1d1bf] - doc: add link for news from security wg (Michael Dawson) #48396
[3a62994a4f] - doc: fix typo in events.md (Darshan Sen) #48436
[e10a4cdf68] - doc: run license-builder (github-actions[bot]) #48336
[19fde638fd] - fs: call the callback with an error if writeSync fails (killa) #47949
[4cad9fd8bd] - fs: remove unneeded return statement (Luigi Pinca) #48526
[d367b73f43] - fs: use kResistStopPropagation (Chemi Atlow) #48521
[e50c3169af] - fs, stream: initial Symbol.dispose and Symbol.asyncDispose support (Moshe Atlow) #48518
[7d8a0b6eb7] - http: null the joinDuplicateHeaders property on cleanup (Luigi Pinca) #48608
[94ebb02f59] - http: server add async dispose (atlowChemi) #48548
[c6a69e31a3] - http: remove useless ternary in test (geekreal) #48481
[2f0f40328f] - http: fix for handling on boot timers headers and request (Franciszek Koltuniuk) #48291
[5378ad8ab1] - http2: server add asyncDispose (atlowChemi) #48548
[97a58c5970] - https: server add asyncDispose (atlowChemi) #48548
[40ae6eb6aa] - https: fix connection checking interval not clearing on server close (Nitzan Uziely) #48383
[15530fea4c] - lib: merge cjs and esm package json reader caches (Yagiz Nizipli) #48477
[32bda81c31] - lib: reduce url getters on makeRequireFunction (Yagiz Nizipli) #48492
[0da03f01ba] - lib: remove duplicated requires in check_syntax (Yagiz Nizipli) #48508
[97b00c347d] - lib: add option to force handling stopped events (Chemi Atlow) #48301
[fe16749649] - lib: fix output message when repl is used with pm (Rafael Gonzaga) #48438
[8c2c02d28a] - lib: create weakRef only if any signals provided (Chemi Atlow) #48448
[b6ae411ea9] - lib: remove obsolete deletion of bufferBinding.zeroFill (Chengzhong Wu) #47881
[562b3d4856] - lib: move web global bootstrapping to the expected file (Chengzhong Wu) #47881
[f9c0d5acac] - lib: fix blob.stream() causing hanging promises (Debadree Chatterjee) #48232
[0162a0f5bf] - lib: add support for inherited custom inspection methods (Antoine du Hamel) #48306
[159ab6627a] - lib: reduce URL invocations on http2 origins (Yagiz Nizipli) #48338
[f0709fdc59] - module: add SourceMap.findOrigin (Isaac Z. Schlueter) #47790
[4ec2d925b1] - module: reduce url invocations in esm/load.js (Yagiz Nizipli) #48337
[2c363971cc] - net: improve network family autoselection handle handling (Paolo Insogna) #48464
[dbf9e9ffc8] - node-api: provide napi_define_properties fast path (Gabriel Schulhof) #48440
[87ad657777] - node-api: implement external strings (Gabriel Schulhof) #48339
[4efa6807ea] - permission: handle end nodes with children cases (Rafael Gonzaga) #48531
[84fe811108] - repl: display dynamic import variant in static import error messages (Hemanth HM) #48129
[bdcc037470] - report: disable js stack when no context is entered (Chengzhong Wu) #48495
[97bd9ccd04] - src: fix uninitialized field access in AsyncHooks (Jan Olaf Krems) #48566
[404958fc96] - src: fix Coverity issue regarding unnecessary copy (Yagiz Nizipli) #48565
[c4b8edea24] - src: refactor SplitString in util (Yagiz Nizipli) #48491
[5bc13a4772] - src: revert IS_RELEASE (Rafael Gonzaga) #48505
[4971e46051] - src: add V8 fast api to guessHandleType (Yagiz Nizipli) #48349
[954e46e792] - src: return uint32 for guessHandleType (Yagiz Nizipli) #48349
[05009675da] - src: make realm binding data store weak (Chengzhong Wu) #47688
[120ac74352] - src: remove aliased buffer weak callback (Chengzhong Wu) #47688
[6591826e99] - src: handle wasm out of bound in osx will raise SIGBUS correctly (Congcong Cai) #46561
[1b84ddeec2] - src: implement constants binding directly (Joyee Cheung) #48186
[06d49c1f10] - src: implement natives binding without special casing (Joyee Cheung) #48186
[325441abf5] - src: add missing to_ascii method in dns queries (Daniel Lemire) #48354
[84d0eb74b8] - stream: fix premature pipeline end (Robert Nagy) #48435
[3df7368735] - test: add missing assertions to test-runner-cli (Moshe Atlow) #48593
[07eb310b0d] - test: remove test-crypto-keygen flaky designation (Luigi Pinca) #48575
[75aa0a7682] - test: remove test-timers-immediate-queue flaky designation (Luigi Pinca) #48575
[a9756f3126] - test: add Symbol.dispose support to mock timers (Benjamin Gruenbaum) #48549
[0f912a7248] - test: mark test-child-process-stdio-reuse-readable-stdio flaky (Luigi Pinca) #48537
[30f4bc4985] - test: make IsolateData per-isolate in cctest (Joyee Cheung) #48450
[407ce3fdcb] - test: define NAPI_VERSION before including node_api.h (Chengzhong Wu) #48376
[24a8fa95f0] - test: remove unnecessary noop function args to mustNotCall() (Antoine du Hamel) #48513
[09af579775] - test: skip test-runner-watch-mode on IBMi (Moshe Atlow) #48473
[77cb1ee0b2] - test: add missing <algorithm> include for std::find (Sam James) #48380
[7c790ca03c] - test: fix flaky test-watch-mode (Moshe Atlow) #48147
[1398829746] - test: fix test-net-autoselectfamily for kernel without IPv6 support (Livia Medeiros) #48265
[764119ba4b] - test: update url web-platform tests (Yagiz Nizipli) #48319
[f1ead59629] - test: ignore the copied entry_point.c (Luigi Pinca) #48297
[fc5d1bddcb] - test: refactor test-gc-http-client-timeout (Luigi Pinca) #48292
[46a3d068a0] - test: update encoding web-platform tests (Yagiz Nizipli) #48320
[141e5aad83] - test: update FileAPI web-platform tests (Yagiz Nizipli) #48322
[83cfc67099] - test: update user-timing web-platform tests (Yagiz Nizipli) #48321
[2c56835a33] - test_runner: fixed test shorthands return type (Shocker) #48555
[7d01c8894a] - (SEMVER-MINOR) test_runner: add initial draft for fakeTimers (Erick Wendel) #47775
[de4f14c249] - test_runner: add enqueue and dequeue events (Moshe Atlow) #48428
[5ebe3a4ea7] - test_runner: make --test-name-pattern recursive (Moshe Atlow) #48382
[93bf447308] - test_runner: refactor coverage report output for readability (Damien Seguin) #47791
[504d1d7bdc] - (SEMVER-MINOR) tls: add ALPNCallback server option for dynamic ALPN negotiation (Tim Perry) #45190
[203c3cf4ca] - tools: update lint-md-dependencies (Node.js GitHub Bot) #48544
[333907b19d] - tools: speedup compilation of js2c output (Keyhan Vakil) #48160
[10bd5f4d97] - tools: update lint-md-dependencies (Node.js GitHub Bot) #48486
[52de27b9fe] - tools: pin ruff version number (Rich Trott) #48505
[4345526644] - tools: replace sed with perl (Luigi Pinca) #48499
[6c590835f3] - tools: automate update openssl v16 (Marco Ippolito) #48377
[90b5335338] - tools: update eslint to 8.43.0 (Node.js GitHub Bot) #48487
[cd83530a11] - tools: update doc to to-vfile@8.0.0 (Node.js GitHub Bot) #48485
[e500b439bd] - tools: prepare tools/doc for to-vfile 8.0.0 (Rich Trott) #48485
[d623616813] - tools: update lint-md-dependencies (Node.js GitHub Bot) #48417
[a2e107dde4] - tools: update create-or-update-pull-request-action (Richard Lau) #48398
[8009e2c3be] - tools: update eslint-plugin-jsdoc (Richard Lau) #48393
[10385c8565] - tools: add version update to external dependencies (Andrea Fassina) #48081
[b1cef81b18] - tools: update eslint to 8.42.0 (Node.js GitHub Bot) #48328
[0923dc0b8e] - tools: disable jsdoc/no-defaults rule (Luigi Pinca) #48328
[b03146da85] - typings: remove unused primordials (Yagiz Nizipli) #48509
[e9c9d187b9] - typings: fix JSDoc in ESM loader modules (Antoine du Hamel) #48424
[fafe651d23] - url: conform to origin getter spec changes (Yagiz Nizipli) #48319

PR-URL: #48284 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

PR-URL: #48321 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>

My original plan of adding a lable to limit those initially process as outlined in #48051 does not work I think because adding a lable updates the last update time. - Removing the need for the lable - Remove the cron scheduling so that it only runs when I run it manually - Fix the display name for the action as I missed updating that after cut and paste from existing action The plan will be to find stop dates that should only affect a reasonable number of PRs at a time and then run in batches using that instead. Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #48196 Reviewed-By: Mestery <mestery@protonmail.com>

PR-URL: #48267 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

PR-URL: #48322 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

PR-URL: #48320 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

PR-URL: #48328 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>

Refs: nodejs/security-wg#973 Most of the duplicated code in all the dependencies updaters has been moved in the `utils.sh` file PR-URL: #48081 Refs: nodejs/security-wg#973 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>

Due to server response delay, all possible requests are created anyway. Instead of doing `36 * os.availableParallelism()` requests, use a fixed number. Refs: #48078 (comment) PR-URL: #48292 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>

Add `test_cannot_run_js/entry_point.c` to `test/js-native-api/.gitignore`. PR-URL: #48297 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Gabriel Schulhof <gabrielschulhof@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: James M Snell <jasnell@gmail.com>

PR-URL: #48327 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>

PR-URL: #48336 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

PR-URL: #48337 Refs: nodejs/performance#92 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me>

PR-URL: #48338 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>

Add a "table" parameter to getCoverageReport. Keep the tap coverage output intact. Change the output by adding padding and truncating the tables' cells. Add separation lines for table head/body/foot. Group uncovered lines as ranges. Add yellow color for coverage between 50 and 90. Refs: #46674 PR-URL: #47791 Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

PR-URL: #48319 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

PR-URL: #48344 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>

PR-URL: #48265 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

PR-URL: #48354 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it>

PR-URL: #48147 Fixes: #44898 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

PR-URL: #48378 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Luke Karrys <luke@lukekarrys.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>

Run a subset of `tools/dep_updaters/update-eslint.sh` to update `eslint-plugin-jsdoc` to get rid of a spurious ENOENT error when running the linter. PR-URL: #48393 Fixes: #48374 Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

Use the same commit SHA for this action as used in our other workflows. Refs: #46169 Refs: #45022 (comment) PR-URL: #48398 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>

This patch removes special case in the internal binding loader for natives, and implements it using the builtins internal binding. Internally we do not actually need the natives binding, so implement it as a legacy wrapper instead. PR-URL: #48186 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

Instead of adding a special case for it in the internal binding loader, just implement it as usual using a per-context property initializer. PR-URL: #48186 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

- Move the initialization of process.setSourceMapsEnabled and the maybeCacheGeneratedSourceMap callback to bootstrap/node.js so they are included in the snapshot. - Simplify the handling of --enable-source-maps by explicitly calling setSourceMapsEnabled() during pre-execution. PR-URL: #48304 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

GCC 14 drops some transitive includes within libstdc++. Explicitly include <algorithm> for std::find. Signed-off-by: Sam James <sam@gentoo.org> PR-URL: #48380 Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>

Notable changes: crypto: * update root certificates to NSS 3.90 (Node.js GitHub Bot) nodejs#48416 doc: * add vmoroz to collaborators (Vladimir Morozov) nodejs#48527 * add kvakil to collaborators (Keyhan Vakil) nodejs#48449 fs, stream: * initial `Symbol.dispose` and `Symbol.asyncDispose` support (Moshe Atlow) nodejs#48518 test_runner: * (SEMVER-MINOR) add initial draft for fakeTimers (Erick Wendel) nodejs#47775 tls: * (SEMVER-MINOR) add ALPNCallback server option for dynamic ALPN negotiation (Tim Perry) nodejs#45190 PR-URL: nodejs#48643

Notable changes: crypto: * update root certificates to NSS 3.90 (Node.js GitHub Bot) #48416 doc: * add vmoroz to collaborators (Vladimir Morozov) #48527 * add kvakil to collaborators (Keyhan Vakil) #48449 fs, stream: * initial `Symbol.dispose` and `Symbol.asyncDispose` support (Moshe Atlow) #48518 test_runner: * (SEMVER-MINOR) add initial draft for fakeTimers (Erick Wendel) #47775 tls: * (SEMVER-MINOR) add ALPNCallback server option for dynamic ALPN negotiation (Tim Perry) #45190 PR-URL: #48643

nodejs-github-bot · 2023-07-03T20:14:40Z

CI: https://ci.nodejs.org/job/node-test-pull-request/52587/ ✔️
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/5426/ -> https://ci.nodejs.org/job/node-test-commit-v8-linux/5428/ ✔️
CITGM: https://ci.nodejs.org/job/citgm-smoker/3176/ -> https://ci.nodejs.org/job/citgm-smoker/3178/ ✔️
CITGM(v20.3.1): https://ci.nodejs.org/job/citgm-smoker/3174/ ✔️
CITGM(v20.x): https://ci.nodejs.org/job/citgm-smoker/3180/
📦 https://ci-release.nodejs.org/job/iojs+release/9474/ -> https://ci-release.nodejs.org/job/iojs+release/9475/ ✔️

mcollina · 2023-07-04T08:18:58Z

It would be great if #48611 could be included

RafaelGSS · 2023-07-04T19:05:56Z

Apparently, fastify and npm are affected by this release:

FAILURE: 41 failures in 3178 not present in 3174 ┌────────────────────────┬───────────────────────┬───────────────────────┬───────────────────┬──────────────────────┬───────────────────┬────────────────────┬─────────────────┬─────────────────┬──────────────┬───────────────┐ │ (index) │ 0 │ 1 │ 2 │ 3 │ 4 │ 5 │ 6 │ 7 │ 8 │ 9 │ ├────────────────────────┼───────────────────────┼───────────────────────┼───────────────────┼──────────────────────┼───────────────────┼────────────────────┼─────────────────┼─────────────────┼──────────────┼───────────────┤ │ aix72-ppc64 │ 'fastify-v4.19.2' │ 'tough-cookie-v4.1.3' │ │ │ │ │ │ │ │ │ │ fedora-last-latest-x64 │ 'npm-v9.7.2' │ 'undici-v5.22.1' │ │ │ │ │ │ │ │ │ │ ubuntu1804-64 │ 'npm-v9.7.2' │ 'pino-v8.14.1' │ 'pump-v3.0.0' │ 'serialport-v11.0.0' │ 'undici-v5.22.1' │ │ │ │ │ │ │ osx1015 │ 'async-v3.2.4' │ 'ava-v5.3.1' │ 'express-v4.18.2' │ 'clinic-v13.0.0' │ 'fastify-v4.19.2' │ 'ember-cli-v5.0.0' │ 'router-v1.3.8' │ 'rimraf-v5.0.1' │ 'npm-v9.7.2' │ 'uuid-v9.0.0' │ │ rhel8-ppc64le │ 'async-v3.2.4' │ 'bcrypt-v5.1.0' │ 'fastify-v4.19.2' │ 'npm-v9.7.2' │ 'semver-v7.5.3' │ 'tape-v5.6.4' │ │ │ │ │ │ rhel8-x64 │ 'npm-v9.7.2' │ │ │ │ │ │ │ │ │ │ │ fedora-latest-x64 │ 'bcrypt-v5.1.0' │ 'ava-v5.3.1' │ 'npm-v9.7.2' │ 'undici-v5.22.1' │ 'winston-v3.9.0' │ │ │ │ │ │ │ win-vs2019 │ 'body-parser-v1.20.2' │ 'commander-v11.0.0' │ 'npm-v9.7.2' │ 'tape-v5.6.4' │ │ │ │ │ │ │ │ rhel8-s390x │ 'fastify-v4.19.2' │ 'spawn-wrap-v2.0.0' │ 'sqlite3-v5.1.6' │ │ │ │ │ │ │ │ │ debian10-x64 │ 'fastify-v4.19.2' │ 'npm-v9.7.2' │ 'undici-v5.22.1' │ │ │ │ │ │ │ │ └────────────────────────┴───────────────────────┴───────────────────────┴───────────────────┴──────────────────────┴───────────────────┴────────────────────┴─────────────────┴─────────────────┴──────────────┴───────────────┘ ``` fastify: ``` not ok 1 - Extension "ip" value is not a valid IPv4 or IPv6 address. ```

RafaelGSS · 2023-07-04T19:17:34Z

@nodejs/npm could you help with https://ci.nodejs.org/job/citgm-smoker/3178/nodes=debian10-x64/testReport/junit/(root)/citgm/npm_v9_7_2/?

RafaelGSS · 2023-07-04T19:31:22Z

I couldn't reproduce the fastify issues locally (Debian x64). I'm running the CITGM on v20.x again to guarantee this test isn't failing on v20.x.

RafaelGSS · 2023-07-04T19:42:30Z

The npm issue is related to nodejs/citgm#897.

RafaelGSS · 2023-07-04T19:53:04Z

I couldn't reproduce the fastify failures on osx either. I will wait for citgm on v20.x to check if it's an environment issue, if so, I'll proceed with the release.

RafaelGSS · 2023-07-04T22:13:26Z

FYI citgm isn't finished yet. I'll postpone the release to tomorrow.

Notable changes: crypto: * update root certificates to NSS 3.90 (Node.js GitHub Bot) #48416 doc: * add vmoroz to collaborators (Vladimir Morozov) #48527 * add kvakil to collaborators (Keyhan Vakil) #48449 fs, stream: * initial `Symbol.dispose` and `Symbol.asyncDispose` support (Moshe Atlow) #48518 test_runner: * (SEMVER-MINOR) add initial draft for fakeTimers (Erick Wendel) #47775 tls: * (SEMVER-MINOR) add ALPNCallback server option for dynamic ALPN negotiation (Tim Perry) #45190 PR-URL: #48643

RafaelGSS · 2023-07-04T22:20:34Z

New 📦 https://ci-release.nodejs.org/job/iojs+release/9476/

RafaelGSS · 2023-07-05T01:22:09Z

CITGM looks fine:

FAILURE: 22 failures in 3178 not present in 3180 ┌────────────────────────┬─────────────────────┬─────────────────────────┬───────────────────────┬───────────────────┬──────────────────┐ │ (index) │ 0 │ 1 │ 2 │ 3 │ 4 │ ├────────────────────────┼─────────────────────┼─────────────────────────┼───────────────────────┼───────────────────┼──────────────────┤ │ aix72-ppc64 │ │ │ │ │ │ │ fedora-last-latest-x64 │ 'jest-v29.5.0' │ 'undici-v5.22.1' │ │ │ │ │ ubuntu1804-64 │ 'pino-v8.14.1' │ 'pump-v3.0.0' │ 'jest-v29.5.0' │ 'undici-v5.22.1' │ │ │ osx1015 │ 'undici-v5.22.1' │ │ │ │ │ │ rhel8-ppc64le │ 'async-v3.2.4' │ 'bcrypt-v5.1.0' │ 'multer-v1.4.5-lts.1' │ 'node-gyp-v9.4.0' │ 'undici-v5.22.1' │ │ rhel8-x64 │ 'jest-v29.5.0' │ │ │ │ │ │ fedora-latest-x64 │ │ │ │ │ │ │ win-vs2019 │ 'commander-v11.0.0' │ 'torrent-stream-v1.2.1' │ │ │ │ │ rhel8-s390x │ 'acorn-v8.9.0' │ 'spawn-wrap-v2.0.0' │ 'undici-v5.22.1' │ 'sqlite3-v5.1.6' │ │ │ debian10-x64 │ 'bcrypt-v5.1.0' │ 'jest-v29.5.0' │ 'undici-v5.22.1' │ │ │ └────────────────────────┴─────────────────────┴─────────────────────────┴───────────────────────┴───────────────────┴──────────────────┘

PR-URL: #48643

Notable changes: crypto: * update root certificates to NSS 3.90 (Node.js GitHub Bot) #48416 doc: * add vmoroz to collaborators (Vladimir Morozov) #48527 * add kvakil to collaborators (Keyhan Vakil) #48449 fs, stream: * initial `Symbol.dispose` and `Symbol.asyncDispose` support (Moshe Atlow) #48518 test_runner: * (SEMVER-MINOR) add initial draft for fakeTimers (Erick Wendel) #47775 tls: * (SEMVER-MINOR) add ALPNCallback server option for dynamic ALPN negotiation (Tim Perry) #45190 PR-URL: #48643

Refs: nodejs/node#48643

Refs: nodejs/node#48643 Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>

Notable changes: crypto: * update root certificates to NSS 3.90 (Node.js GitHub Bot) nodejs#48416 doc: * add vmoroz to collaborators (Vladimir Morozov) nodejs#48527 * add kvakil to collaborators (Keyhan Vakil) nodejs#48449 fs, stream: * initial `Symbol.dispose` and `Symbol.asyncDispose` support (Moshe Atlow) nodejs#48518 test_runner: * (SEMVER-MINOR) add initial draft for fakeTimers (Erick Wendel) nodejs#47775 tls: * (SEMVER-MINOR) add ALPNCallback server option for dynamic ALPN negotiation (Tim Perry) nodejs#45190 PR-URL: nodejs#48643

panva and others added 30 commits July 3, 2023 10:32

test: update user-timing web-platform tests

83cfc67

PR-URL: #48321 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>

benchmark: refactor crypto oneshot

12fa716

PR-URL: #48267 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

test: update FileAPI web-platform tests

141e5aa

PR-URL: #48322 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

test: update encoding web-platform tests

46a3d06

PR-URL: #48320 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

tools: disable jsdoc/no-defaults rule

0923dc0

PR-URL: #48328 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>

tools: update eslint to 8.42.0

b1cef81

PR-URL: #48328 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>

tools: add version update to external dependencies

10385c8

Refs: nodejs/security-wg#973 Most of the duplicated code in all the dependencies updaters has been moved in the `utils.sh` file PR-URL: #48081 Refs: nodejs/security-wg#973 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>

deps: update zlib to 982b036

78cffcd

PR-URL: #48327 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>

doc: run license-builder

e10a4cd

PR-URL: #48336 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

lib: reduce URL invocations on http2 origins

159ab66

PR-URL: #48338 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>

deps: update ada to 2.5.1

8cd56c1

PR-URL: #48319 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

test: update url web-platform tests

764119b

PR-URL: #48319 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

url: conform to origin getter spec changes

fafe651

PR-URL: #48319 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

test: fix test-net-autoselectfamily for kernel without IPv6 support

1398829

PR-URL: #48265 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

src: add missing to_ascii method in dns queries

325441a

PR-URL: #48354 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it>

test: fix flaky test-watch-mode

7c790ca

PR-URL: #48147 Fixes: #44898 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

deps: upgrade npm to 9.7.1

b339d80

PR-URL: #48378 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Luke Karrys <luke@lukekarrys.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>

RafaelGSS force-pushed the v20.4.0-proposal branch from e4e9f09 to 51174cd Compare July 3, 2023 14:20

santigimeno mentioned this pull request Jul 3, 2023

Node 20.3 Crashes all the time when executed inside docker #48444

Closed

targos approved these changes Jul 4, 2023

View reviewed changes

lizthegrey mentioned this pull request Jul 4, 2023

update to LTS node eve-val/eve-roster#1812

Merged

RafaelGSS force-pushed the v20.4.0-proposal branch from 51174cd to 73c632e Compare July 4, 2023 22:19

RafaelGSS merged commit 73c632e into v20.x Jul 5, 2023

RafaelGSS deleted the v20.4.0-proposal branch July 5, 2023 13:50

RafaelGSS added a commit that referenced this pull request Jul 5, 2023

Working on v20.4.1

08c6287

PR-URL: #48643

RafaelGSS added a commit to RafaelGSS/nodejs.org that referenced this pull request Jul 5, 2023

Blog: v20.4.0 release post

1cb5ff0

Refs: nodejs/node#48643

RafaelGSS mentioned this pull request Jul 5, 2023

Blog: v20.4.0 release post nodejs/nodejs.org#5473

Merged

RafaelGSS added a commit to RafaelGSS/nodejs.org that referenced this pull request Jul 5, 2023

Blog: v20.4.0 release post

b33dc96

Refs: nodejs/node#48643 Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>

RafaelGSS added a commit to nodejs/nodejs.org that referenced this pull request Jul 5, 2023

Blog: v20.4.0 release post (#5473)

fabef79

Refs: nodejs/node#48643 Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>

climba03003 mentioned this pull request Jul 7, 2023

Leverage using/Symbol.dispose to ensure resources are cleaned up before Node.js exits #48687

Closed

This comment was marked as resolved.

Sign in to view

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

v20.4.0 proposal #48643

v20.4.0 proposal #48643

Uh oh!

RafaelGSS commented Jul 3, 2023 •

edited

Loading

nodejs-github-bot commented Jul 3, 2023 •

edited by RafaelGSS

Loading

mcollina commented Jul 4, 2023

RafaelGSS commented Jul 4, 2023 •

edited

Loading

RafaelGSS commented Jul 4, 2023

RafaelGSS commented Jul 4, 2023

RafaelGSS commented Jul 4, 2023

RafaelGSS commented Jul 4, 2023 •

edited

Loading

RafaelGSS commented Jul 4, 2023

RafaelGSS commented Jul 4, 2023

RafaelGSS commented Jul 5, 2023

This comment was marked as resolved.

Labels

51 participants

Uh oh!

v20.4.0 proposal #48643

v20.4.0 proposal #48643

Uh oh!

Conversation

RafaelGSS commented Jul 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

2023-07-05, Version 20.4.0 (Current), @RafaelGSS

Notable Changes

Mock Timers

Support to the explicit resource management proposal

Other notable changes

Commits

nodejs-github-bot commented Jul 3, 2023 • edited by RafaelGSS Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

mcollina commented Jul 4, 2023

RafaelGSS commented Jul 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

RafaelGSS commented Jul 4, 2023

RafaelGSS commented Jul 4, 2023

RafaelGSS commented Jul 4, 2023

RafaelGSS commented Jul 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

RafaelGSS commented Jul 4, 2023

RafaelGSS commented Jul 4, 2023

RafaelGSS commented Jul 5, 2023

This comment was marked as resolved.

Labels

51 participants

RafaelGSS commented Jul 3, 2023 •

edited

Loading

nodejs-github-bot commented Jul 3, 2023 •

edited by RafaelGSS

Loading

RafaelGSS commented Jul 4, 2023 •

edited

Loading

RafaelGSS commented Jul 4, 2023 •

edited

Loading