permission: handle end nodes with children cases #48531
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
| Review requested:
|
nodejs-github-bot added c++ 
anonrig reviewed Jun 23, 2023
4 tasks
RafaelGSS force-pushed the fix-leaf-node-perm-model branch from d301f50 to 394d0ea Compare 
github-actions bot removed the request-ci Collaborator
anonrig approved these changes Jun 24, 2023
anonrig added the author ready 
juanarbol approved these changes Jun 24, 2023
RafaelGSS added the commit-queue nodejs-github-bot removed the commit-queue Collaborator
| Landed in b38bc9f |
RafaelGSS added a commit that referenced this pull request Jul 3, 2023
PR-URL: #48531 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Merged
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
PR-URL: nodejs#48531 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
PR-URL: nodejs#48531 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Member
| This commit does not land cleanly on |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
When two paths overlaps, the permission model returns a false negative cause the Node* doesn't contain an empty child ("") to consider it as an end node. For instance, if you call
--allow-fs-read=/home/index.js,/home/index.jsonand call process.permission.has for both paths, it will return false for theindex.jssince it will create the following radix tree:and if you invert the parameters order:
--allow-fs-read=/home/index.json,/home/index.jsit will create an empty child for "/home/index.js" indicating "end node".To handle it I've included a new parameter to
Node*:is_leaf.