lib: create weakRef only if any signals provided #48448
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Linkgoron reviewed Jun 13, 2023
atlowChemi force-pushed the lib--create-weakRef-only-if-any-signals-provided branch from b74da91 to f70772d Compare 
github-actions bot removed the request-ci 
Collaborator
aduh95 reviewed Jun 13, 2023
Linkgoron reviewed Jun 13, 2023
atlowChemi force-pushed the lib--create-weakRef-only-if-any-signals-provided branch from f70772d to 26d8fbe Compare Linkgoron reviewed Jun 13, 2023
atlowChemi force-pushed the lib--create-weakRef-only-if-any-signals-provided branch from 26d8fbe to 6cb4ad9 Compare aduh95 approved these changes Jun 13, 2023
github-actions bot removed the request-ci Collaborator
Linkgoron approved these changes Jun 13, 2023
atlowChemi added the author ready Collaborator
MoLow approved these changes Jun 13, 2023
20 tasks
atlowChemi added the commit-queue 
lpinca approved these changes Jun 14, 2023
22 tasks
nodejs-github-bot removed the commit-queue Collaborator
| Landed in f3ee4e2 |
29 tasks
Merged
atlowChemi added a commit to atlowChemi/node that referenced this pull request Jul 17, 2023
PR-URL: nodejs#48448 Fixes: nodejs#48419 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Nitzan Uziely <linkgoron@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
PR-URL: nodejs#48448 Fixes: nodejs#48419 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Nitzan Uziely <linkgoron@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
PR-URL: nodejs#48448 Fixes: nodejs#48419 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Nitzan Uziely <linkgoron@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes: #48419