buffer: introduce File #45139

KhafraDev · 2022-10-24T03:03:41Z

Fixes: #39015

File is useful for the fetch api and is one step closer to implementing the entirety of the FileAPI.

This is my second pr here and my first major one. Please go easy lol

mscdex · 2022-10-24T03:07:08Z

Shouldn't file-related APIs be under fs instead?

KhafraDev · 2022-10-24T03:07:44Z

I wasn't sure, Blob was added under buffer, and File is a small wrapper around it.

jasnell · 2022-10-24T06:29:54Z

Shouldn't file-related APIs be under fs instead?

In this case, not really. Despite the name it really has nothing to do with fs.

This is great to see. It would be fantastic if this also pulled in the WPTs for File but I'm also happy with those coming in a separate PR.

lib/internal/file.js

KhafraDev · 2022-10-24T14:13:57Z

I added the WPTs for File

anonrig

Can you also add some basic benchmarks for File, just like Blob?

lib/internal/file.js

KhafraDev · 2022-10-24T20:31:19Z

I added in a benchmark for file

lib/internal/file.js

doc/api/buffer.md

test/wpt/status/FileAPI/file.json

aduh95 · 2022-10-24T23:56:32Z

FYI here's a code snippet that's passing in Firefox, Safari, and Chromium (there's a failure on Deno, I'll try to report that to them):

const assert = { strictEqual(actual, expected) { if (actual !== expected) throw new Error(`Expected ${expected}, got ${actual}`); }, throws(fn, expected) { try { fn(); throw new Error('Missing expected exception') } catch(e) { if(e instanceof expected) { return } throw new Error('Wrong type of error', {cause: e}) } } }; function mustCall(fn, nb = 1) { setTimeout(() => { if (nb !== 0) throw new Error(`Expected ${nb} more calls`); }, 999); return function() { nb--; return Reflect.apply(fn, this, arguments); }; } [undefined, null, Object.create(null), { lastModified: undefined }, { get lastModified() {} }].forEach((options) => { assert.strictEqual(new File([], null, options).lastModified, new File([], null).lastModified); }); Reflect.defineProperty(Object.prototype, 'lastModified', { __proto__: null, configurable: true, get: mustCall(() => 3, 7), }); [{}, [], ()=>{}, Number, new Number, new String, new Boolean].forEach(options => { assert.strictEqual(new File([], null, options).lastModified, 3); }); [0, '', true, Symbol(), 0n].forEach(options => { assert.throws(() => new File([], null, options), TypeError); }); delete Object.prototype.lastModified;

Possibly we want to add that to our tests to ensure we're aligned.

KhafraDev · 2022-10-25T00:04:52Z

@aduh95 - a few of those tests fail due to Blob's validation of options, there isn't much I could do in this PR about it. The WPTs test for a bunch of these already.

benchmark/file/file.js

Trott · 2022-10-25T19:05:32Z

@nodejs/buffer

aduh95 · 2022-10-31T23:49:24Z

a few of those tests fail due to Blob's validation of options, there isn't much I could do in this PR about it. The WPTs test for a bunch of these already.

@KhafraDev Do you want to rebase on top of d6ee274 to address it, or would you prefer having this done in a followup PR?

Notable changes: buffer: * (SEMVER-MINOR) introduce File (Khafra) #45139 deps: * update timezone to 2022f (Node.js GitHub Bot) #45289 * update V8 to 10.8.168.20 (Michaël Zasso) #45230 doc: * deprecate use of invalid ports in `url.parse` (Antoine du Hamel) #45576 util: * add fast path for utf8 encoding (Yagiz Nizipli) #45412 PR-URL: #45615

Notable changes: buffer: * (SEMVER-MINOR) introduce File (Khafra) nodejs#45139 deps: * update timezone to 2022f (Node.js GitHub Bot) nodejs#45289 * update V8 to 10.8.168.20 (Michaël Zasso) nodejs#45230 doc: * deprecate use of invalid ports in `url.parse` (Antoine du Hamel) nodejs#45576 util: * add fast path for utf8 encoding (Yagiz Nizipli) nodejs#45412 PR-URL: nodejs#45615

PR-URL: nodejs#45139 Fixes: nodejs#39015 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

PR-URL: #45139 Fixes: #39015 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

danielleadams · 2022-12-30T20:07:38Z

@KhafraDev I know this PR was a few months ago - but do you want to create a small paragraph explaining this feature for the v18 release notes? If not, no worries. Thanks!

Notable changes: Add support for externally shared js builtins: By default Node.js is built so that all dependencies are bundled into the Node.js binary itself. Some Node.js distributions prefer to manage dependencies externally. There are existing build options that allow dependencies with native code to be externalized. This commit adds additional options so that dependencies with JavaScript code (including WASM) can also be externalized. This addition does not affect binaries shipped by the Node.js project but will allow other distributions to externalize additional dependencies when needed. Contributed by Michael Dawson in #44376 fs.watch recursive support on Linux: `fs.watch` supports recursive watch using the `recursive: true` option. ```js const watcher = fs.watch(testDirectory, { recursive: true }); watcher.on('change', function(event, filename) { }); ``` Contributed by Yagiz Nizipli in #45098 Support function mocking on Node.js test runner: The `node:test` module supports mocking during testing via a top-level `mock` object. ```js test('spies on an object method', (t) => { const number = { value: 5, add(a) { return this.value + a; }, }; t.mock.method(number, 'add'); assert.strictEqual(number.add(3), 8); assert.strictEqual(number.add.mock.calls.length, 1); }); ``` Contributed by Colin Ihrig in #45326 Other notable changes: buffer: * (SEMVER-MINOR) introduce File (Khafra) #45139 build: * disable v8 snapshot compression by default (Joyee Cheung) #45716 crypto: * update root certificates (Luigi Pinca) #45490 deps: * update ICU to 72.1 (Michaël Zasso) #45068 doc: * add doc-only deprecation for headers/trailers setters (Rich Trott) #45697 * add Rafael to the tsc (Michael Dawson) #45691 * deprecate use of invalid ports in `url.parse` (Antoine du Hamel) #45576 * add lukekarrys to collaborators (Luke Karrys) #45180 * add anonrig to collaborators (Yagiz Nizipli) #45002 * deprecate url.parse() (Rich Trott) #44919 lib: * drop fetch experimental warning (Matteo Collina) #45287 net: * (SEMVER-MINOR) add autoSelectFamily and autoSelectFamilyAttemptTimeout options (Paolo Insogna) #44731 * src: * (SEMVER-MINOR) add uvwasi version (Jithil P Ponnan) #45639 * (SEMVER-MINOR) add initial shadow realm support (Chengzhong Wu) #42869 test_runner: * (SEMVER-MINOR) add t.after() hook (Colin Ihrig) #45792 * (SEMVER-MINOR) don't use a symbol for runHook() (Colin Ihrig) #45792 tls: * (SEMVER-MINOR) add "ca" property to certificate object (Ben Noordhuis) #44935 * remove trustcor root ca certificates (Ben Noordhuis) #45776 tools: * update certdata.txt (Luigi Pinca) #45490 util: * add fast path for utf8 encoding (Yagiz Nizipli) #45412 * improve textdecoder decode performance (Yagiz Nizipli) #45294 * (SEMVER-MINOR) add MIME utilities (#21128) (Bradley Farias) #21128 PR-URL: TBD

Notable changes: Add support for externally shared js builtins: By default Node.js is built so that all dependencies are bundled into the Node.js binary itself. Some Node.js distributions prefer to manage dependencies externally. There are existing build options that allow dependencies with native code to be externalized. This commit adds additional options so that dependencies with JavaScript code (including WASM) can also be externalized. This addition does not affect binaries shipped by the Node.js project but will allow other distributions to externalize additional dependencies when needed. Contributed by Michael Dawson in #44376 fs.watch recursive support on Linux: `fs.watch` supports recursive watch using the `recursive: true` option. ```js const watcher = fs.watch(testDirectory, { recursive: true }); watcher.on('change', function(event, filename) { }); ``` Contributed by Yagiz Nizipli in #45098 Support function mocking on Node.js test runner: The `node:test` module supports mocking during testing via a top-level `mock` object. ```js test('spies on an object method', (t) => { const number = { value: 5, add(a) { return this.value + a; }, }; t.mock.method(number, 'add'); assert.strictEqual(number.add(3), 8); assert.strictEqual(number.add.mock.calls.length, 1); }); ``` Contributed by Colin Ihrig in #45326 Other notable changes: buffer: * (SEMVER-MINOR) introduce File (Khafra) #45139 build: * disable v8 snapshot compression by default (Joyee Cheung) #45716 crypto: * update root certificates (Luigi Pinca) #45490 deps: * update ICU to 72.1 (Michaël Zasso) #45068 doc: * add doc-only deprecation for headers/trailers setters (Rich Trott) #45697 * add Rafael to the tsc (Michael Dawson) #45691 * deprecate use of invalid ports in `url.parse` (Antoine du Hamel) #45576 * add lukekarrys to collaborators (Luke Karrys) #45180 * add anonrig to collaborators (Yagiz Nizipli) #45002 * deprecate url.parse() (Rich Trott) #44919 lib: * drop fetch experimental warning (Matteo Collina) #45287 net: * (SEMVER-MINOR) add autoSelectFamily and autoSelectFamilyAttemptTimeout options (Paolo Insogna) #44731 * src: * (SEMVER-MINOR) add uvwasi version (Jithil P Ponnan) #45639 * (SEMVER-MINOR) add initial shadow realm support (Chengzhong Wu) #42869 test_runner: * (SEMVER-MINOR) add t.after() hook (Colin Ihrig) #45792 * (SEMVER-MINOR) don't use a symbol for runHook() (Colin Ihrig) #45792 tls: * (SEMVER-MINOR) add "ca" property to certificate object (Ben Noordhuis) #44935 * remove trustcor root ca certificates (Ben Noordhuis) #45776 tools: * update certdata.txt (Luigi Pinca) #45490 util: * add fast path for utf8 encoding (Yagiz Nizipli) #45412 * improve textdecoder decode performance (Yagiz Nizipli) #45294 * (SEMVER-MINOR) add MIME utilities (#21128) (Bradley Farias) #21128 PR-URL: #46025

KhafraDev · 2022-12-30T20:46:14Z

I'd be glad to!

The File class is part of the [FileAPI](https://w3c.github.io/FileAPI/). It can be used anywhere a Blob can, for example in `URL.createObjectURL` and `FormData`. It contains two properties that Blobs do not have: `lastModified`, the last time the file was modified in ms, and `name`, the name of the file.

If there's anything missing I can revise it. Hopefully using markdown is fine too. 😄

PR-URL: #45139 Fixes: #39015 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

Notable changes: Add support for externally shared js builtins: By default Node.js is built so that all dependencies are bundled into the Node.js binary itself. Some Node.js distributions prefer to manage dependencies externally. There are existing build options that allow dependencies with native code to be externalized. This commit adds additional options so that dependencies with JavaScript code (including WASM) can also be externalized. This addition does not affect binaries shipped by the Node.js project but will allow other distributions to externalize additional dependencies when needed. Contributed by Michael Dawson in #44376 fs.watch recursive support on Linux: `fs.watch` supports recursive watch using the `recursive: true` option. ```js const watcher = fs.watch(testDirectory, { recursive: true }); watcher.on('change', function(event, filename) { }); ``` Contributed by Yagiz Nizipli in #45098 Support function mocking on Node.js test runner: The `node:test` module supports mocking during testing via a top-level `mock` object. ```js test('spies on an object method', (t) => { const number = { value: 5, add(a) { return this.value + a; }, }; t.mock.method(number, 'add'); assert.strictEqual(number.add(3), 8); assert.strictEqual(number.add.mock.calls.length, 1); }); ``` Contributed by Colin Ihrig in #45326 Other notable changes: buffer: * (SEMVER-MINOR) introduce File (Khafra) #45139 build: * disable v8 snapshot compression by default (Joyee Cheung) #45716 crypto: * update root certificates (Luigi Pinca) #45490 deps: * update ICU to 72.1 (Michaël Zasso) #45068 doc: * add doc-only deprecation for headers/trailers setters (Rich Trott) #45697 * add Rafael to the tsc (Michael Dawson) #45691 * deprecate use of invalid ports in `url.parse` (Antoine du Hamel) #45576 * add lukekarrys to collaborators (Luke Karrys) #45180 * add anonrig to collaborators (Yagiz Nizipli) #45002 * deprecate url.parse() (Rich Trott) #44919 lib: * drop fetch experimental warning (Matteo Collina) #45287 net: * (SEMVER-MINOR) add autoSelectFamily and autoSelectFamilyAttemptTimeout options (Paolo Insogna) #44731 * src: * (SEMVER-MINOR) add uvwasi version (Jithil P Ponnan) #45639 * (SEMVER-MINOR) add initial shadow realm support (Chengzhong Wu) #42869 test_runner: * (SEMVER-MINOR) add t.after() hook (Colin Ihrig) #45792 * (SEMVER-MINOR) don't use a symbol for runHook() (Colin Ihrig) #45792 tls: * (SEMVER-MINOR) add "ca" property to certificate object (Ben Noordhuis) #44935 * remove trustcor root ca certificates (Ben Noordhuis) #45776 tools: * update certdata.txt (Luigi Pinca) #45490 util: * add fast path for utf8 encoding (Yagiz Nizipli) #45412 * improve textdecoder decode performance (Yagiz Nizipli) #45294 * (SEMVER-MINOR) add MIME utilities (#21128) (Bradley Farias) #21128 PR-URL: #46025

Notable changes: Add support for externally shared js builtins: By default Node.js is built so that all dependencies are bundled into the Node.js binary itself. Some Node.js distributions prefer to manage dependencies externally. There are existing build options that allow dependencies with native code to be externalized. This commit adds additional options so that dependencies with JavaScript code (including WASM) can also be externalized. This addition does not affect binaries shipped by the Node.js project but will allow other distributions to externalize additional dependencies when needed. Contributed by Michael Dawson in #44376 Introduce `File`: The File class is part of the [FileAPI](https://w3c.github.io/FileAPI/). It can be used anywhere a Blob can, for example in `URL.createObjectURL` and `FormData`. It contains two properties that Blobs do not have: `lastModified`, the last time the file was modified in ms, and `name`, the name of the file. Contributed by Khafra in #45139 Support function mocking on Node.js test runner: The `node:test` module supports mocking during testing via a top-level `mock` object. ```js test('spies on an object method', (t) => { const number = { value: 5, add(a) { return this.value + a; }, }; t.mock.method(number, 'add'); assert.strictEqual(number.add(3), 8); assert.strictEqual(number.add.mock.calls.length, 1); }); ``` Contributed by Colin Ihrig in #45326 Other notable changes: build: * disable v8 snapshot compression by default (Joyee Cheung) #45716 crypto: * update root certificates (Luigi Pinca) #45490 deps: * update ICU to 72.1 (Michaël Zasso) #45068 doc: * add doc-only deprecation for headers/trailers setters (Rich Trott) #45697 * add Rafael to the tsc (Michael Dawson) #45691 * deprecate use of invalid ports in `url.parse` (Antoine du Hamel) #45576 * add lukekarrys to collaborators (Luke Karrys) #45180 * add anonrig to collaborators (Yagiz Nizipli) #45002 * deprecate url.parse() (Rich Trott) #44919 lib: * drop fetch experimental warning (Matteo Collina) #45287 net: * (SEMVER-MINOR) add autoSelectFamily and autoSelectFamilyAttemptTimeout options (Paolo Insogna) #44731 * src: * (SEMVER-MINOR) add uvwasi version (Jithil P Ponnan) #45639 * (SEMVER-MINOR) add initial shadow realm support (Chengzhong Wu) #42869 test_runner: * (SEMVER-MINOR) add t.after() hook (Colin Ihrig) #45792 * (SEMVER-MINOR) don't use a symbol for runHook() (Colin Ihrig) #45792 tls: * (SEMVER-MINOR) add "ca" property to certificate object (Ben Noordhuis) #44935 * remove trustcor root ca certificates (Ben Noordhuis) #45776 tools: * update certdata.txt (Luigi Pinca) #45490 util: * add fast path for utf8 encoding (Yagiz Nizipli) #45412 * improve textdecoder decode performance (Yagiz Nizipli) #45294 * (SEMVER-MINOR) add MIME utilities (#21128) (Bradley Farias) #21128 PR-URL: #46025

PR-URL: #45139 Fixes: #39015 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

Notable changes: Add support for externally shared js builtins: By default Node.js is built so that all dependencies are bundled into the Node.js binary itself. Some Node.js distributions prefer to manage dependencies externally. There are existing build options that allow dependencies with native code to be externalized. This commit adds additional options so that dependencies with JavaScript code (including WASM) can also be externalized. This addition does not affect binaries shipped by the Node.js project but will allow other distributions to externalize additional dependencies when needed. Contributed by Michael Dawson in #44376 Introduce `File`: The File class is part of the [FileAPI](https://w3c.github.io/FileAPI/). It can be used anywhere a Blob can, for example in `URL.createObjectURL` and `FormData`. It contains two properties that Blobs do not have: `lastModified`, the last time the file was modified in ms, and `name`, the name of the file. Contributed by Khafra in #45139 Support function mocking on Node.js test runner: The `node:test` module supports mocking during testing via a top-level `mock` object. ```js test('spies on an object method', (t) => { const number = { value: 5, add(a) { return this.value + a; }, }; t.mock.method(number, 'add'); assert.strictEqual(number.add(3), 8); assert.strictEqual(number.add.mock.calls.length, 1); }); ``` Contributed by Colin Ihrig in #45326 Other notable changes: build: * disable v8 snapshot compression by default (Joyee Cheung) #45716 crypto: * update root certificates (Luigi Pinca) #45490 deps: * update ICU to 72.1 (Michaël Zasso) #45068 doc: * add doc-only deprecation for headers/trailers setters (Rich Trott) #45697 * add Rafael to the tsc (Michael Dawson) #45691 * deprecate use of invalid ports in `url.parse` (Antoine du Hamel) #45576 * add lukekarrys to collaborators (Luke Karrys) #45180 * add anonrig to collaborators (Yagiz Nizipli) #45002 * deprecate url.parse() (Rich Trott) #44919 lib: * drop fetch experimental warning (Matteo Collina) #45287 net: * (SEMVER-MINOR) add autoSelectFamily and autoSelectFamilyAttemptTimeout options (Paolo Insogna) #44731 * src: * (SEMVER-MINOR) add uvwasi version (Jithil P Ponnan) #45639 * (SEMVER-MINOR) add initial shadow realm support (Chengzhong Wu) #42869 test_runner: * (SEMVER-MINOR) add t.after() hook (Colin Ihrig) #45792 * (SEMVER-MINOR) don't use a symbol for runHook() (Colin Ihrig) #45792 tls: * (SEMVER-MINOR) add "ca" property to certificate object (Ben Noordhuis) #44935 * remove trustcor root ca certificates (Ben Noordhuis) #45776 tools: * update certdata.txt (Luigi Pinca) #45490 util: * add fast path for utf8 encoding (Yagiz Nizipli) #45412 * improve textdecoder decode performance (Yagiz Nizipli) #45294 * (SEMVER-MINOR) add MIME utilities (#21128) (Bradley Farias) #21128 PR-URL: #46025

PR-URL: #45139 Fixes: #39015 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

Notable changes: Add support for externally shared js builtins: By default Node.js is built so that all dependencies are bundled into the Node.js binary itself. Some Node.js distributions prefer to manage dependencies externally. There are existing build options that allow dependencies with native code to be externalized. This commit adds additional options so that dependencies with JavaScript code (including WASM) can also be externalized. This addition does not affect binaries shipped by the Node.js project but will allow other distributions to externalize additional dependencies when needed. Contributed by Michael Dawson in #44376 Introduce `File`: The File class is part of the [FileAPI](https://w3c.github.io/FileAPI/). It can be used anywhere a Blob can, for example in `URL.createObjectURL` and `FormData`. It contains two properties that Blobs do not have: `lastModified`, the last time the file was modified in ms, and `name`, the name of the file. Contributed by Khafra in #45139 Support function mocking on Node.js test runner: The `node:test` module supports mocking during testing via a top-level `mock` object. ```js test('spies on an object method', (t) => { const number = { value: 5, add(a) { return this.value + a; }, }; t.mock.method(number, 'add'); assert.strictEqual(number.add(3), 8); assert.strictEqual(number.add.mock.calls.length, 1); }); ``` Contributed by Colin Ihrig in #45326 Other notable changes: build: * disable v8 snapshot compression by default (Joyee Cheung) #45716 crypto: * update root certificates (Luigi Pinca) #45490 deps: * update ICU to 72.1 (Michaël Zasso) #45068 doc: * add doc-only deprecation for headers/trailers setters (Rich Trott) #45697 * add Rafael to the tsc (Michael Dawson) #45691 * deprecate use of invalid ports in `url.parse` (Antoine du Hamel) #45576 * add lukekarrys to collaborators (Luke Karrys) #45180 * add anonrig to collaborators (Yagiz Nizipli) #45002 * deprecate url.parse() (Rich Trott) #44919 lib: * drop fetch experimental warning (Matteo Collina) #45287 net: * (SEMVER-MINOR) add autoSelectFamily and autoSelectFamilyAttemptTimeout options (Paolo Insogna) #44731 * src: * (SEMVER-MINOR) add uvwasi version (Jithil P Ponnan) #45639 * (SEMVER-MINOR) add initial shadow realm support (Chengzhong Wu) #42869 test_runner: * (SEMVER-MINOR) add t.after() hook (Colin Ihrig) #45792 * (SEMVER-MINOR) don't use a symbol for runHook() (Colin Ihrig) #45792 tls: * (SEMVER-MINOR) add "ca" property to certificate object (Ben Noordhuis) #44935 * remove trustcor root ca certificates (Ben Noordhuis) #45776 tools: * update certdata.txt (Luigi Pinca) #45490 util: * add fast path for utf8 encoding (Yagiz Nizipli) #45412 * improve textdecoder decode performance (Yagiz Nizipli) #45294 * (SEMVER-MINOR) add MIME utilities (#21128) (Bradley Farias) #21128 PR-URL: #46025

Rodocasa · 2023-01-30T22:42:19Z

test/fixtures/wpt/README.md

 - encoding: https://github.com/web-platform-tests/wpt/tree/c1b24fce6e/encoding
 - fetch/data-urls/resources: https://github.com/web-platform-tests/wpt/tree/7c79d998ff/fetch/data-urls/resources
 - FileAPI: https://github.com/web-platform-tests/wpt/tree/3b279420d4/FileAPI
+- FileAPI/file: https://github.com/web-platform-tests/wpt/tree/c01f637cca/FileAPI/file


nodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. needs-ci PRs that need a full CI run. labels Oct 24, 2022

VoltrexKeyva reviewed Oct 24, 2022

View reviewed changes

lib/internal/file.js Outdated Show resolved Hide resolved

anonrig requested changes Oct 24, 2022

View reviewed changes

lib/internal/file.js Show resolved Hide resolved

anonrig approved these changes Oct 24, 2022

View reviewed changes

aduh95 reviewed Oct 24, 2022

View reviewed changes

lib/internal/file.js Outdated Show resolved Hide resolved

lib/internal/file.js Outdated Show resolved Hide resolved

lib/internal/file.js Outdated Show resolved Hide resolved

lib/internal/file.js Outdated Show resolved Hide resolved

lib/internal/file.js Outdated Show resolved Hide resolved

aduh95 reviewed Oct 24, 2022

View reviewed changes

doc/api/buffer.md Show resolved Hide resolved

aduh95 reviewed Oct 24, 2022

View reviewed changes

test/wpt/status/FileAPI/file.json Outdated Show resolved Hide resolved

aduh95 reviewed Oct 25, 2022

View reviewed changes

benchmark/file/file.js Show resolved Hide resolved

JungMinu approved these changes Oct 25, 2022

View reviewed changes

Trott added the semver-minor PRs that contain new features and should be released in the next minor version. label Oct 25, 2022

targos mentioned this pull request Oct 26, 2022

File-based Blob implementation #45188

Closed

KhafraDev added 9 commits October 31, 2022 20:04

buffer: introduce File

f8940e9

fix: update type-parser

5cd047d

fix: change linebreak to lf

991927d

fix: format docs

8325e81

fix: use shorthand property

246bb6f

fix: add FileAPI/file WPTs

1944749

fix: wpt add expected failures

5133587

fix: bootstrap modules test & add in benchmark

d162b86

fix: apply suggestions from review

3763753

Ethan-Arrowood mentioned this pull request Dec 1, 2022

Blob and File WinterTC55/proposal-minimum-common-api#17

Closed

ThisIsMissEm mentioned this pull request Dec 6, 2022

Backport FileAPI to 16.x #45763

Closed

ThisIsMissEm mentioned this pull request Dec 6, 2022

[v16.x backport] buffer: introduce File #45764

Closed

danielleadams pushed a commit that referenced this pull request Dec 30, 2022

buffer: introduce File

22516f5

PR-URL: #45139 Fixes: #39015 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

danielleadams mentioned this pull request Dec 30, 2022

v18.13.0 release proposal #46025

Merged

danielleadams pushed a commit that referenced this pull request Dec 30, 2022

buffer: introduce File

51add61

PR-URL: #45139 Fixes: #39015 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

danielleadams pushed a commit that referenced this pull request Jan 3, 2023

buffer: introduce File

3a7f3d5

PR-URL: #45139 Fixes: #39015 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

danielleadams pushed a commit that referenced this pull request Jan 4, 2023

buffer: introduce File

3f39082

PR-URL: #45139 Fixes: #39015 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

Rodocasa reviewed Jan 30, 2023

View reviewed changes

isker mentioned this pull request Mar 20, 2023

Implement File class #39015

Closed

adamziel mentioned this pull request May 30, 2023

Remove DOMParser from Blueprints: installPlugin and installTheme WordPress/wordpress-playground#427

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

buffer: introduce File #45139

buffer: introduce File #45139

Uh oh!

KhafraDev commented Oct 24, 2022

mscdex commented Oct 24, 2022

KhafraDev commented Oct 24, 2022

jasnell commented Oct 24, 2022

Uh oh!

KhafraDev commented Oct 24, 2022

anonrig left a comment

Uh oh!

KhafraDev commented Oct 24, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

aduh95 commented Oct 24, 2022

KhafraDev commented Oct 25, 2022 •

edited

Loading

Uh oh!

Trott commented Oct 25, 2022

aduh95 commented Oct 31, 2022 •

edited

Loading

danielleadams commented Dec 30, 2022

KhafraDev commented Dec 30, 2022

Rodocasa Jan 30, 2023

Labels

13 participants

Uh oh!

buffer: introduce File #45139

buffer: introduce File #45139

Uh oh!

Conversation

KhafraDev commented Oct 24, 2022

mscdex commented Oct 24, 2022

KhafraDev commented Oct 24, 2022

jasnell commented Oct 24, 2022

Uh oh!

KhafraDev commented Oct 24, 2022

anonrig left a comment

Choose a reason for hiding this comment

Uh oh!

KhafraDev commented Oct 24, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

aduh95 commented Oct 24, 2022

KhafraDev commented Oct 25, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Trott commented Oct 25, 2022

aduh95 commented Oct 31, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

danielleadams commented Dec 30, 2022

KhafraDev commented Dec 30, 2022

Rodocasa Jan 30, 2023

Choose a reason for hiding this comment

Labels

13 participants

KhafraDev commented Oct 25, 2022 •

edited

Loading

aduh95 commented Oct 31, 2022 •

edited

Loading