fs: add recursive watch for linux

[anonrig]

Fixes #36005

List

• Add promises API
  • fs: add recursive watch for linux #45098 (review)
• Add tests for promises API
• Add URL as filename tests
• Make a decision in making watcher initialization async or sync.
  • fs: add recursive watch for linux #45098 (comment)
• Add symlink support

CC @nodejs/fs

[mcollina]

This module uses a mix of callbacks and promises. I would prefer if it only relied on callbacks as it would be a callback API. Maybe I'm a bit too concerned about the intertwining of our two sets of APIs.

---

This also needs support for the promises API.

[danielleadams]

Hi @anonrig - this did not land cleanly on v18.x. When landing there were variables used that were not defined in v18.x-staging branch's version of the file. Could you open a backport PR? Thank you.

[anonrig]

@danielleadams It seems this pull request is in the v18.x-staging branch: https://github.com/nodejs/node/blob/v18.13.0-proposal/lib/internal/fs/recursive_watch.js

[juanarbol]

@danielleadams It seems this pull request is in the v18.x-staging branch: https://github.com/nodejs/node/blob/v18.13.0-proposal/lib/internal/fs/recursive_watch.js

That link is a 404; marking this is a "backport-requested-v18.x" again.

[anonrig]

This pull request is already backported @juanarbol

Referencing: https://github.com/nodejs/node/blob/v18.x-staging/lib/internal/fs/recursive_watch.js

[aduh95]

That's not correct @anonrig, the pull request was not backported, it never showed on the v18.x changelog. The file you linked was added with c2f0377 (which is a backport for #45265), but all the other changes in this PR still need to be backported manually (docs and tests).

[raphaelboukara]

Hi :)
Does this fix will be backported to v18.x ?

[mcollina]

I don't expect this to be backported, because there are issues with this and Node.js v18 is in maintenance.

See #48437 for more details.