WIP: fix leaks and ref-counting bugs in searches handling node disconnects #115722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…nects There's a number of issues in this one. Opening it to have the fixes for elastic#115056 all in one place but will merge this through a couple PRs for individual review to make it easier -> WIP
original-brownbear added >bug WIP :Search/Search 
original-brownbear added a commit to original-brownbear/elasticsearch that referenced this pull request Oct 26, 2024
The results instance does not need to be a field. It's state handling is fairly straight forward, it needs to be released once all fetches have been procesed. No need to even create it on any other path so I split up the method slightly to clearly isolate when and how we need the results instance. Part of elastic#115722
original-brownbear added a commit that referenced this pull request Oct 28, 2024
The results instance does not need to be a field. It's state handling is fairly straight forward, it needs to be released once all fetches have been procesed. No need to even create it on any other path so I split up the method slightly to clearly isolate when and how we need the results instance. Part of #115722
| closing in favour of #116060 |
ioanatia pushed a commit to ioanatia/elasticsearch that referenced this pull request Nov 4, 2024
The results instance does not need to be a field. It's state handling is fairly straight forward, it needs to be released once all fetches have been procesed. No need to even create it on any other path so I split up the method slightly to clearly isolate when and how we need the results instance. Part of elastic#115722
jfreden pushed a commit to jfreden/elasticsearch that referenced this pull request Nov 4, 2024
The results instance does not need to be a field. It's state handling is fairly straight forward, it needs to be released once all fetches have been procesed. No need to even create it on any other path so I split up the method slightly to clearly isolate when and how we need the results instance. Part of elastic#115722
original-brownbear added a commit to original-brownbear/elasticsearch that referenced this pull request Nov 22, 2024
The results instance does not need to be a field. It's state handling is fairly straight forward, it needs to be released once all fetches have been procesed. No need to even create it on any other path so I split up the method slightly to clearly isolate when and how we need the results instance. Part of elastic#115722
elasticsearchmachine pushed a commit that referenced this pull request Nov 22, 2024
The results instance does not need to be a field. It's state handling is fairly straight forward, it needs to be released once all fetches have been procesed. No need to even create it on any other path so I split up the method slightly to clearly isolate when and how we need the results instance. Part of #115722
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
There's a number of issues in this one. Opening it to have the fixes for #115056 all in one place
but will merge this through a couple PRs for individual review to make it easier -> WIP