Simplify result handling in FetchSearchPhase #115723
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The results instance does not need to be a field. It's state handling is fairly straight forward, it needs to be released once all fetches have been procesed. No need to even create it on any other path so I split up the method slightly to clearly isolate when and how we need the results instance. Part of elastic#115722
original-brownbear added >non-issue :Search/Search 
| Pinging @elastic/es-search (Team:Search) |
benwtrent approved these changes Oct 28, 2024
Comment on lines +149 to +151
| try (fetchResults) { | ||
| moveToNextPhase(fetchResults.getAtomicArray(), reducedQueryPhase); | ||
| } |
There was a problem hiding this comment.
This overall change makes sense to me. I dislike keeping an object around in the constructor and handling lifetimes like we did. Its always confusing.
Just calling out now that with this try (autoClose), we will now release the fetchResults AFTER context.executeNextPhase is called. I am not sure that is a big issue or not as generally the search phases do asynchronous actions.
There was a problem hiding this comment.
That's to some extend by design :D The aggressive closing of these things has been causing a leak (preexisting bug) to show at a higher rate. Let me deal with that bug in a separate PR today and then I'll reintroduce aggressive closing here again tomorrow or so.
| Thanks Ben! |
ioanatia pushed a commit to ioanatia/elasticsearch that referenced this pull request Nov 4, 2024
The results instance does not need to be a field. It's state handling is fairly straight forward, it needs to be released once all fetches have been procesed. No need to even create it on any other path so I split up the method slightly to clearly isolate when and how we need the results instance. Part of elastic#115722
jfreden pushed a commit to jfreden/elasticsearch that referenced this pull request Nov 4, 2024
The results instance does not need to be a field. It's state handling is fairly straight forward, it needs to be released once all fetches have been procesed. No need to even create it on any other path so I split up the method slightly to clearly isolate when and how we need the results instance. Part of elastic#115722
original-brownbear added a commit to original-brownbear/elasticsearch that referenced this pull request Nov 22, 2024
The results instance does not need to be a field. It's state handling is fairly straight forward, it needs to be released once all fetches have been procesed. No need to even create it on any other path so I split up the method slightly to clearly isolate when and how we need the results instance. Part of elastic#115722
elasticsearchmachine pushed a commit that referenced this pull request Nov 22, 2024
The results instance does not need to be a field. It's state handling is fairly straight forward, it needs to be released once all fetches have been procesed. No need to even create it on any other path so I split up the method slightly to clearly isolate when and how we need the results instance. Part of #115722
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The results instance does not need to be a field.
It's state handling is fairly straight forward, it needs to be released once all fetches have been procesed. No need to even create it on any other path so I split up the method slightly to clearly isolate when and how we need the results instance.
This should give a bit of a speedup since it reduces GC by reducing the lifetime of the results and removing a mutation of the global context resources list.
Part of #115722