Catch and handle disconnect exceptions in search #115836
Merged
+111 −65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Getting a connection can throw an exception for a disconnected node. We failed to handle these in the adjusted spots, leading to a phase failure (and possible memory leaks for outstanding operations) instead of correctly recording a per-shard failure.
original-brownbear added >bug :Search Foundations/Search 
elasticsearchmachine added the Team:Search Foundations 
| Pinging @elastic/es-search-foundations (Team:Search Foundations) |
| Hi @original-brownbear, I've created a changelog YAML for you. |
original-brownbear added the auto-backport 
| Thanks Matteo! |
💔 Backport failedYou can use sqren/backport to manually backport by running |
| Part of #115722 |
salvatore-campagna pushed a commit to salvatore-campagna/elasticsearch that referenced this pull request Oct 29, 2024
Getting a connection can throw an exception for a disconnected node. We failed to handle these in the adjusted spots, leading to a phase failure (and possible memory leaks for outstanding operations) instead of correctly recording a per-shard failure.
jfreden pushed a commit to jfreden/elasticsearch that referenced this pull request Nov 4, 2024
Getting a connection can throw an exception for a disconnected node. We failed to handle these in the adjusted spots, leading to a phase failure (and possible memory leaks for outstanding operations) instead of correctly recording a per-shard failure.
original-brownbear added a commit to original-brownbear/elasticsearch that referenced this pull request Nov 22, 2024
Getting a connection can throw an exception for a disconnected node. We failed to handle these in the adjusted spots, leading to a phase failure (and possible memory leaks for outstanding operations) instead of correctly recording a per-shard failure.
elasticsearchmachine pushed a commit that referenced this pull request Nov 22, 2024
Getting a connection can throw an exception for a disconnected node. We failed to handle these in the adjusted spots, leading to a phase failure (and possible memory leaks for outstanding operations) instead of correctly recording a per-shard failure.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Getting a connection can throw an exception for a disconnected node. We failed to handle these in the adjusted spots, leading to a phase failure (and possible memory leaks for outstanding operations) instead of correctly recording a per-shard failure.
Note: this isn't as much change as it looks. Just putting the listener into a variable (or in one case its failure handling into a method) and then try-catch around the connection getting, that's all :)