Skip to content

Conversation

@michaelbrewer
Copy link
Contributor

@michaelbrewer michaelbrewer commented Dec 20, 2021

Issue #, if available:

Description of changes:

Changes:

  • child_exceptions should be a tuple EDIT: Fix type instead
  • remove unecessary else statements
  • add pragma: no cover for overload functions
  • add test for an invalid DynamoDBPersistenceLayer

Checklist

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Changes: - `child_exceptions` should be a tuple - remove unecessary `else` statements - add `pragma: no cover` for overload functions - add test for an invalid DynamoDBPersistenceLayer
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 20, 2021
@michaelbrewer
Copy link
Contributor Author

All pretty minor and optional @heitorlessa

@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2021

Codecov Report

Merging #912 (7042dba) into develop (849e003) will increase coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@ Coverage Diff @@ ## develop #912 +/- ## =========================================== + Coverage 99.79% 99.90% +0.11%  =========================================== Files 118 118 Lines 5262 5246 -16 Branches 596 596 =========================================== - Hits 5251 5241 -10  + Misses 6 1 -5  + Partials 5 4 -1 
Impacted Files Coverage Δ
aws_lambda_powertools/utilities/parser/parser.py 100.00% <ø> (+6.06%) ⬆️
aws_lambda_powertools/utilities/batch/__init__.py 100.00% <100.00%> (ø)
aws_lambda_powertools/utilities/batch/base.py 99.16% <100.00%> (+1.49%) ⬆️
...ws_lambda_powertools/utilities/batch/exceptions.py 100.00% <100.00%> (ø)
aws_lambda_powertools/tracing/tracer.py 100.00% <0.00%> (ø)
...ools/utilities/idempotency/persistence/dynamodb.py 97.33% <0.00%> (+2.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 849e003...7042dba. Read the comment docs.

@boring-cyborg boring-cyborg bot added the dependencies Pull requests that update a dependency file label Dec 20, 2021
@heitorlessa heitorlessa changed the title chore: minor housekeeping changes chore: minor housekeeping changes before release Dec 20, 2021
@heitorlessa heitorlessa changed the title chore: minor housekeeping changes before release chore: minor housekeeping before release Dec 20, 2021
@heitorlessa heitorlessa added the internal Maintenance changes label Dec 20, 2021
@heitorlessa heitorlessa merged commit 39b3136 into aws-powertools:develop Dec 20, 2021
@heitorlessa heitorlessa deleted the chore-tests branch December 20, 2021 06:59
heitorlessa added a commit to ran-isenberg/aws-lambda-powertools-python that referenced this pull request Dec 31, 2021
…tools-python into complex * 'develop' of https://github.com/awslabs/aws-lambda-powertools-python: (24 commits) docs: consistency around admonitions and snippets (aws-powertools#919) chore(deps-dev): bump mypy from 0.920 to 0.930 (aws-powertools#925) fix(event-sources): handle dynamodb null type as none, not bool (aws-powertools#929) fix(apigateway): support @app.not_found() syntax & housekeeping (aws-powertools#926) docs: Added GraphQL Sample API to Examples section of README.md (aws-powertools#930) feat(idempotency): support dataclasses & pydantic models payloads (aws-powertools#908) feat(tracer): ignore tracing for certain hostname(s) or url(s) (aws-powertools#910) feat(event-sources): cache parsed json in data class (aws-powertools#909) fix(warning): future distutils deprecation (aws-powertools#921) docs(batch): remove leftover from legacy docs(layer): bump Lambda Layer to version 6 chore: bump to 1.23.0 docs(apigateway): add new not_found feature (aws-powertools#915) docs: external reference to cloudformation custom resource helper (aws-powertools#914) feat(logger): allow handler with custom kwargs signature (aws-powertools#913) chore: minor housekeeping before release (aws-powertools#912) chore(deps-dev): bump mypy from 0.910 to 0.920 (aws-powertools#903) feat(batch): new BatchProcessor for SQS, DynamoDB, Kinesis (aws-powertools#886) fix(parser): overload parse when using envelope (aws-powertools#885) fix(parser): kinesis sequence number is str, not int (aws-powertools#907) ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file internal Maintenance changes size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tests

3 participants