Skip to content

Conversation

@michaelbrewer
Copy link
Contributor

@michaelbrewer michaelbrewer commented Dec 19, 2021

Issue #, if available:

Description of changes:

from aws_lambda_powertools import Tracer tracer = Tracer() # ignore all calls to `ec2.amazon.com` tracer.ignore_endpoint(hostname="ec2.amazon.com") # ignore calls to `*.sensitive.com/password` and `*.sensitive.com/credit-card` tracer.ignore_endpoint(hostname="*.sensitive.com", urls=["/password", "/credit-card"]) def ec2_api_calls(): return "suppress_api_responses" @tracer.capture_lambda_handler def handler(event, context): for x in long_list: ec2_api_calls()

Checklist

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 19, 2021
@codecov-commenter
Copy link

codecov-commenter commented Dec 19, 2021

Codecov Report

Merging #910 (045f745) into develop (9abeb32) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@ Coverage Diff @@ ## develop #910 +/- ## ======================================== Coverage 99.88% 99.88% ======================================== Files 118 118 Lines 5261 5266 +5 Branches 602 603 +1 ======================================== + Hits 5255 5260 +5  Misses 2 2 Partials 4 4 
Impacted Files Coverage Δ
aws_lambda_powertools/tracing/tracer.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9abeb32...045f745. Read the comment docs.

@michaelbrewer
Copy link
Contributor Author

@heitorlessa - should we go ahead with this?

@heitorlessa
Copy link
Contributor

Will leave it for the release after next - Won't have time to write docs for them all.

The only change I'd make is only importing if the provider is X-Ray in anticipation for custom tracer providers

@heitorlessa heitorlessa added the p1 label Dec 20, 2021
@michaelbrewer
Copy link
Contributor Author

Will leave it for the release after next - Won't have time to write docs for them all.

The only change I'd make is only importing if the provider is X-Ray in anticipation for custom tracer providers

Ok i have added a check for _is_xray_provider

@heitorlessa heitorlessa added the feature New feature or functionality label Dec 22, 2021
@heitorlessa heitorlessa added this to the 1.24.0 milestone Dec 22, 2021
@heitorlessa heitorlessa changed the title feat(tracer): Ignore tracing for certain hostname(s) or url(s) feat(tracer): ignore tracing for certain hostname(s) or url(s) Dec 22, 2021
@heitorlessa heitorlessa merged commit ccefa87 into aws-powertools:develop Dec 22, 2021
@heitorlessa heitorlessa deleted the feat-roadmap-35 branch December 22, 2021 07:16
heitorlessa added a commit to ran-isenberg/aws-lambda-powertools-python that referenced this pull request Dec 31, 2021
…tools-python into complex * 'develop' of https://github.com/awslabs/aws-lambda-powertools-python: (24 commits) docs: consistency around admonitions and snippets (aws-powertools#919) chore(deps-dev): bump mypy from 0.920 to 0.930 (aws-powertools#925) fix(event-sources): handle dynamodb null type as none, not bool (aws-powertools#929) fix(apigateway): support @app.not_found() syntax & housekeeping (aws-powertools#926) docs: Added GraphQL Sample API to Examples section of README.md (aws-powertools#930) feat(idempotency): support dataclasses & pydantic models payloads (aws-powertools#908) feat(tracer): ignore tracing for certain hostname(s) or url(s) (aws-powertools#910) feat(event-sources): cache parsed json in data class (aws-powertools#909) fix(warning): future distutils deprecation (aws-powertools#921) docs(batch): remove leftover from legacy docs(layer): bump Lambda Layer to version 6 chore: bump to 1.23.0 docs(apigateway): add new not_found feature (aws-powertools#915) docs: external reference to cloudformation custom resource helper (aws-powertools#914) feat(logger): allow handler with custom kwargs signature (aws-powertools#913) chore: minor housekeeping before release (aws-powertools#912) chore(deps-dev): bump mypy from 0.910 to 0.920 (aws-powertools#903) feat(batch): new BatchProcessor for SQS, DynamoDB, Kinesis (aws-powertools#886) fix(parser): overload parse when using envelope (aws-powertools#885) fix(parser): kinesis sequence number is str, not int (aws-powertools#907) ...
heitorlessa added a commit to huonw/aws-lambda-powertools-python that referenced this pull request Dec 31, 2021
…tools-python into feature/905-datetime * 'develop' of https://github.com/awslabs/aws-lambda-powertools-python: feat(feature_flags): support beyond boolean values (JSON values) (aws-powertools#804) docs: consistency around admonitions and snippets (aws-powertools#919) chore(deps-dev): bump mypy from 0.920 to 0.930 (aws-powertools#925) fix(event-sources): handle dynamodb null type as none, not bool (aws-powertools#929) fix(apigateway): support @app.not_found() syntax & housekeeping (aws-powertools#926) docs: Added GraphQL Sample API to Examples section of README.md (aws-powertools#930) feat(idempotency): support dataclasses & pydantic models payloads (aws-powertools#908) feat(tracer): ignore tracing for certain hostname(s) or url(s) (aws-powertools#910) feat(event-sources): cache parsed json in data class (aws-powertools#909) fix(warning): future distutils deprecation (aws-powertools#921)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or functionality p1 size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tests

3 participants