Skip to content

Add protobuf linter #776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 16 commits into
base: master
Choose a base branch
from
Draft

Add protobuf linter #776

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
7af97ec
Add buf-lint action
ClemensLinnhoff Feb 12, 2024
5fec885
Fix workflow file
ClemensLinnhoff Feb 12, 2024
af08dd0
Fix workflow file
ClemensLinnhoff Feb 12, 2024
f678347
Move linter
ClemensLinnhoff Feb 12, 2024
0fe23e9
Change to reviewdog-action-protolint
ClemensLinnhoff Feb 12, 2024
5a49c62
Test without github_token
ClemensLinnhoff Feb 12, 2024
f06e8ad
Change reporter type
ClemensLinnhoff Feb 12, 2024
d202af5
Add test cases
ClemensLinnhoff Feb 12, 2024
a018ef0
Add GitHub token
ClemensLinnhoff Feb 12, 2024
01fbf1d
Try different settings for Linter
ClemensLinnhoff Feb 12, 2024
617b54d
Put linter to separate job and add protolint config
ClemensLinnhoff Feb 12, 2024
01bcdbf
Remove same number test case
ClemensLinnhoff Feb 12, 2024
7f65485
Disable enum suffix rule
ClemensLinnhoff Feb 12, 2024
d52a8c7
Disable message names prepositions
ClemensLinnhoff Feb 12, 2024
21013d9
Remove linter from build job
ClemensLinnhoff Feb 12, 2024
6068864
Merge branch 'master' into 775-use-protobuf-linter-in-ci-pipeline
jdsika Feb 13, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix workflow file 
Signed-off-by: ClemensLinnhoff <clemens.linnhoff@partner.bmw.de>
  • Loading branch information
@ClemensLinnhoff
ClemensLinnhoff committed Feb 12, 2024
commit 5fec88513a982ba5d1a90b88be09592362d9a9ea
8 changes: 4 additions & 4 deletions .github/workflows/protobuf.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,12 +96,12 @@ jobs:
run: python setup.py build && python setup.py sdist

- name: lint-protos:
# Install the `buf` CLI
- uses: bufbuild/buf-setup-action@v1
# Install the `buf` CLI
uses: bufbuild/buf-setup-action@v1
# Lint your Protobuf sources
- uses: bufbuild/buf-lint-action@v1
uses: bufbuild/buf-lint-action@v1
with:
input: .
input: .

- name: Install Python
run: python -m pip install .
Expand Down