Skip to content

Add protobuf linter #776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 16 commits into
base: master
Choose a base branch
from
Draft

Add protobuf linter #776

wants to merge 16 commits into from

Conversation

@ClemensLinnhoff
Copy link
Contributor

@ClemensLinnhoff ClemensLinnhoff commented Feb 12, 2024 •
edited
Loading

Reference to a related issue in the repository

#775

Add a description

  • Add a protobuf linter to check for style violations in PRs
  • Add spell check

Take this checklist as orientation for yourself, if this PR is ready for the Change Control Board:
@ClemensLinnhoff
Add buf-lint action
7af97ec 
Signed-off-by: ClemensLinnhoff <clemens.linnhoff@partner.bmw.de>
@ClemensLinnhoff ClemensLinnhoff linked an issue Feb 12, 2024 that may be closed by this pull request
Use Protobuf linter in CI pipeline #775
Open
ClemensLinnhoff and others added 15 commits February 12, 2024 17:10
@ClemensLinnhoff
Fix workflow file
5fec885 
Signed-off-by: ClemensLinnhoff <clemens.linnhoff@partner.bmw.de>
@ClemensLinnhoff
Fix workflow file
af08dd0 
Signed-off-by: ClemensLinnhoff <clemens.linnhoff@partner.bmw.de>
@ClemensLinnhoff
Move linter
f678347 
Signed-off-by: ClemensLinnhoff <clemens.linnhoff@partner.bmw.de>
@ClemensLinnhoff
Change to reviewdog-action-protolint
0fe23e9 
Signed-off-by: ClemensLinnhoff <clemens.linnhoff@partner.bmw.de>
@ClemensLinnhoff
Test without github_token
5a49c62 
Signed-off-by: ClemensLinnhoff <clemens.linnhoff@partner.bmw.de>
@ClemensLinnhoff
Change reporter type
f06e8ad 
Signed-off-by: ClemensLinnhoff <clemens.linnhoff@partner.bmw.de>
@ClemensLinnhoff
Add test cases
d202af5 
Signed-off-by: ClemensLinnhoff <clemens.linnhoff@partner.bmw.de>
@ClemensLinnhoff
Add GitHub token
a018ef0 
Signed-off-by: ClemensLinnhoff <clemens.linnhoff@partner.bmw.de>
@ClemensLinnhoff
Try different settings for Linter
01fbf1d 
Signed-off-by: ClemensLinnhoff <clemens.linnhoff@partner.bmw.de>
@ClemensLinnhoff
Put linter to separate job and add protolint config
617b54d 
Signed-off-by: ClemensLinnhoff <clemens.linnhoff@partner.bmw.de>
@ClemensLinnhoff
Remove same number test case
01bcdbf 
Signed-off-by: ClemensLinnhoff <clemens.linnhoff@partner.bmw.de>
@ClemensLinnhoff
Disable enum suffix rule
7f65485 
Signed-off-by: ClemensLinnhoff <clemens.linnhoff@partner.bmw.de>
@ClemensLinnhoff
Disable message names prepositions
d52a8c7 
Signed-off-by: ClemensLinnhoff <clemens.linnhoff@partner.bmw.de>
@ClemensLinnhoff
Remove linter from build job
21013d9 
Signed-off-by: ClemensLinnhoff <clemens.linnhoff@partner.bmw.de>
@jdsika
Merge branch 'master' into 775-use-protobuf-linter-in-ci-pipeline
6068864
@jdsika jdsika added this to the V3.7.0 milestone Apr 25, 2024
@jdsika
Copy link
Contributor

jdsika commented Apr 25, 2024

@ClemensLinnhoff what is your status here? Should this be ready for next CCB?
@jdsika jdsika linked an issue Apr 25, 2024 that may be closed by this pull request
OSI violates several Protobuf Style Guide rules #711
Open
@pmai
Copy link
Contributor

pmai commented Apr 26, 2024

OSI 3.7.0 is feature-closed, only review-feedback relevant PRs and/or bugs are in the pipeline for now.
@pmai pmai removed this from the V3.7.0 milestone Apr 26, 2024
@ClemensLinnhoff ClemensLinnhoff added this to the V3.8.0 milestone May 2, 2024
@jdsika jdsika modified the milestones: V3.8.0, V3.7.1 Jul 30, 2024
@pmai pmai self-assigned this Apr 10, 2025
@pmai pmai added the OSIMaintenance Issues to be evaluated in the OSI CCB label Apr 10, 2025
@yash-shah-asam
Copy link
Member

yash-shah-asam commented Apr 10, 2025

@pmai could you please look into it?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OSIMaintenance Issues to be evaluated in the OSI CCB

5 participants

@ClemensLinnhoff @jdsika @pmai @yash-shah-asam