blob: 5bd8d46d108eb617f18ebb0bd3fc4a29db193680 [file] [log] [blame]
Edwin Kempin4fd84c92014-04-30 13:23:15 +02001= Review UI
2
3Reviewing changes is an important task and the Gerrit Web UI provides
4many functionalities to make the review process comfortable and
5efficient. This is a guide through the review UI that explains the
6different functions and UI elements.
7
8[[change-screen]]
9== Change Screen
10
11The change screen shows the details of a single change and provides
12various actions on it.
13
14image::images/user-review-ui-change-screen.png[width=800, link="images/user-review-ui-change-screen.png"]
15
16[[commit-message]]
17=== Commit Message Block
18
19The focus of the change screen is on the commit message since this is
20the most important information about a change. The numeric change ID
21and the change status are displayed right above the commit message.
22
23image::images/user-review-ui-change-screen-commit-message.png[width=800, link="images/user-review-ui-change-screen-commit-message.png"]
24
Edwin Kempinf9b4bc92014-11-05 13:14:57 +010025[[permalink]]
Edwin Kempin4fd84c92014-04-30 13:23:15 +020026The numeric change ID is a link to the change and clicking on it
27refreshes the change screen. By copying the link location you can get
28the permalink of the change.
29
30image::images/user-review-ui-change-screen-permalink.png[width=800, link="images/user-review-ui-change-screen-permalink.png"]
31
Edwin Kempinf9b4bc92014-11-05 13:14:57 +010032[[change-status]]
Edwin Kempin4fd84c92014-04-30 13:23:15 +020033The change status shows the state of the change:
34
Edwin Kempinf9b4bc92014-11-05 13:14:57 +010035- [[needs]]`Needs <label>`:
Edwin Kempin4fd84c92014-04-30 13:23:15 +020036+
37The change is in review and an approval on the shown label is still
38required to make the change submittable.
39
Edwin Kempinf9b4bc92014-11-05 13:14:57 +010040- [[not]]`Not <label>`:
Edwin Kempin4fd84c92014-04-30 13:23:15 +020041+
42The change is in review and a veto vote on the shown label is
43preventing the submit.
44
Edwin Kempinf9b4bc92014-11-05 13:14:57 +010045- [[not-current]]`Not Current`:
Edwin Kempin4fd84c92014-04-30 13:23:15 +020046+
47The currently viewed patch set is outdated.
48+
49Please note that some operations, like voting, are not available on
50outdated patch sets, but only on the current patch set.
51
Edwin Kempinf9b4bc92014-11-05 13:14:57 +010052- [[ready-to-submit]]`Ready to Submit`:
Edwin Kempin4fd84c92014-04-30 13:23:15 +020053+
54The change has all necessary approvals and may be submitted.
55
Edwin Kempinf9b4bc92014-11-05 13:14:57 +010056- [[merged]]`Merged`:
Edwin Kempin4fd84c92014-04-30 13:23:15 +020057+
58The change was successfully merged into the destination branch.
59
Edwin Kempinf9b4bc92014-11-05 13:14:57 +010060- [[abandoned]]`Abandoned`:
Edwin Kempin4fd84c92014-04-30 13:23:15 +020061+
62The change was abandoned.
63
Edwin Kempinf9b4bc92014-11-05 13:14:57 +010064- [[draft]]`Draft`:
Edwin Kempin4fd84c92014-04-30 13:23:15 +020065+
66The change is a draft that is only visible to the change owner, the
67reviewers that were explicitly added to the change, and users who have
68the link:access-control.html#category_view_drafts[View Drafts] global
69capability assigned.
70
71[[commit-info]]
72=== Commit Info Block
73
74The commit info block shows information about the commit of the
75currently viewed patch set.
76
77It displays the author and the committer as links to a list of this
78person's changes that have the same status as the currently viewed
79change.
80
Orgad Shaneh306ed3c2014-07-20 08:58:28 +030081The commit ID, the parent commit(s) and the link:user-changeid.html[Change-Id] are
Edwin Kempin4fd84c92014-04-30 13:23:15 +020082displayed with a copy-to-clipboard icon that allows the ID to be copied
83into the clipboard.
84
Dave Borowitza3d67882015-06-05 15:22:23 -070085If a Git web browser, such as gitweb or Gitiles, is configured, there
Edwin Kempin4fd84c92014-04-30 13:23:15 +020086is also a link to the commit in the Git web browser.
87
88image::images/user-review-ui-change-screen-commit-info.png[width=800, link="images/user-review-ui-change-screen-commit-info.png"]
89
Orgad Shaneh306ed3c2014-07-20 08:58:28 +030090If a merge commit is viewed this is highlighted by an icon.
Edwin Kempinb6c2a3b2014-05-14 10:37:17 +020091
92image::images/user-review-ui-change-screen-commit-info-merge-commit.png[width=800, link="images/user-review-ui-change-screen-commit-info-merge-commit.png"]
93
Edwin Kempinf1a84f92014-04-30 15:37:48 +020094[[change-info]]
95=== Change Info Block
96
97The change info block contains detailed information about the change
98and offers actions on the change.
99
100image::images/user-review-ui-change-screen-change-info.png[width=800, link="images/user-review-ui-change-screen-change-info.png"]
101
Edwin Kempinf9b4bc92014-11-05 13:14:57 +0100102- [[change-owner]]Change Owner:
Edwin Kempinf1a84f92014-04-30 15:37:48 +0200103+
104The owner of the change is displayed as a link to a list of the owner's
105changes that have the same status as the currently viewed change.
106+
107image::images/user-review-ui-change-screen-change-info-owner.png[width=800, link="images/user-review-ui-change-screen-change-info-owner.png"]
108
Edwin Kempinf9b4bc92014-11-05 13:14:57 +0100109- [[reviewers]]Reviewers:
Edwin Kempinf1a84f92014-04-30 15:37:48 +0200110+
111The reviewers of the change are displayed as chip tokens.
112+
113For each reviewer there is a tooltip that shows on which labels the
114reviewer is allowed to vote.
115+
116New reviewers can be added by clicking on the `Add...` button. Typing
117into the pop-up text field activates auto completion of user and group
118names.
119+
Edwin Kempinf9b4bc92014-11-05 13:14:57 +0100120[[remove-reviewer]]
Edwin Kempinf1a84f92014-04-30 15:37:48 +0200121Reviewers can be removed from the change by clicking on the `x` icon
122in the reviewer's chip token. Removing a reviewer also removes the
123current votes of the reviewer. The removal of votes is recorded as a
124message on the change.
125+
126Removing reviewers is protected by permissions:
127
128** Users can always remove themselves.
129** The change owner may remove any zero or positive score.
130** Users with the link:access-control.html#category_remove_reviewer[
131 Remove Reviewer] access right, the branch owner, the project owner
132 and Gerrit administrators may remove anyone.
133
134+
135image::images/user-review-ui-change-screen-change-info-reviewers.png[width=800, link="images/user-review-ui-change-screen-change-info-reviewers.png"]
136
Edwin Kempinf9b4bc92014-11-05 13:14:57 +0100137- [[project-branch-topic]]Project / Branch / Topic:
Edwin Kempinf1a84f92014-04-30 15:37:48 +0200138+
139The name of the project for which the change was done is displayed as a
140link to the link:user-dashboards.html#project-default-dashboard[default
141dashboard] of the project. If no default dashboard is defined, the link
142opens a list of open changes on the project.
143+
144Clicking on the settings icon on the right side navigates to the
145project administration screen.
146+
147The name of the destination branch is displayed as a link to a list
148with all changes on this branch that have the same status as the
149currently viewed change.
150+
151If a topic was assigned to the change it is displayed below the branch.
152By clicking on the edit icon the topic can be set. This requires the
153link:access-control.html#category_edit_topic_name[Edit Topic Name]
154access right. To be able to set a topic on a closed change, the
155`Edit Topic Name` must be assigned with the `force` flag.
156+
157image::images/user-review-ui-change-screen-change-info-project-branch-topic.png[width=800, link="images/user-review-ui-change-screen-change-info-project-branch-topic.png"]
158
Edwin Kempinf9b4bc92014-11-05 13:14:57 +0100159- [[submit-strategy]]Submit Strategy:
Edwin Kempinf1a84f92014-04-30 15:37:48 +0200160+
161The link:project-setup.html#submit_type[submit strategy] that will be
162used to submit the change. The submit strategy is only displayed for
163open changes.
164+
165image::images/user-review-ui-change-screen-change-info-submit-strategy.png[width=800, link="images/user-review-ui-change-screen-change-info-submit-strategy.png"]
166+
167If a change cannot be merged due to path conflicts this is highlighted
168by a bold red `Cannot Merge` label.
169+
170image::images/user-review-ui-change-screen-change-info-cannot-merge.png[width=800, link="images/user-review-ui-change-screen-change-info-cannot-merge.png"]
171
Edwin Kempinf9b4bc92014-11-05 13:14:57 +0100172- [[update-time]]Time of Last Update:
Edwin Kempinf1a84f92014-04-30 15:37:48 +0200173+
174image::images/user-review-ui-change-screen-change-info-last-update.png[width=800, link="images/user-review-ui-change-screen-change-info-last-update.png"]
175
Edwin Kempinf9b4bc92014-11-05 13:14:57 +0100176- [[actions]]Actions:
Edwin Kempinf1a84f92014-04-30 15:37:48 +0200177+
178Depending on the change state and the permissions of the user, different
179actions are available on the change:
180
Edwin Kempinf9b4bc92014-11-05 13:14:57 +0100181** [[submit]]`Submit`:
Edwin Kempinf1a84f92014-04-30 15:37:48 +0200182+
183Submits the change and adds it to the merge queue. If possible the
184change is merged into the destination branch.
185+
David Pursehouse53b1bd02014-05-09 11:18:08 +0900186The `Submit` button is available if the change is submittable and
Edwin Kempinf1a84f92014-04-30 15:37:48 +0200187the link:access-control.html#category_submit[Submit] access right is
188assigned.
Edwin Kempinf1a84f92014-04-30 15:37:48 +0200189
Andrew Bonventre4af9d8c2016-05-26 15:08:32 -0400190** [[revert]]`Revert`:
191+
192Reverts the change via creating a new one.
193+
194The `Revert` button is available if the change has been submitted.
195+
196When the `Revert` button is pressed, a panel will appear to allow
197the user to enter a commit message for the reverting change.
198+
199Once a revert change is created, the original author and any reviewers
200of the original change are added as reviewers and a message is posted
201to the original change linking to the revert.
202
Edwin Kempinf9b4bc92014-11-05 13:14:57 +0100203** [[abandon]]`Abandon`:
Edwin Kempinf1a84f92014-04-30 15:37:48 +0200204+
205Abandons the change.
206+
207The `Abandon` button is only available if the change is open and the
208link:access-control.html#category_abandon[Abandon] access right is
209assigned.
210+
211When a change is abandoned, a panel appears that allows one to type a
212comment message to explain why the change is being abandoned.
213
Edwin Kempinf9b4bc92014-11-05 13:14:57 +0100214** [[restore]]`Restore`:
Edwin Kempinf1a84f92014-04-30 15:37:48 +0200215+
216Restores the change.
217+
218The `Restore` button is only available if the change is abandoned and
219the link:access-control.html#category_abandon[Abandon] and the
220link:access-control.html#category_push[Push] access right is
221assigned.
222+
223When a change is restored, a panel appears that allows one to type a
224comment message to explain why the change is being restored.
225
Edwin Kempinf9b4bc92014-11-05 13:14:57 +0100226** [[rebase]]`Rebase`:
Edwin Kempinf1a84f92014-04-30 15:37:48 +0200227+
228Rebases the change. The rebase is always done with content merge
229enabled. If the rebase is successful a new patch set with the rebased
230commit is created. If the rebase fails, there are conflicts that have
231to be resolved manually.
232+
233If the change does not depend on another open change, it is rebased
234onto the tip of the destination branch.
235+
236If the change depends on another open change, it is rebased onto the
237current patch set of that other change.
238+
Zalan Blenessy366d7852015-03-18 11:40:48 +0100239It is possible to change parent revision of a change. The new parent
240revision can be another change towards the same target branch, or
241the tip of the target branch.
242+
243The `Rebase` button is only available if
Edwin Kempinf1a84f92014-04-30 15:37:48 +0200244the link:access-control.html#category_rebase[Rebase] access right is
245assigned. Rebasing merge commits is not supported.
246
Edwin Kempinf9b4bc92014-11-05 13:14:57 +0100247** [[cherry-pick]]`Cherry-Pick`:
Edwin Kempinf1a84f92014-04-30 15:37:48 +0200248+
249Allows to cherry-pick the change to another branch. The destination
250branch can be selected from a dialog. Cherry-picking a change creates a
251new open change on the selected destination branch.
252+
253It is also possible to cherry-pick a change to the same branch. This is
254effectively the same as rebasing it to the current tip of the
255destination branch. This can be used to remove dependencies on other
256open changes.
257+
258Users can only cherry-pick changes to branches for which they are
259allowed to upload changes for review.
260
Edwin Kempinf9b4bc92014-11-05 13:14:57 +0100261** [[publish]]`Publish`:
Edwin Kempinf1a84f92014-04-30 15:37:48 +0200262+
263Publishes the currently viewed draft patch set. If this is the first
264patch set of a change that is published, the change will be published
265as well.
266+
267The `Publish` button is only available if a draft patch set is viewed
268and the user is the change owner or has the
269link:access-control.html#category_publish_drafts[Publish Drafts] access
270right assigned.
271
Edwin Kempinf9b4bc92014-11-05 13:14:57 +0100272** [[delete]]`Delete Change` / `Delete Revision`:
Edwin Kempinf1a84f92014-04-30 15:37:48 +0200273+
Alice Kober-Sotzek2f48a852017-02-10 14:00:29 +0100274Deletes the change / the currently viewed draft patch set.
Edwin Kempinf1a84f92014-04-30 15:37:48 +0200275+
Alice Kober-Sotzek2f48a852017-02-10 14:00:29 +0100276For normal changes, the `Delete Change` button will only be available if the
277user is an administrator and the change hasn't been merged. For draft changes,
278the `Delete Change` / `Delete Revision` buttons will be available if the user
279is the change owner or has the
280link:access-control.html#category_delete_drafts[Delete Drafts] access right
281assigned.
Edwin Kempinf1a84f92014-04-30 15:37:48 +0200282
Edwin Kempinf9b4bc92014-11-05 13:14:57 +0100283** [[plugin-actions]]Further actions may be available if plugins are installed.
Edwin Kempinf1a84f92014-04-30 15:37:48 +0200284
285+
286image::images/user-review-ui-change-screen-change-info-actions.png[width=800, link="images/user-review-ui-change-screen-change-info-actions.png"]
287
Edwin Kempinf9b4bc92014-11-05 13:14:57 +0100288- [[labels]]Labels & Votes:
Edwin Kempinf1a84f92014-04-30 15:37:48 +0200289+
290Approving votes are colored green; veto votes are colored red.
291+
292image::images/user-review-ui-change-screen-change-info-labels.png[width=800, link="images/user-review-ui-change-screen-change-info-labels.png"]
293
Edwin Kempinab777f12014-05-02 11:47:57 +0200294[[files]]
295=== File List
296
297The file list shows the files that are modified in the currently viewed
298patch set.
299
300image::images/user-review-ui-change-screen-file-list.png[width=800, link="images/user-review-ui-change-screen-file-list.png"]
301
Edwin Kempin8fd96b92016-12-05 16:39:03 +0100302[[magic-files]]
303In addition to the modified files the file list contains magic files
304that are generated by Gerrit and which don't exist in the repository.
305The magic files contain additional commit data that should be
306reviewable and allow users to comment on this data. The magic files are
307always listed first. The following magic files exist:
308
309* `Commit Message`:
310+
311The commit message and headers with the parent commit(s), the author
312information and the committer information.
313
314* `Merge List` (for merge commits only):
315+
316The list of commits that are being integrated into the destination
317branch by submitting the merge commit.
318
Edwin Kempinf9b4bc92014-11-05 13:14:57 +0100319[[change-screen-mark-reviewed]]
Edwin Kempinab777f12014-05-02 11:47:57 +0200320The checkboxes in front of the file names allow files to be marked as reviewed.
321
322image::images/user-review-ui-change-screen-file-list-mark-as-reviewed.png[width=800, link="images/user-review-ui-change-screen-file-list-mark-as-reviewed.png"]
323
Edwin Kempinf9b4bc92014-11-05 13:14:57 +0100324[[modification-type]]
Edwin Kempinab777f12014-05-02 11:47:57 +0200325The type of a file modification is indicated by the character in front
326of the file name:
327
328- 'no character' (Modified):
329+
330The file existed before this change and is modified.
331
332- `A` (Added):
333+
334The file is newly added.
335
336- `D` (Deleted):
337+
338The file is deleted.
339
340- `R` (Renamed):
341+
342The file is renamed.
343
344- `C` (Copied):
345+
346The file is new and is copied from an existing file.
347
348image::images/user-review-ui-change-screen-file-list-modification-type.png[width=800, link="images/user-review-ui-change-screen-file-list-modification-type.png"]
349
Edwin Kempinf9b4bc92014-11-05 13:14:57 +0100350[[rename-or-copy]]
Edwin Kempinab777f12014-05-02 11:47:57 +0200351If a file is renamed or copied, the name of the original file is
352displayed in gray below the file name.
353
354image::images/user-review-ui-change-screen-file-list-rename.png[width=800, link="images/user-review-ui-change-screen-file-list-rename.png"]
355
Edwin Kempinf9b4bc92014-11-05 13:14:57 +0100356[[repeating-path-segments]]
Edwin Kempinab777f12014-05-02 11:47:57 +0200357Repeating path segments are grayed out.
358
359image::images/user-review-ui-change-screen-file-list-repeating-paths.png[width=800, link="images/user-review-ui-change-screen-file-list-repeating-paths.png"]
360
Edwin Kempinf9b4bc92014-11-05 13:14:57 +0100361[[inline-comments-column]]
Edwin Kempinab777f12014-05-02 11:47:57 +0200362Inline comments on a file are shown in the `Comments` column.
363
364Draft comments, i.e. comments that have been written by the current
365user but not yet published, are highlighted in red.
366
367New comments from other users, that were published after the current
368user last reviewed this change, are highlighted in bold.
369
370image::images/user-review-ui-change-screen-file-list-comments.png[width=800, link="images/user-review-ui-change-screen-file-list-comments.png"]
371
Edwin Kempinf9b4bc92014-11-05 13:14:57 +0100372[[size]]
David Pursehouse8bd6f782015-01-30 11:06:38 +0900373The size of the modifications in the files can be seen in the `Size` column. The
374footer row shows the total size of the change.
Edwin Kempinab777f12014-05-02 11:47:57 +0200375
376The size information is useful to easily spot the files that contain
377the most modifications; these files are likely to be the most relevant
378files for this change. The total change size gives an estimate of how
379long a review of this change may take.
380
David Pursehouse8bd6f782015-01-30 11:06:38 +0900381When the "Show Change Sizes As Colored Bars" user preference is enabled, the
382`Size` column shows the sum of inserted and deleted lines as one number. In
383addition, the change size is shown as a bar. The size of the bar indicates the
384amount of changed lines, and its coloring shows the proportion of insertions
385(green) to deletions (red).
386
387When the "Show Change Sizes As Colored Bars" user preference is disabled, the
388colored bar is not shown. For added and renamed files, the `Size` column
389shows the number of inserted and deleted lines. For new files, the column only
390shows the total number of lines in the new file. No size is shown for binary
391files and deleted files.
392
Edwin Kempinab777f12014-05-02 11:47:57 +0200393image::images/user-review-ui-change-screen-file-list-size.png[width=800, link="images/user-review-ui-change-screen-file-list-size.png"]
394
Edwin Kempinf9b4bc92014-11-05 13:14:57 +0100395[[diff-against]]
Edwin Kempinab777f12014-05-02 11:47:57 +0200396In the header of the file list, the `Diff Against` selection can be
397changed. This selection allows one to choose if the currently viewed
398patch set should be compared against its base or against another patch
399set of this change. The file list is updated accordingly.
400
Edwin Kempinf9b4bc92014-11-05 13:14:57 +0100401[[open-all]]
Edwin Kempinab777f12014-05-02 11:47:57 +0200402The file list header also provides an `Open All` button that opens the
403diff views for all files in the file list.
404
405image::images/user-review-ui-change-screen-file-list-header.png[width=800, link="images/user-review-ui-change-screen-file-list-header.png"]
406
Edwin Kempinb2a8ae32014-05-02 15:03:22 +0200407[[patch-sets]]
408=== Patch Sets
409
410The change screen only presents one patch set at a time. Which patch
411set is currently viewed can be seen from the `Patch Sets` drop-down
412panel in the change header. It shows the number of the currently viewed
413patch set and the total number of patch sets, in the form: "current
414patch set/number of patch sets".
415
416If a non-current patch set is viewed this is indicated by the
417link:#not-current[Not Current] change state. Please note that some
418operations are only available on the current patch set.
419
420image::images/user-review-ui-change-screen-patch-sets.png[width=800, link="images/user-review-ui-change-screen-patch-sets.png"]
421
Orgad Shanehce43e0f2014-09-03 22:53:44 +0300422Another indication is a highlighted drop-down label.
423
424image::images/user-review-ui-change-screen-not-current.png[width=800, link="images/user-review-ui-change-screen-not-current.png"]
425
Edwin Kempinf9b4bc92014-11-05 13:14:57 +0100426[[patch-set-drop-down]]
Edwin Kempinb2a8ae32014-05-02 15:03:22 +0200427The patch set drop-down list shows the list of patch sets and allows to
428switch between them. The patch sets are sorted in descending order so
429that the current patch set is always on top.
430
Edwin Kempinb2a8ae32014-05-02 15:03:22 +0200431Draft patch sets are marked with `DRAFT`.
432
433image::images/user-review-ui-change-screen-patch-set-list.png[width=800, link="images/user-review-ui-change-screen-patch-set-list.png"]
434
Edwin Kempin0cb1ccb2014-05-05 13:22:03 +0200435[[download]]
436=== Download
437
438The `Download` drop-down panel in the change header offers commands and
439links for downloading the currently viewed patch set.
440
441image::images/user-review-ui-change-screen-download-commands.png[width=800, link="images/user-review-ui-change-screen-download-commands.png"]
442
443The available download commands depend on the installed Gerrit plugins.
444The most popular plugin for download commands, the
445link:https://gerrit-review.googlesource.com/#/admin/projects/plugins/download-commands[
446download-commands] plugin, provides commands to checkout, pull and
447cherry-pick a patch set.
448
449Each command has a copy-to-clipboard icon that allows the command to be
450copied into the clipboard. This makes it easy to paste and execute the
451command on a Git command line.
452
453If several download schemes are configured on the server (e.g. SSH and
454HTTP) there is a drop-down list to switch between the download schemes.
455Gerrit automatically remembers the download scheme that was last chosen
456and selects this download scheme the next time the download commands
457drop-down panel is opened.
458
459The `Patch-File` links provide the Git patch file for the currently
460viewed patch set for download. The patch file can be base64 encoded or
461zipped.
462
463The `Archive` links allow one to download an archive with the contents
464of the currently viewed patch set. The archive is offered in several
465formats (e.g. tar and tbz2); which formats are available depends on the
466configuration of the server.
467
468image::images/user-review-ui-change-screen-download-commands-list.png[width=800, link="images/user-review-ui-change-screen-download-commands-list.png"]
469
Edwin Kempin811bd582014-05-05 13:39:24 +0200470[[included-in]]
471=== Included In
472
473For merged changes the `Included In` drop-down panel is available in
474the change header.
475
476image::images/user-review-ui-change-screen-included-in.png[width=800, link="images/user-review-ui-change-screen-included-in.png"]
477
478The `Included In` drop-down panel shows the branches and tags in which
479the change is included. E.g. if a change fixes a bug, this allows to
480quickly see in which released versions the bug-fix is contained
481(assuming that every release is tagged).
482
483image::images/user-review-ui-change-screen-included-in-list.png[width=800, link="images/user-review-ui-change-screen-included-in-list.png"]
484
Edwin Kempin981cc952014-05-05 14:04:08 +0200485[[star]]
486=== Star Change
487
488The star icon in the change header allows to mark the change as a
489favorite. Clicking on the star icon again, unstars the change.
490
491image::images/user-review-ui-change-screen-star.png[width=800, link="images/user-review-ui-change-screen-star.png"]
492
493Starring a change turns on email notifications for this change.
494
495Starred changed are listed under `My` > `Starred Changes`.
496and can be queried by the link:user-search.html#is[is:starred] search
497operator.
498
Edwin Kempin8ab5b532014-05-05 17:10:31 +0200499[[related-changes]]
500=== Related Changes
501
502If there are changes that are related to the currently viewed change
503they are displayed in the third column of the change screen.
504
505There are several lists of related changes and a tab control is used to
506display each list of related changes in its own tab.
507
508The following tabs may be displayed:
509
Edwin Kempinf9b4bc92014-11-05 13:14:57 +0100510- [[related-changes-tab]]`Related Changes`:
Edwin Kempin8ab5b532014-05-05 17:10:31 +0200511+
512This tab page shows changes on which the current change depends
513(ancestors) and open changes that depend on the current change
514(descendants). For merge commits it also shows the closed changes that
515will be merged into the destination branch by submitting the merge
516commit.
517+
518The changes are sorted in the same way as the output of 'git log'. This
519means the relationship between the changes can be inferred from the
520position of the changes in the list. Changes listed above the current
521change are descendants; changes below the current change are ancestors.
522+
Edwin Kempin68cfe472014-05-12 15:10:25 +0200523For merged changes this tab is only shown if there are open
524descendants.
Edwin Kempin8ab5b532014-05-05 17:10:31 +0200525+
526image::images/user-review-ui-change-screen-related-changes.png[width=800, link="images/user-review-ui-change-screen-related-changes.png"]
527+
528Related changes may be decorated with an icon to signify dependencies
529on outdated patch sets, or commits that are not associated to changes
530under review:
531+
Edwin Kempinf9b4bc92014-11-05 13:14:57 +0100532** [[outdated]]Orange Dot:
Edwin Kempin8ab5b532014-05-05 17:10:31 +0200533+
534The selected patch set of the change is outdated; it is not the current
535patch set of the change.
536+
537If an ancestor change is marked with an orange dot it means that the
538currently viewed patch set depends on a outdated patch set of the
539ancestor change. This is because a new patch set for the ancestor
540change was uploaded in the meantime and as result the currently viewed
541patch set now needs to be rebased.
542+
543If a descendant change is marked with an orange dot it means that an
544old patch set of the descendant change depends on the currently viewed
545patch set. It may be that the descendant was rebased in the meantime
546and with the new patch set this dependency was removed.
547
Edwin Kempinf9b4bc92014-11-05 13:14:57 +0100548** [[indirect-descendant]]Green Tilde:
Edwin Kempin8ab5b532014-05-05 17:10:31 +0200549+
550The selected patch set of the change is an indirect descendant of the
551currently viewed patch set; it has a dependency to another patch set of
552this change. E.g. this could mean that a new patch set was uploaded for
553this change and the descendant change now needs to be rebased. Please
554note that following the link to an indirect descendant change may
555result in a completely different related changes listing.
556
Dave Borowitzbbaea3f2015-03-13 13:56:41 -0700557** [[closed-ancestor]]Black Dot:
Edwin Kempin8ab5b532014-05-05 17:10:31 +0200558+
Stefan Beller7e23cd02015-06-18 11:40:18 -0700559Indicates a closed ancestor, e.g. the commit was directly pushed into
Edwin Kempin8ab5b532014-05-05 17:10:31 +0200560the repository bypassing code review, or the ancestor change was
561reviewed and submitted on another branch. The latter may indicate that
562the user has accidentally pushed the commit to the wrong branch, e.g.
563the commit was done on `branch-a`, but was then pushed to
564`refs/for/branch-b`.
Stefan Beller7e23cd02015-06-18 11:40:18 -0700565A black dot is also present if the change was abandoned.
Edwin Kempin8ab5b532014-05-05 17:10:31 +0200566
Stefan Beller03d67902015-06-18 15:52:24 -0700567** [[closed-ancestor-abandoned]]Strikethrough Subject:
568+
569When the commit is abandoned, its subject line will be striked
570through.
571
Edwin Kempin8ab5b532014-05-05 17:10:31 +0200572+
573image::images/user-review-ui-change-screen-related-changes-indicators.png[width=800, link="images/user-review-ui-change-screen-related-changes-indicators.png"]
574
Edwin Kempinf9b4bc92014-11-05 13:14:57 +0100575- [[conflicts-with]]`Conflicts With`:
Edwin Kempin8ab5b532014-05-05 17:10:31 +0200576+
577This tab page shows changes that conflict with the current change.
578Non-mergeable changes are filtered out; only conflicting changes that
579are mergeable are shown.
580+
581If this change is merged, its conflicting changes will have merge
582conflicts and must be rebased. The rebase of the other changes with the
583conflict resolution must then be done manually.
584+
585image::images/user-review-ui-change-screen-conflicts-with.png[width=800, link="images/user-review-ui-change-screen-conflicts-with.png"]
586
Edwin Kempinf9b4bc92014-11-05 13:14:57 +0100587- [[same-topic]]`Same Topic`:
Edwin Kempin8ab5b532014-05-05 17:10:31 +0200588+
589This tab page shows changes that have the same topic as the current
590change. Only open changes are included in the list.
591+
592image::images/user-review-ui-change-screen-same-topic.png[width=800, link="images/user-review-ui-change-screen-same-topic.png"]
593
Stefan Beller09feaac2015-06-29 16:20:10 -0700594- [[submitted-together]]`Submitted Together`:
595+
596This tab page shows changes that will be submitted together with the
597currently viewed change, when clicking the submit button. It includes
598ancestors of the current patch set.
599+
600This may include changes and its ancestors with the same topic if
601`change.submitWholeTopic` is enabled. Only open changes with the
602same topic are included in the list.
603+
604
Edwin Kempinf9b4bc92014-11-05 13:14:57 +0100605- [[cherry-picks]]`Cherry-Picks`:
Edwin Kempin8ab5b532014-05-05 17:10:31 +0200606+
607This tab page shows changes with the same link:user-changeid.html[
608Change-Id] for the current project.
609+
610Abandoned changes are filtered out.
611+
612For each change in this list the destination branch is shown as a
613prefix in front of the change subject.
614+
615image::images/user-review-ui-change-screen-cherry-picks.png[width=800, link="images/user-review-ui-change-screen-cherry-picks.png"]
616
617If there are no related changes for a tab, the tab is not displayed.
618
Edwin Kempinc6cab612014-05-06 11:09:05 +0200619[[reply]]
620=== Reply
621
622The `Reply...` button in the change header allows to reply to the
623currently viewed patch set; one can add a summary comment, publish
624inline draft comments, and vote on the labels.
625
626image::images/user-review-ui-change-screen-reply.png[width=800, link="images/user-review-ui-change-screen-reply.png"]
627
628Clicking on the `Reply...` button opens a popup panel.
629
Sebastian Schuberth027c4352016-02-02 09:24:29 +0100630[[summary-comment]]
Edwin Kempinc6cab612014-05-06 11:09:05 +0200631A text box allows to type a summary comment for the currently viewed
Sebastian Schuberth027c4352016-02-02 09:24:29 +0100632patch set. Some basic markdown-like syntax is supported which renders
633indented lines preformatted, lines starting with "- " or "* " as list
634items, and lines starting with "> " as block quotes (also see replying to
635link:#reply-to-message[messages] and link:#reply-inline-comment[inline comments]).
Edwin Kempinc6cab612014-05-06 11:09:05 +0200636
Richard Möhne4abe9a2014-11-13 20:05:13 +0100637Note that you can set the text and tooltip of the button in
638link:config-gerrit.html#change.replyLabel[gerrit.config].
639
Edwin Kempinf9b4bc92014-11-05 13:14:57 +0100640[[vote]]
Edwin Kempinc6cab612014-05-06 11:09:05 +0200641If the current patch set is viewed, radio buttons are displayed for
642each label on which the user is allowed to vote. Voting on non-current
643patch sets is not possible.
644
Edwin Kempinc6cab612014-05-06 11:09:05 +0200645The inline draft comments that will be published are displayed in a
646separate section so that they can be reviewed before publishing. There
647are links to navigate to the inline comments which can be used if a
648comment needs to be edited.
649
650The `Post` button publishes the comments and the votes.
651
Edwin Kempinc6cab612014-05-06 11:09:05 +0200652image::images/user-review-ui-change-screen-replying.png[width=800, link="images/user-review-ui-change-screen-replying.png"]
653
Edwin Kempinf9b4bc92014-11-05 13:14:57 +0100654[[quick-approve]]
Edwin Kempinc6cab612014-05-06 11:09:05 +0200655If a user can approve a label that is still required, a quick approve
656button appears in the change header that allows to add this missing
657approval by a single click. The quick approve button only appears if
658there is a single label that is still required and can be approved by
659the user.
660
661E.g. if a change requires approvals on the 'Code-Review' and the
662'Verified' labels, and there is already a '+1 Verified' vote, then
663if the user is allowed to vote the max score on 'Code-Review', a
664`Code-Review+2` quick approve button appears that approves the
665'Code-Review' label if clicked.
666
667Using the quick approve button also publishes all inline draft
668comments; a summary comment is only added if the reply popup panel is
669open when the quick approve button is clicked.
670
671image::images/user-review-ui-change-screen-quick-approve.png[width=800, link="images/user-review-ui-change-screen-quick-approve.png"]
672
Edwin Kempin7a682812014-05-06 14:45:01 +0200673[[history]]
674=== History
675
676The history of the change can be seen in the lower part of the screen.
677
678The history contains messages for all kinds of change updates, e.g. a
679message is added when a new patch set is uploaded or when a review was
680done.
681
682Messages with new comments from other users, that were published after
683the current user last reviewed this change, are automatically expanded.
684
685image::images/user-review-ui-change-screen-history.png[width=800, link="images/user-review-ui-change-screen-history.png"]
686
Edwin Kempinf9b4bc92014-11-05 13:14:57 +0100687[[reply-to-message]]
Edwin Kempin7a682812014-05-06 14:45:01 +0200688It is possible to directly reply to a change message by clicking on the
689reply icon in the right upper corner of a change message. This opens
690the reply popup panel and prefills the text box with the quoted comment.
691Then the reply can be written below the quoted comment or inserted
Sebastian Schuberth027c4352016-02-02 09:24:29 +0100692inline. Lines starting with "> " will be rendered as a block quote.
Edwin Kempin7a682812014-05-06 14:45:01 +0200693Please note that for a correct rendering it is important to leave a blank
694line between a quoted block and the reply to it.
695
696image::images/user-review-ui-change-screen-reply-to-comment.png[width=800, link="images/user-review-ui-change-screen-reply-to-comment.png"]
697
Edwin Kempinf9b4bc92014-11-05 13:14:57 +0100698[[inline-comments-in-history]]
Edwin Kempin7a682812014-05-06 14:45:01 +0200699Inline comments are directly displayed in the change history and there
700are links to navigate to the inline comments.
701
702image::images/user-review-ui-change-screen-inline-comments.png[width=800, link="images/user-review-ui-change-screen-inline-comments.png"]
703
Edwin Kempinf9b4bc92014-11-05 13:14:57 +0100704[[expand-all]]
Edwin Kempin7a682812014-05-06 14:45:01 +0200705The `Expand All` button expands all messages; the `Collapse All` button
706collapses all messages.
707
Edwin Kempin772418f2014-05-06 15:45:35 +0200708[[update-notification]]
709=== Update Notification
710
711The change screen automatically polls for updates to the currently
712viewed change. If there is an update the user is informed by a popup
713panel in the bottom right corner.
714
715The polling frequency depends on the server configuration; by default
716it is 30 seconds. Polling may also be completely disabled by the
717administrator.
718
719image::images/user-review-ui-change-screen-change-update.png[width=800, link="images/user-review-ui-change-screen-change-update.png"]
720
Edwin Kempin41d9d302014-05-06 16:02:06 +0200721[[plugin-extensions]]
722=== Plugin Extensions
723
724Gerrit plugins may extend the change screen; they can add buttons for
725additional actions to the change info block and display arbitrary UI
726controls below the change info block.
727
728image::images/user-review-ui-change-screen-plugin-extensions.png[width=800, link="images/user-review-ui-change-screen-plugin-extensions.png"]
729
Edwin Kempind38ddf52014-05-07 14:31:42 +0200730[[side-by-side]]
731== Side-by-Side Diff Screen
732
733The side-by-side diff screen shows a single patch; the old file version
734is displayed on the left side of the screen; the new file version is
735displayed on the right side of the screen.
736
737This screen allows to review a patch and to comment on it.
738
739image::images/user-review-ui-side-by-side-diff-screen.png[width=800, link="images/user-review-ui-side-by-side-diff-screen.png"]
740
Edwin Kempinf9b4bc92014-11-05 13:14:57 +0100741[[side-by-side-header]]
Edwin Kempind38ddf52014-05-07 14:31:42 +0200742In the screen header the project name and the name of the viewed patch
743file are shown.
744
745If a Git web browser is configured on the server, the project name and
746the file path are displayed as links to the project and the folder in
747the Git web browser.
748
749image::images/user-review-ui-side-by-side-diff-screen-project-and-file.png[width=800, link="images/user-review-ui-side-by-side-diff-screen-project-and-file.png"]
750
Edwin Kempinf9b4bc92014-11-05 13:14:57 +0100751[[side-by-side-mark-reviewed]]
Edwin Kempind38ddf52014-05-07 14:31:42 +0200752The checkbox in front of the project name and the file name allows the
Edwin Kempinfe8ca4c2014-05-08 16:49:15 +0200753patch to be marked as reviewed. The link:#mark-reviewed[Mark Reviewed]
754diff preference allows to control whether the files should be
755automatically marked as reviewed when they are viewed.
Edwin Kempind38ddf52014-05-07 14:31:42 +0200756
757image::images/user-review-ui-side-by-side-diff-screen-reviewed.png[width=800, link="images/user-review-ui-side-by-side-diff-screen-reviewed.png"]
758
Edwin Kempinf9b4bc92014-11-05 13:14:57 +0100759[[scrollbar]]
Edwin Kempind38ddf52014-05-07 14:31:42 +0200760The scrollbar shows patch diffs and inline comments as annotations.
761This provides a good overview of the lines in the patch that are
762relevant for reviewing. By clicking on an annotation one can quickly
763navigate to the corresponding line in the patch.
764
765image::images/user-review-ui-side-by-side-diff-screen-scrollbar.png[width=800, link="images/user-review-ui-side-by-side-diff-screen-scrollbar.png"]
766
Edwin Kempinf9b4bc92014-11-05 13:14:57 +0100767[[gaps]]
Edwin Kempin1266ac8f2014-05-09 09:39:31 +0200768A gap between lines in the file content that is caused by aligning the
769left and right side or by displaying inline comments is shown as a
770vertical red bar in the line number column. This prevents a gap from
771being mistaken for blank lines in the file
772
773image::images/user-review-ui-side-by-side-diff-screen-red-bar.png[width=800, link="images/user-review-ui-side-by-side-diff-screen-red-bar.png"]
774
Edwin Kempind8057e52014-05-08 13:52:32 +0200775[[patch-set-selection]]
776In the header, on each side, the list of patch sets is shown. Clicking
777on a patch set changes the selection for the patch set comparison and
778the screen is refreshed to show the diff between the selected patch
779sets. The currently selected patch set is highlighted by a light blue
780background.
781
782On the left side `Base` can be selected to compare a patch set against
783its base. For merge commits `Auto Merge` is available instead which
784allows to compare the patch against the result of the auto merge. The
785auto merge version may contain Git conflict markers and is useful for
786reviewing how conflicts are resolved by a patch.
787
788Reviewers that are reviewing a patch for the first time look at its
789diff against its base; reviewers that have reviewed an old patch
790version before, may see what has changed since that version by
791comparing the old patch against the current patch.
792
793image::images/user-review-ui-side-by-side-diff-screen-patch-sets.png[width=800, link="images/user-review-ui-side-by-side-diff-screen-patch-sets.png"]
794
Edwin Kempinf9b4bc92014-11-05 13:14:57 +0100795[[download-file]]
Edwin Kempin6db9bcd2014-06-06 09:32:05 +0200796The download icon next to the patch set list allows to download the
797patch. Unless the mime type of the file is configured as safe, the
798download file is a zip archive that contains the patch file.
799
Edwin Kempinf9b4bc92014-11-05 13:14:57 +0100800[[no-differences]]
Edwin Kempin01280cc2014-05-09 09:53:30 +0200801If the compared patches are identical, this is highlighted by a red
802`No Differences` label in the screen header.
803
804image::images/user-review-ui-side-by-side-diff-screen-no-differences.png[width=800, link="images/user-review-ui-side-by-side-diff-screen-no-differences.png"]
805
Edwin Kempinf9b4bc92014-11-05 13:14:57 +0100806[[side-by-side-rename]]
Edwin Kempinafb4fcc2014-06-06 09:52:52 +0200807If a file was renamed, the old and new file paths are shown in the
808header together with a similarity index that shows how much of the file
809content is unmodified.
810
811image::images/user-review-ui-side-by-side-diff-screen-rename.png[width=800, link="images/user-review-ui-side-by-side-diff-screen-rename.png"]
Edwin Kempind8057e52014-05-08 13:52:32 +0200812
Edwin Kempinf9b4bc92014-11-05 13:14:57 +0100813[[navigation]]
Edwin Kempind37a1342014-05-08 14:02:35 +0200814For navigating between the patches in a patch set there are navigation
815buttons on the right side of the screen header. The left arrow button
816navigates to the previous patch; the right arrow button navigates to
817the next patch. The arrow up button leads back to the change screen. In
818all cases the selection for the patch set comparison is kept.
819
820image::images/user-review-ui-side-by-side-diff-screen-navigation.png[width=800, link="images/user-review-ui-side-by-side-diff-screen-navigation.png"]
821
Edwin Kempin004c3472014-05-07 16:56:59 +0200822[[inline-comments]]
823=== Inline Comments
824
825Inline comments are displayed directly in the patch file under the code
826that is commented. Inline comments can be placed on lines or on code
827blocks.
828
829If an inline comment relates to a code block, this code block is
830highlighted by a yellow background.
831
832Code blocks with comments may overlap. This means it is possible to
833attach several comments to the same code.
834
Edwin Kempinf9b4bc92014-11-05 13:14:57 +0100835[[line-links]]
Edwin Kempin004c3472014-05-07 16:56:59 +0200836The lines of the patch file are linkable. To link to a certain line in
837the patch file, '@<line-number>' must be appended to the patch link,
838e.g. `http://host:8080/#/c/56857/2/Documentation/user-review-ui.txt@665`.
839To link to a line in the old file version, '@a<line-number>' must be
840appended to the patch link. These links can be used to directly link to
841certain inline comments.
842
Edwin Kempinfe8ca4c2014-05-08 16:49:15 +0200843If the diff preference link:#expand-all-comments[Expand All Comments]
844is set to `Expand`, all inline comments will be automatically expanded.
Edwin Kempin004c3472014-05-07 16:56:59 +0200845
846image::images/user-review-ui-side-by-side-diff-screen-inline-comments.png[width=800, link="images/user-review-ui-side-by-side-diff-screen-inline-comments.png"]
847
Edwin Kempinf9b4bc92014-11-05 13:14:57 +0100848[[comment]]
Edwin Kempin004c3472014-05-07 16:56:59 +0200849In the header of the comment box, the name of the comment author and
850the timestamp of the comment are shown. If avatars are configured on
851the server, the avatar image of the comment author is displayed in the
852top left corner. Below the actual comment there are buttons to reply to
853the comment.
854
855image::images/user-review-ui-side-by-side-diff-screen-comment-box.png[width=800, link="images/user-review-ui-side-by-side-diff-screen-comment-box.png"]
856
Edwin Kempinf9b4bc92014-11-05 13:14:57 +0100857[[reply-inline-comment]]
Edwin Kempin004c3472014-05-07 16:56:59 +0200858Clicking on the `Reply` button opens an editor to type the reply.
859
860Quoting is supported, but only by manually copying & pasting the old
Sebastian Schuberth027c4352016-02-02 09:24:29 +0100861comment that should be quoted and prefixing every line by "> ". Please
Edwin Kempin004c3472014-05-07 16:56:59 +0200862note that for a correct rendering it is important to leave a blank line
863between a quoted block and the reply to it.
864
865Clicking on the `Save` button saves the comment as a draft. To make it
866visible to other users it must be published from the change screen by
867link:#reply[replying] to the change.
868
869The `Cancel` button cancels the editing and discards any changes to the
870draft comment.
871
872Clicking on the `Discard` button deletes the inline draft comment.
873
874image::images/user-review-ui-side-by-side-diff-screen-comment-reply.png[width=800, link="images/user-review-ui-side-by-side-diff-screen-comment-reply.png"]
875
Edwin Kempinf9b4bc92014-11-05 13:14:57 +0100876[[draft-inline-comment]]
Edwin Kempin004c3472014-05-07 16:56:59 +0200877Draft comments are marked by the text "Draft" in the header in the
878place of the comment author.
879
880A draft comment can be edited by clicking on the `Edit` button, or
881deleted by clicking on the `Discard` button.
882
883image::images/user-review-ui-side-by-side-diff-screen-comment-edit.png[width=800, link="images/user-review-ui-side-by-side-diff-screen-comment-edit.png"]
884
Edwin Kempinf9b4bc92014-11-05 13:14:57 +0100885[[done]]
Edwin Kempin004c3472014-05-07 16:56:59 +0200886Clicking on the `Done` button is a quick way to reply with "Done" to a
887comment. This is used to mark a comment as addressed by a follow-up
888patch set.
889
Edwin Kempin44606652014-05-09 08:31:05 +0200890image::images/user-review-ui-side-by-side-diff-screen-replied-done.png[width=800, link="images/user-review-ui-side-by-side-diff-screen-replied-done.png"]
Edwin Kempin004c3472014-05-07 16:56:59 +0200891
892[[add-inline-comment]]
893To add a new inline comment there are several possibilities:
894
895- select a code block and press 'c'
896- select a code block and click on the popup comment icon
Edwin Kempin7feeb952014-05-09 11:16:56 +0200897- go to a line, by clicking on it or by link:#key-navigation[key
898 navigation], and press 'c'
Edwin Kempin004c3472014-05-07 16:56:59 +0200899- click on a line number
900
901There are many ways to select code for commenting on it. The most
902frequently used methods are:
903
904- by mouse:
905** click and drag with the mouse to select a block
906** double-click on a word to select it
907** double-click and drag with the mouse to select a code block word-wise
908** triple-click on a line to select it
909** triple-click and drag with the mouse to select a code block line-wise
910
911- by keys (the same keys that are used for visual selection in Vim):
912** press 'v' + arrow keys (or 'h', 'j', 'k', 'l') to select a block
913** press 'V' + arrow keys (or 'j', 'k') to select a code block line-wise
914** type 'bvw' to select a word
915
Edwin Kempin004c3472014-05-07 16:56:59 +0200916image::images/user-review-ui-side-by-side-diff-screen-comment.png[width=800, link="images/user-review-ui-side-by-side-diff-screen-comment.png"]
917
918For typing the new comment, a new comment box is shown under the code
919that is commented.
920
921Clicking on the `Save` button saves the new comment as a draft. To make
922it visible to other users it must be published from the change screen
923by link:#reply[replying] to the change.
924
925Clicking on the `Discard` button deletes the new comment.
926
927image::images/user-review-ui-side-by-side-diff-screen-commented.png[width=800, link="images/user-review-ui-side-by-side-diff-screen-commented.png"]
928
Edwin Kempin9df27ac2014-05-08 13:06:18 +0200929[[file-level-comments]]
930=== File Level Comments
931
932Comments that apply to a whole file can be added on file level.
933
934File level comments are added by clicking on the comment icon in the
935header above the file.
936
937image::images/user-review-ui-side-by-side-diff-screen-file-level-comment.png[width=800, link="images/user-review-ui-side-by-side-diff-screen-file-level-comment.png"]
938
939Clicking on the comment icon opens a comment box for typing the file
940level comment.
941
942image::images/user-review-ui-side-by-side-diff-screen-file-level-commented.png[width=800, link="images/user-review-ui-side-by-side-diff-screen-file-level-commented.png"]
943
Edwin Kempin6113a1f2014-05-09 10:48:34 +0200944[[search]]
945=== Search
946
947For searching within a patch file, a Vim-like search is supported.
948Typing `/` opens the search box. Typing in the search box immediately
949highlights matches in the patch file with a yellow background. Using
950JavaScript regular expressions in the search term is supported. The
951search is case insensitive. After confirming the search by `ENTER` one
952can navigate between the matches by `n` / `N` to go to the next /
953previous match. Skipped lines are automatically expanded if they
954contain a match and one navigates to it.
955
956For additional possibilities to search please check the
957link:http://www.vim.org/docs.php[Vim documentation]. There are other
958useful ways to search, e.g. while the cursor is on a word, pressing `*`
959or `#` searches for the next or previous occurrence of the word.
960
961Searching by `Ctrl-F` finds matches only in the visible area of the
962screen unless the link:#render[Render] diff preference is set to `Slow`.
963
964image::images/user-review-ui-side-by-side-diff-screen-search.png[width=800, link="images/user-review-ui-side-by-side-diff-screen-search.png"]
965
Edwin Kempin7feeb952014-05-09 11:16:56 +0200966[[key-navigation]]
967=== Key Navigation
968
969Vim-like commands can be used to navigate within a patch file:
970
971- `h` / `j` / `k` / `l` moves the cursor left / down / up / right
972- `0` / `$` moves the cursor to the start / end of the line
973- `gg` / `G` moves to cursor to the start / end of the file
974- `Ctrl-D` / `Ctrl-U` scolls downwards / upwards
975
976Please check the link:http://www.vim.org/docs.php[Vim documentation]
977for further information.
978
Edwin Kempinfe8ca4c2014-05-08 16:49:15 +0200979[[diff-preferences]]
980=== Diff Preferences
981
982There are several options to control how patch diffs should be
983rendered. Users can configure their preferences in the diff
984preferences. The diff preferences can be accessed by clicking on the
985settings icon in the screen header.
986
987image::images/user-review-ui-side-by-side-diff-screen-preferences.png[width=800, link="images/user-review-ui-side-by-side-diff-screen-preferences.png"]
988
989The diff preferences popup allows to change the diff preferences.
990By clicking on the `Save` button changes to the diff preferences are
991saved permanently. Clicking on the `Apply` button applies the new
992diff preferences to the current screen, but they are discarded when the
993screen is refreshed. The `Save` button is only available if the user is
994signed in.
995
996image::images/user-review-ui-side-by-side-diff-screen-preferences-popup.png[width=800, link="images/user-review-ui-side-by-side-diff-screen-preferences-popup.png"]
997
998The following diff preferences can be configured:
999
Edwin Kempinf9b4bc92014-11-05 13:14:57 +01001000- [[theme]]`Theme`:
Edwin Kempinfe8ca4c2014-05-08 16:49:15 +02001001+
1002Controls the theme that is used to render the file content.
1003+
1004E.g. users could choose to work with a dark theme.
1005+
1006image::images/user-review-ui-side-by-side-diff-screen-dark-theme.png[width=800, link="images/user-review-ui-side-by-side-diff-screen-dark-theme.png"]
1007
Edwin Kempinf9b4bc92014-11-05 13:14:57 +01001008- [[ignore-whitespace]]`Ignore Whitespace`:
Edwin Kempinfe8ca4c2014-05-08 16:49:15 +02001009+
1010Controls whether differences in whitespace should be ignored or not.
1011+
1012** `None`:
1013+
1014All differences in whitespace are highlighted.
1015+
1016** `At Line End`:
1017+
1018Whitespace differences at the end of lines are ignored.
1019+
1020** `Leading, At Line End`:
1021+
1022Whitespace differences at the beginning and end of lines are ignored.
1023+
1024** `All`:
1025+
1026All differences in whitespace are ignored.
1027
Edwin Kempinf9b4bc92014-11-05 13:14:57 +01001028- [[tab-width]]`Tab Width`:
Edwin Kempinfe8ca4c2014-05-08 16:49:15 +02001029+
1030Controls how many spaces should be displayed for a tab.
1031
Edwin Kempinf9b4bc92014-11-05 13:14:57 +01001032- [[columns]]`Columns`:
Edwin Kempinfe8ca4c2014-05-08 16:49:15 +02001033+
1034Sets the preferred line length. At this position a vertical dashed line
1035is displayed so that one can easily detect lines the exceed the
1036preferred line length.
1037+
1038image::images/user-review-ui-side-by-side-diff-screen-column.png[width=800, link="images/user-review-ui-side-by-side-diff-screen-column.png"]
1039
Edwin Kempinf9b4bc92014-11-05 13:14:57 +01001040- [[lines-of-context]]`Lines Of Context`:
Edwin Kempinfe8ca4c2014-05-08 16:49:15 +02001041+
1042The number of context lines that should be displayed before and after
1043any diff. If the `entire file` checkbox is selected, the full file is
1044rendered.
1045+
1046Skipped common lines can be expanded by clicking on the placeholder for
1047the skipped lines.
1048+
1049Clicking on "... skipped <n> common lines ..." expands the complete
1050block of skipped lines.
1051+
1052If many lines are skipped there are additional links to expand the
1053context by ten lines before and after the skipped block.
1054+
1055image::images/user-review-ui-side-by-side-diff-screen-expand-skipped-lines.png[width=800, link="images/user-review-ui-side-by-side-diff-screen-expand-skipped-lines.png"]
1056
Edwin Kempinf9b4bc92014-11-05 13:14:57 +01001057- [[intraline-difference]]`Intraline Difference`:
Edwin Kempinfe8ca4c2014-05-08 16:49:15 +02001058+
1059Controls whether intraline differences should be highlighted.
1060+
1061image::images/user-review-ui-side-by-side-diff-screen-intraline-difference.png[width=800, link="images/user-review-ui-side-by-side-diff-screen-intraline-difference.png"]
1062
Edwin Kempinf9b4bc92014-11-05 13:14:57 +01001063- [[syntax-highlighting]]`Syntax Highlighting`:
Edwin Kempinfe8ca4c2014-05-08 16:49:15 +02001064+
1065Controls whether syntax highlighting should be enabled.
1066+
1067The language for the syntax highlighting is automatically detected from
Edwin Kempin637db5e2014-05-12 08:25:26 +02001068the file extension. The language can also be set manually by selecting
1069it from the `Language` drop-down list.
Edwin Kempinfe8ca4c2014-05-08 16:49:15 +02001070+
1071image::images/user-review-ui-side-by-side-diff-screen-syntax-coloring.png[width=800, link="images/user-review-ui-side-by-side-diff-screen-syntax-coloring.png"]
1072
Edwin Kempinf9b4bc92014-11-05 13:14:57 +01001073- [[whitespace-errors]]`Whitespace Errors`:
Edwin Kempinfe8ca4c2014-05-08 16:49:15 +02001074+
1075Controls whether whitespace errors are highlighted.
1076
Edwin Kempinf9b4bc92014-11-05 13:14:57 +01001077- [[show-tabs]]`Show Tabs`:
Edwin Kempinfe8ca4c2014-05-08 16:49:15 +02001078+
1079Controls whether tabs are highlighted.
1080
Edwin Kempinf9b4bc92014-11-05 13:14:57 +01001081- [[line-numbers]]`Line Numbers`:
Edwin Kempinfe8ca4c2014-05-08 16:49:15 +02001082+
1083Controls whether line numbers are shown.
1084
Edwin Kempinf9b4bc92014-11-05 13:14:57 +01001085- [[empty-pane]]`Empty Pane`:
David Ostrovskya64d6892014-05-01 21:55:00 +02001086+
1087Controls whether empty panes are shown or not. The Left pane is empty when a
1088file was added; the right pane is empty when a file was deleted.
1089
Edwin Kempinf9b4bc92014-11-05 13:14:57 +01001090- [[left-side]]`Left Side`:
Edwin Kempin91de46f2014-05-12 08:28:32 +02001091+
David Ostrovskya000b232014-05-13 07:47:06 +02001092Controls whether the left side is shown. This preference is not
1093persistent and is ignored by the `Save` button. Every time a
1094patch diff is opened, this preference is reset to `Show`.
Edwin Kempin91de46f2014-05-12 08:28:32 +02001095
Edwin Kempinf9b4bc92014-11-05 13:14:57 +01001096- [[top-menu]]`Top Menu`:
Edwin Kempinfe8ca4c2014-05-08 16:49:15 +02001097+
1098Controls whether the top menu is shown.
1099
Edwin Kempinf9b4bc92014-11-05 13:14:57 +01001100- [[auto-hide-diff-table-header]]`Auto Hide Diff Table Header`:
Edwin Kempin1b6c6d82014-09-11 23:36:43 +02001101+
1102Controls whether the diff table header should be automatically hidden
1103when scrolling down more than half of a page.
1104
Edwin Kempinf9b4bc92014-11-05 13:14:57 +01001105- [[mark-reviewed]]`Mark Reviewed`:
Edwin Kempinfe8ca4c2014-05-08 16:49:15 +02001106+
1107Controls whether the files of the patch set should be automatically
1108marked as reviewed when they are viewed.
1109
Edwin Kempinf9b4bc92014-11-05 13:14:57 +01001110- [[expand-all-comments]]`Expand All Comments`:
Edwin Kempinfe8ca4c2014-05-08 16:49:15 +02001111+
1112Controls whether all comments should be automatically expanded.
1113
Edwin Kempinf9b4bc92014-11-05 13:14:57 +01001114- [[render]]`Render`:
Edwin Kempinfe8ca4c2014-05-08 16:49:15 +02001115+
1116Controls how patch files that exceed the screen size are rendered.
1117+
1118If `Fast` is selected file contents which are outside of the visible
1119area are not attached to the browser's DOM tree. This makes the
1120rendering fast, but searching by `Ctrl+F` only finds content which is
1121in the visible area.
1122+
1123If `Slow` is selected all file contents are attached to the browser's
1124DOM tree, which makes the rendering slow for large files. The advantage
1125of this setting is that `Ctrl+F` can be used to search in the complete
1126file.
Edwin Kempin9cc22c92014-05-12 08:16:52 +02001127+
1128Large files that exceed 4000 lines will not be fully rendered.
Edwin Kempinfe8ca4c2014-05-08 16:49:15 +02001129
Paladoxee24b3c2016-09-05 23:51:02 +01001130- [[line-wrapping]]`Line Wrapping`:
1131+
1132Controls weather to enable line wrapping or not.
1133+
1134If `false` is selected then line wrapping is disabled.
1135This is the default option.
1136+
1137If `true` is selected then line wrapping is enabled.
1138
Edwin Kempin7a85f412014-05-09 12:51:51 +02001139[[keyboard-shortcuts]]
1140== Keyboard Shortcuts
1141
1142Navigation within the review UI can be completely done by keys, and
1143most actions can be controlled by keyboard shortcuts. Typing `?` opens
1144a popup that shows a list of available keyboard shortcuts:
1145
1146- Change Screen
1147+
1148image::images/user-review-ui-change-screen-keyboard-shortcuts.png[width=800, link="images/user-review-ui-change-screen-keyboard-shortcuts.png"]
1149
1150- Side-by-Side Diff Screen
1151+
1152image::images/user-review-ui-side-by-side-diff-screen-keyboard-shortcuts.png[width=800, link="images/user-review-ui-side-by-side-diff-screen-keyboard-shortcuts.png"]
1153+
1154In addition, Vim-like commands can be used to link:#key-navigation[
1155navigate] and link:#search[search] within a patch file.
1156
Edwin Kempinb7a1c7c2014-05-09 11:21:18 +02001157[[new-vs-old]]
1158== New Review UI vs. Old Review UI
1159
1160There are some important conceptual differences between the old and
1161new review UIs:
1162
1163- The old change screen directly shows all patch sets of the change.
1164 With the new change screen only a single patch set is displayed;
1165 users can switch between the patch sets by choosing another patch
1166 set from the link:#patch-sets[Patch Sets] drop down panel in the
1167 screen header.
1168- On the old side-by-side diff screen, new comments are inserted by
1169 double-clicking on a line. With the new side-by-side diff screen
1170 double-click is used to select a word for commenting on it; there
1171 are link:#add-inline-comment[several ways to insert new comments],
1172 e.g. by selecting a code block and clicking on the popup comment
1173 icon.
1174
Edwin Kempinf9b4bc92014-11-05 13:14:57 +01001175[[limitations]]
Edwin Kempinb7a1c7c2014-05-09 11:21:18 +02001176Limitations of the new review UI:
1177
1178- The new side-by-side diff screen cannot render images.
1179
Edwin Kempin7aed5f02014-11-05 13:30:22 +01001180- The new side-by-side diff screen isn't able to highlight line
1181 endings.
1182
Edwin Kempin4fd84c92014-04-30 13:23:15 +02001183GERRIT
1184------
1185Part of link:index.html[Gerrit Code Review]
1186
1187SEARCHBOX
1188---------