blob: 76220e0752860279c99ada58b2285ed5ff986c2f [file] [log] [blame]
Edwin Kempin4fd84c92014-04-30 13:23:15 +02001= Review UI
2
3Reviewing changes is an important task and the Gerrit Web UI provides
4many functionalities to make the review process comfortable and
5efficient. This is a guide through the review UI that explains the
6different functions and UI elements.
7
8[[change-screen]]
9== Change Screen
10
11The change screen shows the details of a single change and provides
12various actions on it.
13
14image::images/user-review-ui-change-screen.png[width=800, link="images/user-review-ui-change-screen.png"]
15
16[[commit-message]]
17=== Commit Message Block
18
19The focus of the change screen is on the commit message since this is
20the most important information about a change. The numeric change ID
21and the change status are displayed right above the commit message.
22
23image::images/user-review-ui-change-screen-commit-message.png[width=800, link="images/user-review-ui-change-screen-commit-message.png"]
24
Edwin Kempinf9b4bc92014-11-05 13:14:57 +010025[[permalink]]
Edwin Kempin4fd84c92014-04-30 13:23:15 +020026The numeric change ID is a link to the change and clicking on it
27refreshes the change screen. By copying the link location you can get
28the permalink of the change.
29
30image::images/user-review-ui-change-screen-permalink.png[width=800, link="images/user-review-ui-change-screen-permalink.png"]
31
Edwin Kempinf9b4bc92014-11-05 13:14:57 +010032[[change-status]]
Edwin Kempin4fd84c92014-04-30 13:23:15 +020033The change status shows the state of the change:
34
Edwin Kempinf9b4bc92014-11-05 13:14:57 +010035- [[needs]]`Needs <label>`:
Edwin Kempin4fd84c92014-04-30 13:23:15 +020036+
37The change is in review and an approval on the shown label is still
38required to make the change submittable.
39
Edwin Kempinf9b4bc92014-11-05 13:14:57 +010040- [[not]]`Not <label>`:
Edwin Kempin4fd84c92014-04-30 13:23:15 +020041+
42The change is in review and a veto vote on the shown label is
43preventing the submit.
44
Edwin Kempinf9b4bc92014-11-05 13:14:57 +010045- [[not-current]]`Not Current`:
Edwin Kempin4fd84c92014-04-30 13:23:15 +020046+
47The currently viewed patch set is outdated.
48+
49Please note that some operations, like voting, are not available on
50outdated patch sets, but only on the current patch set.
51
Edwin Kempinf9b4bc92014-11-05 13:14:57 +010052- [[ready-to-submit]]`Ready to Submit`:
Edwin Kempin4fd84c92014-04-30 13:23:15 +020053+
54The change has all necessary approvals and may be submitted.
55
Edwin Kempinf9b4bc92014-11-05 13:14:57 +010056- [[submitted-merge-pending]]`Submitted, Merge Pending`:
Edwin Kempin4fd84c92014-04-30 13:23:15 +020057+
58The change was submitted and was added to the merge queue.
59+
60The change stays in the merge queue if it depends on a change that is
61still in review. In this case it will get automatically merged when all
Stefan Beller5aef7b12015-02-17 11:23:17 -080062dependency changes have been merged.
Edwin Kempin4fd84c92014-04-30 13:23:15 +020063+
64This status can also mean that the change depends on an abandoned
65change or on an outdated patch set of another change. In this case you
66may want to rebase the change.
67
Edwin Kempinf9b4bc92014-11-05 13:14:57 +010068- [[merged]]`Merged`:
Edwin Kempin4fd84c92014-04-30 13:23:15 +020069+
70The change was successfully merged into the destination branch.
71
Edwin Kempinf9b4bc92014-11-05 13:14:57 +010072- [[abandoned]]`Abandoned`:
Edwin Kempin4fd84c92014-04-30 13:23:15 +020073+
74The change was abandoned.
75
Edwin Kempinf9b4bc92014-11-05 13:14:57 +010076- [[draft]]`Draft`:
Edwin Kempin4fd84c92014-04-30 13:23:15 +020077+
78The change is a draft that is only visible to the change owner, the
79reviewers that were explicitly added to the change, and users who have
80the link:access-control.html#category_view_drafts[View Drafts] global
81capability assigned.
82
83[[commit-info]]
84=== Commit Info Block
85
86The commit info block shows information about the commit of the
87currently viewed patch set.
88
89It displays the author and the committer as links to a list of this
90person's changes that have the same status as the currently viewed
91change.
92
Orgad Shaneh306ed3c2014-07-20 08:58:28 +030093The commit ID, the parent commit(s) and the link:user-changeid.html[Change-Id] are
Edwin Kempin4fd84c92014-04-30 13:23:15 +020094displayed with a copy-to-clipboard icon that allows the ID to be copied
95into the clipboard.
96
Dave Borowitza3d67882015-06-05 15:22:23 -070097If a Git web browser, such as gitweb or Gitiles, is configured, there
Edwin Kempin4fd84c92014-04-30 13:23:15 +020098is also a link to the commit in the Git web browser.
99
100image::images/user-review-ui-change-screen-commit-info.png[width=800, link="images/user-review-ui-change-screen-commit-info.png"]
101
Orgad Shaneh306ed3c2014-07-20 08:58:28 +0300102If a merge commit is viewed this is highlighted by an icon.
Edwin Kempinb6c2a3b2014-05-14 10:37:17 +0200103
104image::images/user-review-ui-change-screen-commit-info-merge-commit.png[width=800, link="images/user-review-ui-change-screen-commit-info-merge-commit.png"]
105
Edwin Kempinf1a84f92014-04-30 15:37:48 +0200106[[change-info]]
107=== Change Info Block
108
109The change info block contains detailed information about the change
110and offers actions on the change.
111
112image::images/user-review-ui-change-screen-change-info.png[width=800, link="images/user-review-ui-change-screen-change-info.png"]
113
Edwin Kempinf9b4bc92014-11-05 13:14:57 +0100114- [[change-owner]]Change Owner:
Edwin Kempinf1a84f92014-04-30 15:37:48 +0200115+
116The owner of the change is displayed as a link to a list of the owner's
117changes that have the same status as the currently viewed change.
118+
119image::images/user-review-ui-change-screen-change-info-owner.png[width=800, link="images/user-review-ui-change-screen-change-info-owner.png"]
120
Edwin Kempinf9b4bc92014-11-05 13:14:57 +0100121- [[reviewers]]Reviewers:
Edwin Kempinf1a84f92014-04-30 15:37:48 +0200122+
123The reviewers of the change are displayed as chip tokens.
124+
125For each reviewer there is a tooltip that shows on which labels the
126reviewer is allowed to vote.
127+
128New reviewers can be added by clicking on the `Add...` button. Typing
129into the pop-up text field activates auto completion of user and group
130names.
131+
Edwin Kempinf9b4bc92014-11-05 13:14:57 +0100132[[remove-reviewer]]
Edwin Kempinf1a84f92014-04-30 15:37:48 +0200133Reviewers can be removed from the change by clicking on the `x` icon
134in the reviewer's chip token. Removing a reviewer also removes the
135current votes of the reviewer. The removal of votes is recorded as a
136message on the change.
137+
138Removing reviewers is protected by permissions:
139
140** Users can always remove themselves.
141** The change owner may remove any zero or positive score.
142** Users with the link:access-control.html#category_remove_reviewer[
143 Remove Reviewer] access right, the branch owner, the project owner
144 and Gerrit administrators may remove anyone.
145
146+
147image::images/user-review-ui-change-screen-change-info-reviewers.png[width=800, link="images/user-review-ui-change-screen-change-info-reviewers.png"]
148
Edwin Kempinf9b4bc92014-11-05 13:14:57 +0100149- [[project-branch-topic]]Project / Branch / Topic:
Edwin Kempinf1a84f92014-04-30 15:37:48 +0200150+
151The name of the project for which the change was done is displayed as a
152link to the link:user-dashboards.html#project-default-dashboard[default
153dashboard] of the project. If no default dashboard is defined, the link
154opens a list of open changes on the project.
155+
156Clicking on the settings icon on the right side navigates to the
157project administration screen.
158+
159The name of the destination branch is displayed as a link to a list
160with all changes on this branch that have the same status as the
161currently viewed change.
162+
163If a topic was assigned to the change it is displayed below the branch.
164By clicking on the edit icon the topic can be set. This requires the
165link:access-control.html#category_edit_topic_name[Edit Topic Name]
166access right. To be able to set a topic on a closed change, the
167`Edit Topic Name` must be assigned with the `force` flag.
168+
169image::images/user-review-ui-change-screen-change-info-project-branch-topic.png[width=800, link="images/user-review-ui-change-screen-change-info-project-branch-topic.png"]
170
Edwin Kempinf9b4bc92014-11-05 13:14:57 +0100171- [[submit-strategy]]Submit Strategy:
Edwin Kempinf1a84f92014-04-30 15:37:48 +0200172+
173The link:project-setup.html#submit_type[submit strategy] that will be
174used to submit the change. The submit strategy is only displayed for
175open changes.
176+
177image::images/user-review-ui-change-screen-change-info-submit-strategy.png[width=800, link="images/user-review-ui-change-screen-change-info-submit-strategy.png"]
178+
179If a change cannot be merged due to path conflicts this is highlighted
180by a bold red `Cannot Merge` label.
181+
182image::images/user-review-ui-change-screen-change-info-cannot-merge.png[width=800, link="images/user-review-ui-change-screen-change-info-cannot-merge.png"]
183
Edwin Kempinf9b4bc92014-11-05 13:14:57 +0100184- [[update-time]]Time of Last Update:
Edwin Kempinf1a84f92014-04-30 15:37:48 +0200185+
186image::images/user-review-ui-change-screen-change-info-last-update.png[width=800, link="images/user-review-ui-change-screen-change-info-last-update.png"]
187
Edwin Kempinf9b4bc92014-11-05 13:14:57 +0100188- [[actions]]Actions:
Edwin Kempinf1a84f92014-04-30 15:37:48 +0200189+
190Depending on the change state and the permissions of the user, different
191actions are available on the change:
192
Edwin Kempinf9b4bc92014-11-05 13:14:57 +0100193** [[submit]]`Submit`:
Edwin Kempinf1a84f92014-04-30 15:37:48 +0200194+
195Submits the change and adds it to the merge queue. If possible the
196change is merged into the destination branch.
197+
David Pursehouse53b1bd02014-05-09 11:18:08 +0900198The `Submit` button is available if the change is submittable and
Edwin Kempinf1a84f92014-04-30 15:37:48 +0200199the link:access-control.html#category_submit[Submit] access right is
200assigned.
201+
202It is also possible to submit changes that have merge conflicts. This
203allows to do the conflict resolution for a change series in a single
204merge commit and submit the changes in reverse order.
205
Edwin Kempinf9b4bc92014-11-05 13:14:57 +0100206** [[abandon]]`Abandon`:
Edwin Kempinf1a84f92014-04-30 15:37:48 +0200207+
208Abandons the change.
209+
210The `Abandon` button is only available if the change is open and the
211link:access-control.html#category_abandon[Abandon] access right is
212assigned.
213+
214When a change is abandoned, a panel appears that allows one to type a
215comment message to explain why the change is being abandoned.
216
Edwin Kempinf9b4bc92014-11-05 13:14:57 +0100217** [[restore]]`Restore`:
Edwin Kempinf1a84f92014-04-30 15:37:48 +0200218+
219Restores the change.
220+
221The `Restore` button is only available if the change is abandoned and
222the link:access-control.html#category_abandon[Abandon] and the
223link:access-control.html#category_push[Push] access right is
224assigned.
225+
226When a change is restored, a panel appears that allows one to type a
227comment message to explain why the change is being restored.
228
Edwin Kempinf9b4bc92014-11-05 13:14:57 +0100229** [[rebase]]`Rebase`:
Edwin Kempinf1a84f92014-04-30 15:37:48 +0200230+
231Rebases the change. The rebase is always done with content merge
232enabled. If the rebase is successful a new patch set with the rebased
233commit is created. If the rebase fails, there are conflicts that have
234to be resolved manually.
235+
236If the change does not depend on another open change, it is rebased
237onto the tip of the destination branch.
238+
239If the change depends on another open change, it is rebased onto the
240current patch set of that other change.
241+
Zalan Blenessy366d7852015-03-18 11:40:48 +0100242It is possible to change parent revision of a change. The new parent
243revision can be another change towards the same target branch, or
244the tip of the target branch.
245+
246The `Rebase` button is only available if
Edwin Kempinf1a84f92014-04-30 15:37:48 +0200247the link:access-control.html#category_rebase[Rebase] access right is
248assigned. Rebasing merge commits is not supported.
249
Edwin Kempinf9b4bc92014-11-05 13:14:57 +0100250** [[cherry-pick]]`Cherry-Pick`:
Edwin Kempinf1a84f92014-04-30 15:37:48 +0200251+
252Allows to cherry-pick the change to another branch. The destination
253branch can be selected from a dialog. Cherry-picking a change creates a
254new open change on the selected destination branch.
255+
256It is also possible to cherry-pick a change to the same branch. This is
257effectively the same as rebasing it to the current tip of the
258destination branch. This can be used to remove dependencies on other
259open changes.
260+
261Users can only cherry-pick changes to branches for which they are
262allowed to upload changes for review.
263
Edwin Kempinf9b4bc92014-11-05 13:14:57 +0100264** [[publish]]`Publish`:
Edwin Kempinf1a84f92014-04-30 15:37:48 +0200265+
266Publishes the currently viewed draft patch set. If this is the first
267patch set of a change that is published, the change will be published
268as well.
269+
270The `Publish` button is only available if a draft patch set is viewed
271and the user is the change owner or has the
272link:access-control.html#category_publish_drafts[Publish Drafts] access
273right assigned.
274
Edwin Kempinf9b4bc92014-11-05 13:14:57 +0100275** [[delete]]`Delete Change` / `Delete Revision`:
Edwin Kempinf1a84f92014-04-30 15:37:48 +0200276+
277Deletes the draft change / the currently viewed draft patch set.
278+
279The `Delete Change` / `Delete Revision` buttons are only available if a
280draft patch set is viewed and the user is the change owner or has the
281link:access-control.html#category_delete_drafts[Delete Drafts] access
282right assigned.
283
Edwin Kempinf9b4bc92014-11-05 13:14:57 +0100284** [[plugin-actions]]Further actions may be available if plugins are installed.
Edwin Kempinf1a84f92014-04-30 15:37:48 +0200285
286+
287image::images/user-review-ui-change-screen-change-info-actions.png[width=800, link="images/user-review-ui-change-screen-change-info-actions.png"]
288
Edwin Kempinf9b4bc92014-11-05 13:14:57 +0100289- [[labels]]Labels & Votes:
Edwin Kempinf1a84f92014-04-30 15:37:48 +0200290+
291Approving votes are colored green; veto votes are colored red.
292+
293image::images/user-review-ui-change-screen-change-info-labels.png[width=800, link="images/user-review-ui-change-screen-change-info-labels.png"]
294
Edwin Kempinab777f12014-05-02 11:47:57 +0200295[[files]]
296=== File List
297
298The file list shows the files that are modified in the currently viewed
299patch set.
300
301image::images/user-review-ui-change-screen-file-list.png[width=800, link="images/user-review-ui-change-screen-file-list.png"]
302
Edwin Kempinf9b4bc92014-11-05 13:14:57 +0100303[[change-screen-mark-reviewed]]
Edwin Kempinab777f12014-05-02 11:47:57 +0200304The checkboxes in front of the file names allow files to be marked as reviewed.
305
306image::images/user-review-ui-change-screen-file-list-mark-as-reviewed.png[width=800, link="images/user-review-ui-change-screen-file-list-mark-as-reviewed.png"]
307
Edwin Kempinf9b4bc92014-11-05 13:14:57 +0100308[[modification-type]]
Edwin Kempinab777f12014-05-02 11:47:57 +0200309The type of a file modification is indicated by the character in front
310of the file name:
311
312- 'no character' (Modified):
313+
314The file existed before this change and is modified.
315
316- `A` (Added):
317+
318The file is newly added.
319
320- `D` (Deleted):
321+
322The file is deleted.
323
324- `R` (Renamed):
325+
326The file is renamed.
327
328- `C` (Copied):
329+
330The file is new and is copied from an existing file.
331
332image::images/user-review-ui-change-screen-file-list-modification-type.png[width=800, link="images/user-review-ui-change-screen-file-list-modification-type.png"]
333
Edwin Kempinf9b4bc92014-11-05 13:14:57 +0100334[[rename-or-copy]]
Edwin Kempinab777f12014-05-02 11:47:57 +0200335If a file is renamed or copied, the name of the original file is
336displayed in gray below the file name.
337
338image::images/user-review-ui-change-screen-file-list-rename.png[width=800, link="images/user-review-ui-change-screen-file-list-rename.png"]
339
Edwin Kempinf9b4bc92014-11-05 13:14:57 +0100340[[repeating-path-segments]]
Edwin Kempinab777f12014-05-02 11:47:57 +0200341Repeating path segments are grayed out.
342
343image::images/user-review-ui-change-screen-file-list-repeating-paths.png[width=800, link="images/user-review-ui-change-screen-file-list-repeating-paths.png"]
344
Edwin Kempinf9b4bc92014-11-05 13:14:57 +0100345[[inline-comments-column]]
Edwin Kempinab777f12014-05-02 11:47:57 +0200346Inline comments on a file are shown in the `Comments` column.
347
348Draft comments, i.e. comments that have been written by the current
349user but not yet published, are highlighted in red.
350
351New comments from other users, that were published after the current
352user last reviewed this change, are highlighted in bold.
353
354image::images/user-review-ui-change-screen-file-list-comments.png[width=800, link="images/user-review-ui-change-screen-file-list-comments.png"]
355
Edwin Kempinf9b4bc92014-11-05 13:14:57 +0100356[[size]]
David Pursehouse8bd6f782015-01-30 11:06:38 +0900357The size of the modifications in the files can be seen in the `Size` column. The
358footer row shows the total size of the change.
Edwin Kempinab777f12014-05-02 11:47:57 +0200359
360The size information is useful to easily spot the files that contain
361the most modifications; these files are likely to be the most relevant
362files for this change. The total change size gives an estimate of how
363long a review of this change may take.
364
David Pursehouse8bd6f782015-01-30 11:06:38 +0900365When the "Show Change Sizes As Colored Bars" user preference is enabled, the
366`Size` column shows the sum of inserted and deleted lines as one number. In
367addition, the change size is shown as a bar. The size of the bar indicates the
368amount of changed lines, and its coloring shows the proportion of insertions
369(green) to deletions (red).
370
371When the "Show Change Sizes As Colored Bars" user preference is disabled, the
372colored bar is not shown. For added and renamed files, the `Size` column
373shows the number of inserted and deleted lines. For new files, the column only
374shows the total number of lines in the new file. No size is shown for binary
375files and deleted files.
376
Edwin Kempinab777f12014-05-02 11:47:57 +0200377image::images/user-review-ui-change-screen-file-list-size.png[width=800, link="images/user-review-ui-change-screen-file-list-size.png"]
378
Edwin Kempinf9b4bc92014-11-05 13:14:57 +0100379[[diff-against]]
Edwin Kempinab777f12014-05-02 11:47:57 +0200380In the header of the file list, the `Diff Against` selection can be
381changed. This selection allows one to choose if the currently viewed
382patch set should be compared against its base or against another patch
383set of this change. The file list is updated accordingly.
384
Edwin Kempinf9b4bc92014-11-05 13:14:57 +0100385[[open-all]]
Edwin Kempinab777f12014-05-02 11:47:57 +0200386The file list header also provides an `Open All` button that opens the
387diff views for all files in the file list.
388
389image::images/user-review-ui-change-screen-file-list-header.png[width=800, link="images/user-review-ui-change-screen-file-list-header.png"]
390
Edwin Kempinb2a8ae32014-05-02 15:03:22 +0200391[[patch-sets]]
392=== Patch Sets
393
394The change screen only presents one patch set at a time. Which patch
395set is currently viewed can be seen from the `Patch Sets` drop-down
396panel in the change header. It shows the number of the currently viewed
397patch set and the total number of patch sets, in the form: "current
398patch set/number of patch sets".
399
400If a non-current patch set is viewed this is indicated by the
401link:#not-current[Not Current] change state. Please note that some
402operations are only available on the current patch set.
403
404image::images/user-review-ui-change-screen-patch-sets.png[width=800, link="images/user-review-ui-change-screen-patch-sets.png"]
405
Edwin Kempinf9b4bc92014-11-05 13:14:57 +0100406[[patch-set-drop-down]]
Edwin Kempinb2a8ae32014-05-02 15:03:22 +0200407The patch set drop-down list shows the list of patch sets and allows to
408switch between them. The patch sets are sorted in descending order so
409that the current patch set is always on top.
410
Edwin Kempinb2a8ae32014-05-02 15:03:22 +0200411Draft patch sets are marked with `DRAFT`.
412
413image::images/user-review-ui-change-screen-patch-set-list.png[width=800, link="images/user-review-ui-change-screen-patch-set-list.png"]
414
Edwin Kempin0cb1ccb2014-05-05 13:22:03 +0200415[[download]]
416=== Download
417
418The `Download` drop-down panel in the change header offers commands and
419links for downloading the currently viewed patch set.
420
421image::images/user-review-ui-change-screen-download-commands.png[width=800, link="images/user-review-ui-change-screen-download-commands.png"]
422
423The available download commands depend on the installed Gerrit plugins.
424The most popular plugin for download commands, the
425link:https://gerrit-review.googlesource.com/#/admin/projects/plugins/download-commands[
426download-commands] plugin, provides commands to checkout, pull and
427cherry-pick a patch set.
428
429Each command has a copy-to-clipboard icon that allows the command to be
430copied into the clipboard. This makes it easy to paste and execute the
431command on a Git command line.
432
433If several download schemes are configured on the server (e.g. SSH and
434HTTP) there is a drop-down list to switch between the download schemes.
435Gerrit automatically remembers the download scheme that was last chosen
436and selects this download scheme the next time the download commands
437drop-down panel is opened.
438
439The `Patch-File` links provide the Git patch file for the currently
440viewed patch set for download. The patch file can be base64 encoded or
441zipped.
442
443The `Archive` links allow one to download an archive with the contents
444of the currently viewed patch set. The archive is offered in several
445formats (e.g. tar and tbz2); which formats are available depends on the
446configuration of the server.
447
448image::images/user-review-ui-change-screen-download-commands-list.png[width=800, link="images/user-review-ui-change-screen-download-commands-list.png"]
449
Edwin Kempin811bd582014-05-05 13:39:24 +0200450[[included-in]]
451=== Included In
452
453For merged changes the `Included In` drop-down panel is available in
454the change header.
455
456image::images/user-review-ui-change-screen-included-in.png[width=800, link="images/user-review-ui-change-screen-included-in.png"]
457
458The `Included In` drop-down panel shows the branches and tags in which
459the change is included. E.g. if a change fixes a bug, this allows to
460quickly see in which released versions the bug-fix is contained
461(assuming that every release is tagged).
462
463image::images/user-review-ui-change-screen-included-in-list.png[width=800, link="images/user-review-ui-change-screen-included-in-list.png"]
464
Edwin Kempin981cc952014-05-05 14:04:08 +0200465[[star]]
466=== Star Change
467
468The star icon in the change header allows to mark the change as a
469favorite. Clicking on the star icon again, unstars the change.
470
471image::images/user-review-ui-change-screen-star.png[width=800, link="images/user-review-ui-change-screen-star.png"]
472
473Starring a change turns on email notifications for this change.
474
475Starred changed are listed under `My` > `Starred Changes`.
476and can be queried by the link:user-search.html#is[is:starred] search
477operator.
478
Edwin Kempin8ab5b532014-05-05 17:10:31 +0200479[[related-changes]]
480=== Related Changes
481
482If there are changes that are related to the currently viewed change
483they are displayed in the third column of the change screen.
484
485There are several lists of related changes and a tab control is used to
486display each list of related changes in its own tab.
487
488The following tabs may be displayed:
489
Edwin Kempinf9b4bc92014-11-05 13:14:57 +0100490- [[related-changes-tab]]`Related Changes`:
Edwin Kempin8ab5b532014-05-05 17:10:31 +0200491+
492This tab page shows changes on which the current change depends
493(ancestors) and open changes that depend on the current change
494(descendants). For merge commits it also shows the closed changes that
495will be merged into the destination branch by submitting the merge
496commit.
497+
498The changes are sorted in the same way as the output of 'git log'. This
499means the relationship between the changes can be inferred from the
500position of the changes in the list. Changes listed above the current
501change are descendants; changes below the current change are ancestors.
502+
Edwin Kempin68cfe472014-05-12 15:10:25 +0200503For merged changes this tab is only shown if there are open
504descendants.
Edwin Kempin8ab5b532014-05-05 17:10:31 +0200505+
506image::images/user-review-ui-change-screen-related-changes.png[width=800, link="images/user-review-ui-change-screen-related-changes.png"]
507+
508Related changes may be decorated with an icon to signify dependencies
509on outdated patch sets, or commits that are not associated to changes
510under review:
511+
Edwin Kempinf9b4bc92014-11-05 13:14:57 +0100512** [[outdated]]Orange Dot:
Edwin Kempin8ab5b532014-05-05 17:10:31 +0200513+
514The selected patch set of the change is outdated; it is not the current
515patch set of the change.
516+
517If an ancestor change is marked with an orange dot it means that the
518currently viewed patch set depends on a outdated patch set of the
519ancestor change. This is because a new patch set for the ancestor
520change was uploaded in the meantime and as result the currently viewed
521patch set now needs to be rebased.
522+
523If a descendant change is marked with an orange dot it means that an
524old patch set of the descendant change depends on the currently viewed
525patch set. It may be that the descendant was rebased in the meantime
526and with the new patch set this dependency was removed.
527
Edwin Kempinf9b4bc92014-11-05 13:14:57 +0100528** [[indirect-descendant]]Green Tilde:
Edwin Kempin8ab5b532014-05-05 17:10:31 +0200529+
530The selected patch set of the change is an indirect descendant of the
531currently viewed patch set; it has a dependency to another patch set of
532this change. E.g. this could mean that a new patch set was uploaded for
533this change and the descendant change now needs to be rebased. Please
534note that following the link to an indirect descendant change may
535result in a completely different related changes listing.
536
Dave Borowitzbbaea3f2015-03-13 13:56:41 -0700537** [[closed-ancestor]]Black Dot:
Edwin Kempin8ab5b532014-05-05 17:10:31 +0200538+
539Indicates a merged ancestor, e.g. the commit was directly pushed into
540the repository bypassing code review, or the ancestor change was
541reviewed and submitted on another branch. The latter may indicate that
542the user has accidentally pushed the commit to the wrong branch, e.g.
543the commit was done on `branch-a`, but was then pushed to
544`refs/for/branch-b`.
545
Edwin Kempin8ab5b532014-05-05 17:10:31 +0200546+
547image::images/user-review-ui-change-screen-related-changes-indicators.png[width=800, link="images/user-review-ui-change-screen-related-changes-indicators.png"]
548
Edwin Kempinf9b4bc92014-11-05 13:14:57 +0100549- [[conflicts-with]]`Conflicts With`:
Edwin Kempin8ab5b532014-05-05 17:10:31 +0200550+
551This tab page shows changes that conflict with the current change.
552Non-mergeable changes are filtered out; only conflicting changes that
553are mergeable are shown.
554+
555If this change is merged, its conflicting changes will have merge
556conflicts and must be rebased. The rebase of the other changes with the
557conflict resolution must then be done manually.
558+
559image::images/user-review-ui-change-screen-conflicts-with.png[width=800, link="images/user-review-ui-change-screen-conflicts-with.png"]
560
Edwin Kempinf9b4bc92014-11-05 13:14:57 +0100561- [[same-topic]]`Same Topic`:
Edwin Kempin8ab5b532014-05-05 17:10:31 +0200562+
563This tab page shows changes that have the same topic as the current
564change. Only open changes are included in the list.
565+
566image::images/user-review-ui-change-screen-same-topic.png[width=800, link="images/user-review-ui-change-screen-same-topic.png"]
567
Edwin Kempinf9b4bc92014-11-05 13:14:57 +0100568- [[cherry-picks]]`Cherry-Picks`:
Edwin Kempin8ab5b532014-05-05 17:10:31 +0200569+
570This tab page shows changes with the same link:user-changeid.html[
571Change-Id] for the current project.
572+
573Abandoned changes are filtered out.
574+
575For each change in this list the destination branch is shown as a
576prefix in front of the change subject.
577+
578image::images/user-review-ui-change-screen-cherry-picks.png[width=800, link="images/user-review-ui-change-screen-cherry-picks.png"]
579
580If there are no related changes for a tab, the tab is not displayed.
581
Edwin Kempinc6cab612014-05-06 11:09:05 +0200582[[reply]]
583=== Reply
584
585The `Reply...` button in the change header allows to reply to the
586currently viewed patch set; one can add a summary comment, publish
587inline draft comments, and vote on the labels.
588
589image::images/user-review-ui-change-screen-reply.png[width=800, link="images/user-review-ui-change-screen-reply.png"]
590
591Clicking on the `Reply...` button opens a popup panel.
592
593A text box allows to type a summary comment for the currently viewed
594patch set.
595
Richard Möhne4abe9a2014-11-13 20:05:13 +0100596Note that you can set the text and tooltip of the button in
597link:config-gerrit.html#change.replyLabel[gerrit.config].
598
Edwin Kempinf9b4bc92014-11-05 13:14:57 +0100599[[vote]]
Edwin Kempinc6cab612014-05-06 11:09:05 +0200600If the current patch set is viewed, radio buttons are displayed for
601each label on which the user is allowed to vote. Voting on non-current
602patch sets is not possible.
603
Edwin Kempinc6cab612014-05-06 11:09:05 +0200604The inline draft comments that will be published are displayed in a
605separate section so that they can be reviewed before publishing. There
606are links to navigate to the inline comments which can be used if a
607comment needs to be edited.
608
609The `Post` button publishes the comments and the votes.
610
Edwin Kempinc6cab612014-05-06 11:09:05 +0200611image::images/user-review-ui-change-screen-replying.png[width=800, link="images/user-review-ui-change-screen-replying.png"]
612
Edwin Kempinf9b4bc92014-11-05 13:14:57 +0100613[[quick-approve]]
Edwin Kempinc6cab612014-05-06 11:09:05 +0200614If a user can approve a label that is still required, a quick approve
615button appears in the change header that allows to add this missing
616approval by a single click. The quick approve button only appears if
617there is a single label that is still required and can be approved by
618the user.
619
620E.g. if a change requires approvals on the 'Code-Review' and the
621'Verified' labels, and there is already a '+1 Verified' vote, then
622if the user is allowed to vote the max score on 'Code-Review', a
623`Code-Review+2` quick approve button appears that approves the
624'Code-Review' label if clicked.
625
626Using the quick approve button also publishes all inline draft
627comments; a summary comment is only added if the reply popup panel is
628open when the quick approve button is clicked.
629
630image::images/user-review-ui-change-screen-quick-approve.png[width=800, link="images/user-review-ui-change-screen-quick-approve.png"]
631
Edwin Kempin7a682812014-05-06 14:45:01 +0200632[[history]]
633=== History
634
635The history of the change can be seen in the lower part of the screen.
636
637The history contains messages for all kinds of change updates, e.g. a
638message is added when a new patch set is uploaded or when a review was
639done.
640
641Messages with new comments from other users, that were published after
642the current user last reviewed this change, are automatically expanded.
643
644image::images/user-review-ui-change-screen-history.png[width=800, link="images/user-review-ui-change-screen-history.png"]
645
Edwin Kempinf9b4bc92014-11-05 13:14:57 +0100646[[reply-to-message]]
Edwin Kempin7a682812014-05-06 14:45:01 +0200647It is possible to directly reply to a change message by clicking on the
648reply icon in the right upper corner of a change message. This opens
649the reply popup panel and prefills the text box with the quoted comment.
650Then the reply can be written below the quoted comment or inserted
651inline. Lines starting with " > " will be rendered as a block quote.
652Please note that for a correct rendering it is important to leave a blank
653line between a quoted block and the reply to it.
654
655image::images/user-review-ui-change-screen-reply-to-comment.png[width=800, link="images/user-review-ui-change-screen-reply-to-comment.png"]
656
Edwin Kempinf9b4bc92014-11-05 13:14:57 +0100657[[inline-comments-in-history]]
Edwin Kempin7a682812014-05-06 14:45:01 +0200658Inline comments are directly displayed in the change history and there
659are links to navigate to the inline comments.
660
661image::images/user-review-ui-change-screen-inline-comments.png[width=800, link="images/user-review-ui-change-screen-inline-comments.png"]
662
Edwin Kempinf9b4bc92014-11-05 13:14:57 +0100663[[expand-all]]
Edwin Kempin7a682812014-05-06 14:45:01 +0200664The `Expand All` button expands all messages; the `Collapse All` button
665collapses all messages.
666
Edwin Kempin772418f2014-05-06 15:45:35 +0200667[[update-notification]]
668=== Update Notification
669
670The change screen automatically polls for updates to the currently
671viewed change. If there is an update the user is informed by a popup
672panel in the bottom right corner.
673
674The polling frequency depends on the server configuration; by default
675it is 30 seconds. Polling may also be completely disabled by the
676administrator.
677
678image::images/user-review-ui-change-screen-change-update.png[width=800, link="images/user-review-ui-change-screen-change-update.png"]
679
Edwin Kempin41d9d302014-05-06 16:02:06 +0200680[[plugin-extensions]]
681=== Plugin Extensions
682
683Gerrit plugins may extend the change screen; they can add buttons for
684additional actions to the change info block and display arbitrary UI
685controls below the change info block.
686
687image::images/user-review-ui-change-screen-plugin-extensions.png[width=800, link="images/user-review-ui-change-screen-plugin-extensions.png"]
688
Edwin Kempind38ddf52014-05-07 14:31:42 +0200689[[side-by-side]]
690== Side-by-Side Diff Screen
691
692The side-by-side diff screen shows a single patch; the old file version
693is displayed on the left side of the screen; the new file version is
694displayed on the right side of the screen.
695
696This screen allows to review a patch and to comment on it.
697
698image::images/user-review-ui-side-by-side-diff-screen.png[width=800, link="images/user-review-ui-side-by-side-diff-screen.png"]
699
Edwin Kempinf9b4bc92014-11-05 13:14:57 +0100700[[side-by-side-header]]
Edwin Kempind38ddf52014-05-07 14:31:42 +0200701In the screen header the project name and the name of the viewed patch
702file are shown.
703
704If a Git web browser is configured on the server, the project name and
705the file path are displayed as links to the project and the folder in
706the Git web browser.
707
708image::images/user-review-ui-side-by-side-diff-screen-project-and-file.png[width=800, link="images/user-review-ui-side-by-side-diff-screen-project-and-file.png"]
709
Edwin Kempinf9b4bc92014-11-05 13:14:57 +0100710[[side-by-side-mark-reviewed]]
Edwin Kempind38ddf52014-05-07 14:31:42 +0200711The checkbox in front of the project name and the file name allows the
Edwin Kempinfe8ca4c2014-05-08 16:49:15 +0200712patch to be marked as reviewed. The link:#mark-reviewed[Mark Reviewed]
713diff preference allows to control whether the files should be
714automatically marked as reviewed when they are viewed.
Edwin Kempind38ddf52014-05-07 14:31:42 +0200715
716image::images/user-review-ui-side-by-side-diff-screen-reviewed.png[width=800, link="images/user-review-ui-side-by-side-diff-screen-reviewed.png"]
717
Edwin Kempinf9b4bc92014-11-05 13:14:57 +0100718[[scrollbar]]
Edwin Kempind38ddf52014-05-07 14:31:42 +0200719The scrollbar shows patch diffs and inline comments as annotations.
720This provides a good overview of the lines in the patch that are
721relevant for reviewing. By clicking on an annotation one can quickly
722navigate to the corresponding line in the patch.
723
724image::images/user-review-ui-side-by-side-diff-screen-scrollbar.png[width=800, link="images/user-review-ui-side-by-side-diff-screen-scrollbar.png"]
725
Edwin Kempinf9b4bc92014-11-05 13:14:57 +0100726[[gaps]]
Edwin Kempin1266ac8f2014-05-09 09:39:31 +0200727A gap between lines in the file content that is caused by aligning the
728left and right side or by displaying inline comments is shown as a
729vertical red bar in the line number column. This prevents a gap from
730being mistaken for blank lines in the file
731
732image::images/user-review-ui-side-by-side-diff-screen-red-bar.png[width=800, link="images/user-review-ui-side-by-side-diff-screen-red-bar.png"]
733
Edwin Kempind8057e52014-05-08 13:52:32 +0200734[[patch-set-selection]]
735In the header, on each side, the list of patch sets is shown. Clicking
736on a patch set changes the selection for the patch set comparison and
737the screen is refreshed to show the diff between the selected patch
738sets. The currently selected patch set is highlighted by a light blue
739background.
740
741On the left side `Base` can be selected to compare a patch set against
742its base. For merge commits `Auto Merge` is available instead which
743allows to compare the patch against the result of the auto merge. The
744auto merge version may contain Git conflict markers and is useful for
745reviewing how conflicts are resolved by a patch.
746
747Reviewers that are reviewing a patch for the first time look at its
748diff against its base; reviewers that have reviewed an old patch
749version before, may see what has changed since that version by
750comparing the old patch against the current patch.
751
752image::images/user-review-ui-side-by-side-diff-screen-patch-sets.png[width=800, link="images/user-review-ui-side-by-side-diff-screen-patch-sets.png"]
753
Edwin Kempinf9b4bc92014-11-05 13:14:57 +0100754[[download-file]]
Edwin Kempin6db9bcd2014-06-06 09:32:05 +0200755The download icon next to the patch set list allows to download the
756patch. Unless the mime type of the file is configured as safe, the
757download file is a zip archive that contains the patch file.
758
Edwin Kempinf9b4bc92014-11-05 13:14:57 +0100759[[no-differences]]
Edwin Kempin01280cc2014-05-09 09:53:30 +0200760If the compared patches are identical, this is highlighted by a red
761`No Differences` label in the screen header.
762
763image::images/user-review-ui-side-by-side-diff-screen-no-differences.png[width=800, link="images/user-review-ui-side-by-side-diff-screen-no-differences.png"]
764
Edwin Kempinf9b4bc92014-11-05 13:14:57 +0100765[[side-by-side-rename]]
Edwin Kempinafb4fcc2014-06-06 09:52:52 +0200766If a file was renamed, the old and new file paths are shown in the
767header together with a similarity index that shows how much of the file
768content is unmodified.
769
770image::images/user-review-ui-side-by-side-diff-screen-rename.png[width=800, link="images/user-review-ui-side-by-side-diff-screen-rename.png"]
Edwin Kempind8057e52014-05-08 13:52:32 +0200771
Edwin Kempinf9b4bc92014-11-05 13:14:57 +0100772[[navigation]]
Edwin Kempind37a1342014-05-08 14:02:35 +0200773For navigating between the patches in a patch set there are navigation
774buttons on the right side of the screen header. The left arrow button
775navigates to the previous patch; the right arrow button navigates to
776the next patch. The arrow up button leads back to the change screen. In
777all cases the selection for the patch set comparison is kept.
778
779image::images/user-review-ui-side-by-side-diff-screen-navigation.png[width=800, link="images/user-review-ui-side-by-side-diff-screen-navigation.png"]
780
Edwin Kempin004c3472014-05-07 16:56:59 +0200781[[inline-comments]]
782=== Inline Comments
783
784Inline comments are displayed directly in the patch file under the code
785that is commented. Inline comments can be placed on lines or on code
786blocks.
787
788If an inline comment relates to a code block, this code block is
789highlighted by a yellow background.
790
791Code blocks with comments may overlap. This means it is possible to
792attach several comments to the same code.
793
Edwin Kempinf9b4bc92014-11-05 13:14:57 +0100794[[line-links]]
Edwin Kempin004c3472014-05-07 16:56:59 +0200795The lines of the patch file are linkable. To link to a certain line in
796the patch file, '@<line-number>' must be appended to the patch link,
797e.g. `http://host:8080/#/c/56857/2/Documentation/user-review-ui.txt@665`.
798To link to a line in the old file version, '@a<line-number>' must be
799appended to the patch link. These links can be used to directly link to
800certain inline comments.
801
Edwin Kempinfe8ca4c2014-05-08 16:49:15 +0200802If the diff preference link:#expand-all-comments[Expand All Comments]
803is set to `Expand`, all inline comments will be automatically expanded.
Edwin Kempin004c3472014-05-07 16:56:59 +0200804
805image::images/user-review-ui-side-by-side-diff-screen-inline-comments.png[width=800, link="images/user-review-ui-side-by-side-diff-screen-inline-comments.png"]
806
Edwin Kempinf9b4bc92014-11-05 13:14:57 +0100807[[comment]]
Edwin Kempin004c3472014-05-07 16:56:59 +0200808In the header of the comment box, the name of the comment author and
809the timestamp of the comment are shown. If avatars are configured on
810the server, the avatar image of the comment author is displayed in the
811top left corner. Below the actual comment there are buttons to reply to
812the comment.
813
814image::images/user-review-ui-side-by-side-diff-screen-comment-box.png[width=800, link="images/user-review-ui-side-by-side-diff-screen-comment-box.png"]
815
Edwin Kempinf9b4bc92014-11-05 13:14:57 +0100816[[reply-inline-comment]]
Edwin Kempin004c3472014-05-07 16:56:59 +0200817Clicking on the `Reply` button opens an editor to type the reply.
818
819Quoting is supported, but only by manually copying & pasting the old
820comment that should be quoted and prefixing every line by " > ". Please
821note that for a correct rendering it is important to leave a blank line
822between a quoted block and the reply to it.
823
824Clicking on the `Save` button saves the comment as a draft. To make it
825visible to other users it must be published from the change screen by
826link:#reply[replying] to the change.
827
828The `Cancel` button cancels the editing and discards any changes to the
829draft comment.
830
831Clicking on the `Discard` button deletes the inline draft comment.
832
833image::images/user-review-ui-side-by-side-diff-screen-comment-reply.png[width=800, link="images/user-review-ui-side-by-side-diff-screen-comment-reply.png"]
834
Edwin Kempinf9b4bc92014-11-05 13:14:57 +0100835[[draft-inline-comment]]
Edwin Kempin004c3472014-05-07 16:56:59 +0200836Draft comments are marked by the text "Draft" in the header in the
837place of the comment author.
838
839A draft comment can be edited by clicking on the `Edit` button, or
840deleted by clicking on the `Discard` button.
841
842image::images/user-review-ui-side-by-side-diff-screen-comment-edit.png[width=800, link="images/user-review-ui-side-by-side-diff-screen-comment-edit.png"]
843
Edwin Kempinf9b4bc92014-11-05 13:14:57 +0100844[[done]]
Edwin Kempin004c3472014-05-07 16:56:59 +0200845Clicking on the `Done` button is a quick way to reply with "Done" to a
846comment. This is used to mark a comment as addressed by a follow-up
847patch set.
848
Edwin Kempin44606652014-05-09 08:31:05 +0200849image::images/user-review-ui-side-by-side-diff-screen-replied-done.png[width=800, link="images/user-review-ui-side-by-side-diff-screen-replied-done.png"]
Edwin Kempin004c3472014-05-07 16:56:59 +0200850
851[[add-inline-comment]]
852To add a new inline comment there are several possibilities:
853
854- select a code block and press 'c'
855- select a code block and click on the popup comment icon
Edwin Kempin7feeb952014-05-09 11:16:56 +0200856- go to a line, by clicking on it or by link:#key-navigation[key
857 navigation], and press 'c'
Edwin Kempin004c3472014-05-07 16:56:59 +0200858- click on a line number
859
860There are many ways to select code for commenting on it. The most
861frequently used methods are:
862
863- by mouse:
864** click and drag with the mouse to select a block
865** double-click on a word to select it
866** double-click and drag with the mouse to select a code block word-wise
867** triple-click on a line to select it
868** triple-click and drag with the mouse to select a code block line-wise
869
870- by keys (the same keys that are used for visual selection in Vim):
871** press 'v' + arrow keys (or 'h', 'j', 'k', 'l') to select a block
872** press 'V' + arrow keys (or 'j', 'k') to select a code block line-wise
873** type 'bvw' to select a word
874
Edwin Kempin004c3472014-05-07 16:56:59 +0200875image::images/user-review-ui-side-by-side-diff-screen-comment.png[width=800, link="images/user-review-ui-side-by-side-diff-screen-comment.png"]
876
877For typing the new comment, a new comment box is shown under the code
878that is commented.
879
880Clicking on the `Save` button saves the new comment as a draft. To make
881it visible to other users it must be published from the change screen
882by link:#reply[replying] to the change.
883
884Clicking on the `Discard` button deletes the new comment.
885
886image::images/user-review-ui-side-by-side-diff-screen-commented.png[width=800, link="images/user-review-ui-side-by-side-diff-screen-commented.png"]
887
Edwin Kempin9df27ac2014-05-08 13:06:18 +0200888[[file-level-comments]]
889=== File Level Comments
890
891Comments that apply to a whole file can be added on file level.
892
893File level comments are added by clicking on the comment icon in the
894header above the file.
895
896image::images/user-review-ui-side-by-side-diff-screen-file-level-comment.png[width=800, link="images/user-review-ui-side-by-side-diff-screen-file-level-comment.png"]
897
898Clicking on the comment icon opens a comment box for typing the file
899level comment.
900
901image::images/user-review-ui-side-by-side-diff-screen-file-level-commented.png[width=800, link="images/user-review-ui-side-by-side-diff-screen-file-level-commented.png"]
902
Edwin Kempin6113a1f2014-05-09 10:48:34 +0200903[[search]]
904=== Search
905
906For searching within a patch file, a Vim-like search is supported.
907Typing `/` opens the search box. Typing in the search box immediately
908highlights matches in the patch file with a yellow background. Using
909JavaScript regular expressions in the search term is supported. The
910search is case insensitive. After confirming the search by `ENTER` one
911can navigate between the matches by `n` / `N` to go to the next /
912previous match. Skipped lines are automatically expanded if they
913contain a match and one navigates to it.
914
915For additional possibilities to search please check the
916link:http://www.vim.org/docs.php[Vim documentation]. There are other
917useful ways to search, e.g. while the cursor is on a word, pressing `*`
918or `#` searches for the next or previous occurrence of the word.
919
920Searching by `Ctrl-F` finds matches only in the visible area of the
921screen unless the link:#render[Render] diff preference is set to `Slow`.
922
923image::images/user-review-ui-side-by-side-diff-screen-search.png[width=800, link="images/user-review-ui-side-by-side-diff-screen-search.png"]
924
Edwin Kempin7feeb952014-05-09 11:16:56 +0200925[[key-navigation]]
926=== Key Navigation
927
928Vim-like commands can be used to navigate within a patch file:
929
930- `h` / `j` / `k` / `l` moves the cursor left / down / up / right
931- `0` / `$` moves the cursor to the start / end of the line
932- `gg` / `G` moves to cursor to the start / end of the file
933- `Ctrl-D` / `Ctrl-U` scolls downwards / upwards
934
935Please check the link:http://www.vim.org/docs.php[Vim documentation]
936for further information.
937
Edwin Kempinfe8ca4c2014-05-08 16:49:15 +0200938[[diff-preferences]]
939=== Diff Preferences
940
941There are several options to control how patch diffs should be
942rendered. Users can configure their preferences in the diff
943preferences. The diff preferences can be accessed by clicking on the
944settings icon in the screen header.
945
946image::images/user-review-ui-side-by-side-diff-screen-preferences.png[width=800, link="images/user-review-ui-side-by-side-diff-screen-preferences.png"]
947
948The diff preferences popup allows to change the diff preferences.
949By clicking on the `Save` button changes to the diff preferences are
950saved permanently. Clicking on the `Apply` button applies the new
951diff preferences to the current screen, but they are discarded when the
952screen is refreshed. The `Save` button is only available if the user is
953signed in.
954
955image::images/user-review-ui-side-by-side-diff-screen-preferences-popup.png[width=800, link="images/user-review-ui-side-by-side-diff-screen-preferences-popup.png"]
956
957The following diff preferences can be configured:
958
Edwin Kempinf9b4bc92014-11-05 13:14:57 +0100959- [[theme]]`Theme`:
Edwin Kempinfe8ca4c2014-05-08 16:49:15 +0200960+
961Controls the theme that is used to render the file content.
962+
963E.g. users could choose to work with a dark theme.
964+
965image::images/user-review-ui-side-by-side-diff-screen-dark-theme.png[width=800, link="images/user-review-ui-side-by-side-diff-screen-dark-theme.png"]
966
Edwin Kempinf9b4bc92014-11-05 13:14:57 +0100967- [[ignore-whitespace]]`Ignore Whitespace`:
Edwin Kempinfe8ca4c2014-05-08 16:49:15 +0200968+
969Controls whether differences in whitespace should be ignored or not.
970+
971** `None`:
972+
973All differences in whitespace are highlighted.
974+
975** `At Line End`:
976+
977Whitespace differences at the end of lines are ignored.
978+
979** `Leading, At Line End`:
980+
981Whitespace differences at the beginning and end of lines are ignored.
982+
983** `All`:
984+
985All differences in whitespace are ignored.
986
Edwin Kempinf9b4bc92014-11-05 13:14:57 +0100987- [[tab-width]]`Tab Width`:
Edwin Kempinfe8ca4c2014-05-08 16:49:15 +0200988+
989Controls how many spaces should be displayed for a tab.
990
Edwin Kempinf9b4bc92014-11-05 13:14:57 +0100991- [[columns]]`Columns`:
Edwin Kempinfe8ca4c2014-05-08 16:49:15 +0200992+
993Sets the preferred line length. At this position a vertical dashed line
994is displayed so that one can easily detect lines the exceed the
995preferred line length.
996+
997image::images/user-review-ui-side-by-side-diff-screen-column.png[width=800, link="images/user-review-ui-side-by-side-diff-screen-column.png"]
998
Edwin Kempinf9b4bc92014-11-05 13:14:57 +0100999- [[lines-of-context]]`Lines Of Context`:
Edwin Kempinfe8ca4c2014-05-08 16:49:15 +02001000+
1001The number of context lines that should be displayed before and after
1002any diff. If the `entire file` checkbox is selected, the full file is
1003rendered.
1004+
1005Skipped common lines can be expanded by clicking on the placeholder for
1006the skipped lines.
1007+
1008Clicking on "... skipped <n> common lines ..." expands the complete
1009block of skipped lines.
1010+
1011If many lines are skipped there are additional links to expand the
1012context by ten lines before and after the skipped block.
1013+
1014image::images/user-review-ui-side-by-side-diff-screen-expand-skipped-lines.png[width=800, link="images/user-review-ui-side-by-side-diff-screen-expand-skipped-lines.png"]
1015
Edwin Kempinf9b4bc92014-11-05 13:14:57 +01001016- [[intraline-difference]]`Intraline Difference`:
Edwin Kempinfe8ca4c2014-05-08 16:49:15 +02001017+
1018Controls whether intraline differences should be highlighted.
1019+
1020image::images/user-review-ui-side-by-side-diff-screen-intraline-difference.png[width=800, link="images/user-review-ui-side-by-side-diff-screen-intraline-difference.png"]
1021
Edwin Kempinf9b4bc92014-11-05 13:14:57 +01001022- [[syntax-highlighting]]`Syntax Highlighting`:
Edwin Kempinfe8ca4c2014-05-08 16:49:15 +02001023+
1024Controls whether syntax highlighting should be enabled.
1025+
1026The language for the syntax highlighting is automatically detected from
Edwin Kempin637db5e2014-05-12 08:25:26 +02001027the file extension. The language can also be set manually by selecting
1028it from the `Language` drop-down list.
Edwin Kempinfe8ca4c2014-05-08 16:49:15 +02001029+
1030image::images/user-review-ui-side-by-side-diff-screen-syntax-coloring.png[width=800, link="images/user-review-ui-side-by-side-diff-screen-syntax-coloring.png"]
1031
Edwin Kempinf9b4bc92014-11-05 13:14:57 +01001032- [[whitespace-errors]]`Whitespace Errors`:
Edwin Kempinfe8ca4c2014-05-08 16:49:15 +02001033+
1034Controls whether whitespace errors are highlighted.
1035
Edwin Kempinf9b4bc92014-11-05 13:14:57 +01001036- [[show-tabs]]`Show Tabs`:
Edwin Kempinfe8ca4c2014-05-08 16:49:15 +02001037+
1038Controls whether tabs are highlighted.
1039
Edwin Kempinf9b4bc92014-11-05 13:14:57 +01001040- [[line-numbers]]`Line Numbers`:
Edwin Kempinfe8ca4c2014-05-08 16:49:15 +02001041+
1042Controls whether line numbers are shown.
1043
Edwin Kempinf9b4bc92014-11-05 13:14:57 +01001044- [[empty-pane]]`Empty Pane`:
David Ostrovskya64d6892014-05-01 21:55:00 +02001045+
1046Controls whether empty panes are shown or not. The Left pane is empty when a
1047file was added; the right pane is empty when a file was deleted.
1048
Edwin Kempinf9b4bc92014-11-05 13:14:57 +01001049- [[left-side]]`Left Side`:
Edwin Kempin91de46f2014-05-12 08:28:32 +02001050+
David Ostrovskya000b232014-05-13 07:47:06 +02001051Controls whether the left side is shown. This preference is not
1052persistent and is ignored by the `Save` button. Every time a
1053patch diff is opened, this preference is reset to `Show`.
Edwin Kempin91de46f2014-05-12 08:28:32 +02001054
Edwin Kempinf9b4bc92014-11-05 13:14:57 +01001055- [[top-menu]]`Top Menu`:
Edwin Kempinfe8ca4c2014-05-08 16:49:15 +02001056+
1057Controls whether the top menu is shown.
1058
Edwin Kempinf9b4bc92014-11-05 13:14:57 +01001059- [[auto-hide-diff-table-header]]`Auto Hide Diff Table Header`:
Edwin Kempin1b6c6d82014-09-11 23:36:43 +02001060+
1061Controls whether the diff table header should be automatically hidden
1062when scrolling down more than half of a page.
1063
Edwin Kempinf9b4bc92014-11-05 13:14:57 +01001064- [[mark-reviewed]]`Mark Reviewed`:
Edwin Kempinfe8ca4c2014-05-08 16:49:15 +02001065+
1066Controls whether the files of the patch set should be automatically
1067marked as reviewed when they are viewed.
1068
Edwin Kempinf9b4bc92014-11-05 13:14:57 +01001069- [[expand-all-comments]]`Expand All Comments`:
Edwin Kempinfe8ca4c2014-05-08 16:49:15 +02001070+
1071Controls whether all comments should be automatically expanded.
1072
Edwin Kempinf9b4bc92014-11-05 13:14:57 +01001073- [[render]]`Render`:
Edwin Kempinfe8ca4c2014-05-08 16:49:15 +02001074+
1075Controls how patch files that exceed the screen size are rendered.
1076+
1077If `Fast` is selected file contents which are outside of the visible
1078area are not attached to the browser's DOM tree. This makes the
1079rendering fast, but searching by `Ctrl+F` only finds content which is
1080in the visible area.
1081+
1082If `Slow` is selected all file contents are attached to the browser's
1083DOM tree, which makes the rendering slow for large files. The advantage
1084of this setting is that `Ctrl+F` can be used to search in the complete
1085file.
Edwin Kempin9cc22c92014-05-12 08:16:52 +02001086+
1087Large files that exceed 4000 lines will not be fully rendered.
Edwin Kempinfe8ca4c2014-05-08 16:49:15 +02001088
Edwin Kempin7a85f412014-05-09 12:51:51 +02001089[[keyboard-shortcuts]]
1090== Keyboard Shortcuts
1091
1092Navigation within the review UI can be completely done by keys, and
1093most actions can be controlled by keyboard shortcuts. Typing `?` opens
1094a popup that shows a list of available keyboard shortcuts:
1095
1096- Change Screen
1097+
1098image::images/user-review-ui-change-screen-keyboard-shortcuts.png[width=800, link="images/user-review-ui-change-screen-keyboard-shortcuts.png"]
1099
1100- Side-by-Side Diff Screen
1101+
1102image::images/user-review-ui-side-by-side-diff-screen-keyboard-shortcuts.png[width=800, link="images/user-review-ui-side-by-side-diff-screen-keyboard-shortcuts.png"]
1103+
1104In addition, Vim-like commands can be used to link:#key-navigation[
1105navigate] and link:#search[search] within a patch file.
1106
Edwin Kempinb7a1c7c2014-05-09 11:21:18 +02001107[[new-vs-old]]
1108== New Review UI vs. Old Review UI
1109
1110There are some important conceptual differences between the old and
1111new review UIs:
1112
1113- The old change screen directly shows all patch sets of the change.
1114 With the new change screen only a single patch set is displayed;
1115 users can switch between the patch sets by choosing another patch
1116 set from the link:#patch-sets[Patch Sets] drop down panel in the
1117 screen header.
1118- On the old side-by-side diff screen, new comments are inserted by
1119 double-clicking on a line. With the new side-by-side diff screen
1120 double-click is used to select a word for commenting on it; there
1121 are link:#add-inline-comment[several ways to insert new comments],
1122 e.g. by selecting a code block and clicking on the popup comment
1123 icon.
1124
Edwin Kempinf9b4bc92014-11-05 13:14:57 +01001125[[limitations]]
Edwin Kempinb7a1c7c2014-05-09 11:21:18 +02001126Limitations of the new review UI:
1127
1128- The new side-by-side diff screen cannot render images.
1129
Edwin Kempin7aed5f02014-11-05 13:30:22 +01001130- The new side-by-side diff screen isn't able to highlight line
1131 endings.
1132
Edwin Kempin4fd84c92014-04-30 13:23:15 +02001133GERRIT
1134------
1135Part of link:index.html[Gerrit Code Review]
1136
1137SEARCHBOX
1138---------