blob: 6b78b9810a8ba346c718fd26cfbe1cdfe0c6cb5b [file] [log] [blame]
Edwin Kempin4fd84c92014-04-30 13:23:15 +02001= Review UI
2
3Reviewing changes is an important task and the Gerrit Web UI provides
4many functionalities to make the review process comfortable and
5efficient. This is a guide through the review UI that explains the
6different functions and UI elements.
7
8[[change-screen]]
9== Change Screen
10
11The change screen shows the details of a single change and provides
12various actions on it.
13
14image::images/user-review-ui-change-screen.png[width=800, link="images/user-review-ui-change-screen.png"]
15
16[[commit-message]]
17=== Commit Message Block
18
19The focus of the change screen is on the commit message since this is
20the most important information about a change. The numeric change ID
21and the change status are displayed right above the commit message.
22
23image::images/user-review-ui-change-screen-commit-message.png[width=800, link="images/user-review-ui-change-screen-commit-message.png"]
24
25The commit message can be edited directly in the Web UI by clicking on
26the `Edit Message` button in the change header. This opens a drop-down
27editor box in which the commit message can be edited. Saving
28modifications of the commit message automatically creates a new patch
29set for the change. The commit message may only be edited on the
30current patch set.
31
32image::images/user-review-ui-change-screen-edit-commit-message.png[width=800, link="images/user-review-ui-change-screen-edit-commit-message.png"]
33
34The numeric change ID is a link to the change and clicking on it
35refreshes the change screen. By copying the link location you can get
36the permalink of the change.
37
38image::images/user-review-ui-change-screen-permalink.png[width=800, link="images/user-review-ui-change-screen-permalink.png"]
39
40The change status shows the state of the change:
41
42- `Needs <label>`:
43+
44The change is in review and an approval on the shown label is still
45required to make the change submittable.
46
47- `Not <label>`:
48+
49The change is in review and a veto vote on the shown label is
50preventing the submit.
51
52- `Not Current`:
53+
54The currently viewed patch set is outdated.
55+
56Please note that some operations, like voting, are not available on
57outdated patch sets, but only on the current patch set.
58
59- `Ready to Submit`:
60+
61The change has all necessary approvals and may be submitted.
62
63- `Submitted, Merge Pending`:
64+
65The change was submitted and was added to the merge queue.
66+
67The change stays in the merge queue if it depends on a change that is
68still in review. In this case it will get automatically merged when all
69predecessor changes have been merged.
70+
71This status can also mean that the change depends on an abandoned
72change or on an outdated patch set of another change. In this case you
73may want to rebase the change.
74
75- `Merged`:
76+
77The change was successfully merged into the destination branch.
78
79- `Abandoned`:
80+
81The change was abandoned.
82
83- `Draft`:
84+
85The change is a draft that is only visible to the change owner, the
86reviewers that were explicitly added to the change, and users who have
87the link:access-control.html#category_view_drafts[View Drafts] global
88capability assigned.
89
90[[commit-info]]
91=== Commit Info Block
92
93The commit info block shows information about the commit of the
94currently viewed patch set.
95
96It displays the author and the committer as links to a list of this
97person's changes that have the same status as the currently viewed
98change.
99
100The commit ID and the link:user-changeid.html[Change-Id] are both
101displayed with a copy-to-clipboard icon that allows the ID to be copied
102into the clipboard.
103
104If a Git web browser, such as GitWeb or Gitiles, is configured, there
105is also a link to the commit in the Git web browser.
106
107image::images/user-review-ui-change-screen-commit-info.png[width=800, link="images/user-review-ui-change-screen-commit-info.png"]
108
Edwin Kempinf1a84f92014-04-30 15:37:48 +0200109[[change-info]]
110=== Change Info Block
111
112The change info block contains detailed information about the change
113and offers actions on the change.
114
115image::images/user-review-ui-change-screen-change-info.png[width=800, link="images/user-review-ui-change-screen-change-info.png"]
116
117- Change Owner:
118+
119The owner of the change is displayed as a link to a list of the owner's
120changes that have the same status as the currently viewed change.
121+
122image::images/user-review-ui-change-screen-change-info-owner.png[width=800, link="images/user-review-ui-change-screen-change-info-owner.png"]
123
124- Reviewers:
125+
126The reviewers of the change are displayed as chip tokens.
127+
128For each reviewer there is a tooltip that shows on which labels the
129reviewer is allowed to vote.
130+
131New reviewers can be added by clicking on the `Add...` button. Typing
132into the pop-up text field activates auto completion of user and group
133names.
134+
135Reviewers can be removed from the change by clicking on the `x` icon
136in the reviewer's chip token. Removing a reviewer also removes the
137current votes of the reviewer. The removal of votes is recorded as a
138message on the change.
139+
140Removing reviewers is protected by permissions:
141
142** Users can always remove themselves.
143** The change owner may remove any zero or positive score.
144** Users with the link:access-control.html#category_remove_reviewer[
145 Remove Reviewer] access right, the branch owner, the project owner
146 and Gerrit administrators may remove anyone.
147
148+
149image::images/user-review-ui-change-screen-change-info-reviewers.png[width=800, link="images/user-review-ui-change-screen-change-info-reviewers.png"]
150
151- Project / Branch / Topic:
152+
153The name of the project for which the change was done is displayed as a
154link to the link:user-dashboards.html#project-default-dashboard[default
155dashboard] of the project. If no default dashboard is defined, the link
156opens a list of open changes on the project.
157+
158Clicking on the settings icon on the right side navigates to the
159project administration screen.
160+
161The name of the destination branch is displayed as a link to a list
162with all changes on this branch that have the same status as the
163currently viewed change.
164+
165If a topic was assigned to the change it is displayed below the branch.
166By clicking on the edit icon the topic can be set. This requires the
167link:access-control.html#category_edit_topic_name[Edit Topic Name]
168access right. To be able to set a topic on a closed change, the
169`Edit Topic Name` must be assigned with the `force` flag.
170+
171image::images/user-review-ui-change-screen-change-info-project-branch-topic.png[width=800, link="images/user-review-ui-change-screen-change-info-project-branch-topic.png"]
172
173- Submit Strategy:
174+
175The link:project-setup.html#submit_type[submit strategy] that will be
176used to submit the change. The submit strategy is only displayed for
177open changes.
178+
179image::images/user-review-ui-change-screen-change-info-submit-strategy.png[width=800, link="images/user-review-ui-change-screen-change-info-submit-strategy.png"]
180+
181If a change cannot be merged due to path conflicts this is highlighted
182by a bold red `Cannot Merge` label.
183+
184image::images/user-review-ui-change-screen-change-info-cannot-merge.png[width=800, link="images/user-review-ui-change-screen-change-info-cannot-merge.png"]
185
186- Time of Last Update:
187+
188image::images/user-review-ui-change-screen-change-info-last-update.png[width=800, link="images/user-review-ui-change-screen-change-info-last-update.png"]
189
190- Actions:
191+
192Depending on the change state and the permissions of the user, different
193actions are available on the change:
194
195** `Merge Change`:
196+
197Submits the change and adds it to the merge queue. If possible the
198change is merged into the destination branch.
199+
200The `Merge Change` button is available if the change is submittable and
201the link:access-control.html#category_submit[Submit] access right is
202assigned.
203+
204It is also possible to submit changes that have merge conflicts. This
205allows to do the conflict resolution for a change series in a single
206merge commit and submit the changes in reverse order.
207
208** `Abandon`:
209+
210Abandons the change.
211+
212The `Abandon` button is only available if the change is open and the
213link:access-control.html#category_abandon[Abandon] access right is
214assigned.
215+
216When a change is abandoned, a panel appears that allows one to type a
217comment message to explain why the change is being abandoned.
218
219** `Restore`:
220+
221Restores the change.
222+
223The `Restore` button is only available if the change is abandoned and
224the link:access-control.html#category_abandon[Abandon] and the
225link:access-control.html#category_push[Push] access right is
226assigned.
227+
228When a change is restored, a panel appears that allows one to type a
229comment message to explain why the change is being restored.
230
231** `Rebase`:
232+
233Rebases the change. The rebase is always done with content merge
234enabled. If the rebase is successful a new patch set with the rebased
235commit is created. If the rebase fails, there are conflicts that have
236to be resolved manually.
237+
238If the change does not depend on another open change, it is rebased
239onto the tip of the destination branch.
240+
241If the change depends on another open change, it is rebased onto the
242current patch set of that other change.
243+
244The `Rebase` button is only available if the change can be rebased and
245the link:access-control.html#category_rebase[Rebase] access right is
246assigned. Rebasing merge commits is not supported.
247
248** `Cherry-Pick`:
249+
250Allows to cherry-pick the change to another branch. The destination
251branch can be selected from a dialog. Cherry-picking a change creates a
252new open change on the selected destination branch.
253+
254It is also possible to cherry-pick a change to the same branch. This is
255effectively the same as rebasing it to the current tip of the
256destination branch. This can be used to remove dependencies on other
257open changes.
258+
259Users can only cherry-pick changes to branches for which they are
260allowed to upload changes for review.
261
262** `Publish`:
263+
264Publishes the currently viewed draft patch set. If this is the first
265patch set of a change that is published, the change will be published
266as well.
267+
268The `Publish` button is only available if a draft patch set is viewed
269and the user is the change owner or has the
270link:access-control.html#category_publish_drafts[Publish Drafts] access
271right assigned.
272
273** `Delete Change` / `Delete Revision`:
274+
275Deletes the draft change / the currently viewed draft patch set.
276+
277The `Delete Change` / `Delete Revision` buttons are only available if a
278draft patch set is viewed and the user is the change owner or has the
279link:access-control.html#category_delete_drafts[Delete Drafts] access
280right assigned.
281
282** Further actions may be available if plugins are installed.
283
284+
285image::images/user-review-ui-change-screen-change-info-actions.png[width=800, link="images/user-review-ui-change-screen-change-info-actions.png"]
286
287- Labels & Votes:
288+
289Approving votes are colored green; veto votes are colored red.
290+
291image::images/user-review-ui-change-screen-change-info-labels.png[width=800, link="images/user-review-ui-change-screen-change-info-labels.png"]
292
Edwin Kempinab777f12014-05-02 11:47:57 +0200293[[files]]
294=== File List
295
296The file list shows the files that are modified in the currently viewed
297patch set.
298
299image::images/user-review-ui-change-screen-file-list.png[width=800, link="images/user-review-ui-change-screen-file-list.png"]
300
301The checkboxes in front of the file names allow files to be marked as reviewed.
302
303image::images/user-review-ui-change-screen-file-list-mark-as-reviewed.png[width=800, link="images/user-review-ui-change-screen-file-list-mark-as-reviewed.png"]
304
305The type of a file modification is indicated by the character in front
306of the file name:
307
308- 'no character' (Modified):
309+
310The file existed before this change and is modified.
311
312- `A` (Added):
313+
314The file is newly added.
315
316- `D` (Deleted):
317+
318The file is deleted.
319
320- `R` (Renamed):
321+
322The file is renamed.
323
324- `C` (Copied):
325+
326The file is new and is copied from an existing file.
327
328image::images/user-review-ui-change-screen-file-list-modification-type.png[width=800, link="images/user-review-ui-change-screen-file-list-modification-type.png"]
329
330If a file is renamed or copied, the name of the original file is
331displayed in gray below the file name.
332
333image::images/user-review-ui-change-screen-file-list-rename.png[width=800, link="images/user-review-ui-change-screen-file-list-rename.png"]
334
335Repeating path segments are grayed out.
336
337image::images/user-review-ui-change-screen-file-list-repeating-paths.png[width=800, link="images/user-review-ui-change-screen-file-list-repeating-paths.png"]
338
339Inline comments on a file are shown in the `Comments` column.
340
341Draft comments, i.e. comments that have been written by the current
342user but not yet published, are highlighted in red.
343
344New comments from other users, that were published after the current
345user last reviewed this change, are highlighted in bold.
346
347image::images/user-review-ui-change-screen-file-list-comments.png[width=800, link="images/user-review-ui-change-screen-file-list-comments.png"]
348
349The size of the modifications in the files can be seen in the `Size`
350column. The footer row shows the total size of the change.
351
352For files, the `Size` column shows the sum of inserted and deleted
353lines as one number. For the total size, inserted and deleted lines are
354shown separately. In addition, the number of insertions and deletions
355is shown as a bar. The size of the bar indicates the amount of changed
356lines, and its coloring in green and red shows the proportion of
357insertions to deletions.
358
359The size information is useful to easily spot the files that contain
360the most modifications; these files are likely to be the most relevant
361files for this change. The total change size gives an estimate of how
362long a review of this change may take.
363
364image::images/user-review-ui-change-screen-file-list-size.png[width=800, link="images/user-review-ui-change-screen-file-list-size.png"]
365
366In the header of the file list, the `Diff Against` selection can be
367changed. This selection allows one to choose if the currently viewed
368patch set should be compared against its base or against another patch
369set of this change. The file list is updated accordingly.
370
371The file list header also provides an `Open All` button that opens the
372diff views for all files in the file list.
373
374image::images/user-review-ui-change-screen-file-list-header.png[width=800, link="images/user-review-ui-change-screen-file-list-header.png"]
375
Edwin Kempinae57e182014-04-30 13:38:55 +0200376[[old-change-screen]]
377=== Old Change Screen
378
379In addition to the normal change screen, this Gerrit version still
380includes the old change screen that was used in earlier Gerrit
381versions. Users that want to continue using the old change screen can
382configure it in their preferences under
383`Settings` > `Preferences` > `Change View`:
384
385image::images/user-review-ui-change-view-preference.png[width=800, link="images/user-review-ui-change-view-preference.png"]
386
387[WARNING]
388The old change screen will be removed in a later version of Gerrit.
389
Edwin Kempin4fd84c92014-04-30 13:23:15 +0200390GERRIT
391------
392Part of link:index.html[Gerrit Code Review]
393
394SEARCHBOX
395---------