Skip to content
This repository was archived by the owner on Jun 25, 2025. It is now read-only.
Closed
Changes from all commits
Commits
File filter

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/Http/AxiosClient.ts
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,10 @@ export class AxiosClient extends Client implements HttpClient {
return resolve(response);
})
.catch((error) => {
if(error.response === undefined){
console.info("Request Canceled");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is dangerous. Basically because you're logging always, even in production, and this library is used in NodeJS as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It logs at info level. It should be a responsibility of the developer to establish if they want to output it.

return;
}
const response = new Response(
error.response.status,
error.response.data,
Expand Down