This repository was archived by the owner on Jun 25, 2025. It is now read-only.
Fix console error display on Cancel search #28
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
mmoreram reviewed Dec 24, 2018
| }) | ||
| .catch((error) => { | ||
| if(error.response === undefined){ | ||
| console.info("Request Canceled"); |
There was a problem hiding this comment.
This line is dangerous. Basically because you're logging always, even in production, and this library is used in NodeJS as well.
There was a problem hiding this comment.
It logs at info level. It should be a responsibility of the developer to establish if they want to output it.
mmoreram suggested changes Dec 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fix the display of errors on console when there is a search cancelation