Skip to content
This repository was archived by the owner on Jun 25, 2025. It is now read-only.

Fix console error display on Cancel search #28

Closed
wants to merge 1 commit into from
Closed

Fix console error display on Cancel search #28

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix console error display on Cancel search
  • Loading branch information
Pedro Escudero authored and Pedro Escudero committed Dec 22, 2018
commit 98e45293d96fca8f3865d91aa7d8ae2678b90e13
4 changes: 4 additions & 0 deletions src/Http/AxiosClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,10 @@ export class AxiosClient extends Client implements HttpClient {
return resolve(response);
})
.catch((error) => {
if(error.response === undefined){
console.info("Request Canceled");
Copy link
Member

@mmoreram mmoreram Dec 24, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is dangerous. Basically because you're logging always, even in production, and this library is used in NodeJS as well.
Copy link
Contributor Author

@PedroEscudero PedroEscudero Dec 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It logs at info level. It should be a responsibility of the developer to establish if they want to output it.
return;
}
const response = new Response(
error.response.status,
error.response.data,
Expand Down