SetValueMethodRule: Add support for asymmetric properties #28
Conversation
When the property is not writeable, the writeable type will be void.
| $property = $class->getProperty($fieldName, $scope); | ||
| $propertyType = $property->getWritableType(); | ||
| | ||
| if (!$property->isWritable()) { |
There was a problem hiding this comment.
This doesn't seem right - if case the property is not writable, we need to resolve the writeable error first, instead it will result in the wrong error -> readable type doesn't match the type being assigned/written.
There was a problem hiding this comment.
I am not sure what you mean.
- Without Asymmetric @property types phpstan/phpstan-src#2294,
$property->getWritableType() === $property->getReadableType()so this would be a no-op. - And with it, this is necessary since
$property->getWritableType()will be a bottom typevoidwhen the property is not writeable. And it will always be readable or writeable when it exists.
What does not seem right to me is writing to read-only properties but you have created setReadOnlyValue() so 🤷♀️
There was a problem hiding this comment.
Yes, and since readable type will be different, this PHPStan will improperly throw an error that readable type don't accept the value.
There was a problem hiding this comment.
I do not think it will. PHPStan is not aware that setReadOnlyValue() or setValue() modifies the property. Only this rule ensures it.
And if you try
/** * @property-read string $name */ final class Tag extends Entity { public function setName(string $name): void { $this->name = $name; } }You will rightly get Property Tag::$name is not writable before the type mismatch.
| fixed here: f95afa3 |
2 participants
In preparation for phpstan/phpstan-src#2294
When the property is not writeable, the writeable type will be void.