Fix CI #29
Merged
Fix CI #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Cannot call method toString() on PhpParser\Node\Name|null. nikic/PHP-Parser@f4b835f
Composer now requires plug-ins to be explicitly whitelisted before running them, see https://getcomposer.org/allow-plugins When that is not done, installation will fail with: Error: phpstan/extension-installer contains a Composer plugin which is blocked by your allow-plugins config. You may add it to the list if you consider it safe.
Member
| Thanks for these fixes. I will make it pass or you can try, but no need to do so :) |
------ ----------------------------------------------------------------- Line src/Types/RepositoryReturnTypeExtension.php ------ ----------------------------------------------------------------- 109 Strict comparison using === between class-string<Nextras\Orm\Repository\Repository> and 'Nextras\\Orm\\Repository\\IRepository' will always evaluate to false. ------ -----------------------------------------------------------------
Contributor Author
| I am not seeing the error from CI locally. I have attempted to fix it. Hopefully, once we get CI green, you will be more sure about the correctness of #28. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Cannot call method toString() on PhpParser\Node\Name|null.
nikic/PHP-Parser@f4b835f