use readable type if the property is not writeable

reorder also erros to report non-writable property first

Author: hrach

src/Rules/SetValueMethodRule.php

@@ -90,24 +90,28 @@ public function processNode(Node $node, Scope $scope): array
 }
 
 $property = $class->getProperty($fieldName, $scope);
-$propertyType = $property->getWritableType();
 
-if (!$propertyType->accepts($valueType, true)->yes()) {
+if (!$property->isWritable() && $methodName !== 'setReadOnlyValue') {
 $errors[] = sprintf(
-'Entity %s: property $%s (%s) does not accept %s.',
+'Entity %s: property $%s is read-only.',
 $className,
-$fieldName,
-$propertyType->describe(VerbosityLevel::typeOnly()),
-$valueType->describe(VerbosityLevel::typeOnly())
+$fieldName
 );
 continue;
 }
 
-if (!$property->isWritable() && $methodName !== 'setReadOnlyValue') {
+$propertyType = $property->getWritableType();
+if (!$property->isWritable()) {
+$propertyType = $property->getReadableType();
+}
+
+if (!$propertyType->accepts($valueType, true)->yes()) {
 $errors[] = sprintf(
-'Entity %s: property $%s is read-only.',
+'Entity %s: property $%s (%s) does not accept %s.',
 $className,
-$fieldName
+$fieldName,
+$propertyType->describe(VerbosityLevel::typeOnly()),
+$valueType->describe(VerbosityLevel::typeOnly())
 );
 }
 }