Skip to content

fix: don't check the .d.ts files from node_modules #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 30, 2019
Merged

fix: don't check the .d.ts files from node_modules #251

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a69b785
fix: don't check the `.d.ts` files from `node_modules`
Fatme Sep 30, 2019
6a48097
chore: bump version
Fatme Sep 30, 2019
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: don't check the .d.ts files from node_modules 
`Cannot find type definition file for 'jasmine/v2'` error is thrown when a new code shared application is created. It seems the issues comes [from this commit inside jasmine repo](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/38412/files#diff-704f3d6b17350ee2426b25280154df4f). Adding `skipLibCheck: true` to `tsconfig.json` will skip the checks of `.d.ts` files inside `node_modules`. This will also improve the performance of typescript compilation with a lot of deps and files to process. Rel to: #249
  • Loading branch information
@Fatme
Fatme committed Sep 30, 2019
commit a69b78501bd92c535b7ae4262ae1b64d30c1969f
1 change: 1 addition & 0 deletions src/ng-new/application/_files/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
"target": "es5",
"experimentalDecorators": true,
"emitDecoratorMetadata": true,
"skipLibCheck": true,
"noEmitHelpers": true,
"noEmitOnError": true,
"lib": [
Expand Down
1 change: 1 addition & 0 deletions src/ng-new/shared/_files/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
"moduleResolution": "node",
"emitDecoratorMetadata": true,
"experimentalDecorators": true,
"skipLibCheck": true,
"target": "es5",
"typeRoots": [
"node_modules/@types"
Expand Down