fix: don't check the .d.ts files from node_modules #251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
`Cannot find type definition file for 'jasmine/v2'` error is thrown when a new code shared application is created. It seems the issues comes [from this commit inside jasmine repo](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/38412/files#diff-704f3d6b17350ee2426b25280154df4f). Adding `skipLibCheck: true` to `tsconfig.json` will skip the checks of `.d.ts` files inside `node_modules`. This will also improve the performance of typescript compilation with a lot of deps and files to process. Rel to: #249
rosen-vladimirov approved these changes Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Cannot find type definition file for 'jasmine/v2'error is thrown when a new code shared application is created. It seems the issue comes from this commit inside jasmine repo. AddingskipLibCheck: truetotsconfig.jsonwill skip the checks of.d.tsfiles insidenode_modules. This will also improve the performance of typescript compilation with a lot of deps and files to process.Rel to: #249
PR Checklist
What is the current behavior?
What is the new behavior?
Fixes/Implements/Closes #[Issue Number].