Skip to content

compiletest: Use //@ prefixes also for debuginfo test directives #147799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

compiletest: Use //@ prefixes also for debuginfo test directives #147799

wants to merge 1 commit into from
+6,875 −6,866

Conversation

@Enselic
Copy link
Member

@Enselic Enselic commented Oct 17, 2025 •
edited
Loading

So that when we later add support for revisions we can use the same syntax for revisions as elsewhere.

This also prevents people from making typos for commands since src/tools/compiletest/src/directives/directive_names.rs will catch such typos now.

Note that we add three FIXMEs for non-trivial changes that need to be done later:

// FIXME(#148097): Change `// cdb-checksimple_closure` to `//@ cdb-check:simple_closure` // FIXME(#147728): Change `// gdbt-check` to `//@ gdb-check` and remove `linelength` ignore above // FIXME(#147728): Change `// gdbt-check` to `//@ gdb-check`

TODO

Zulip discussion

https://rust-lang.zulipchat.com/#narrow/channel/326414-t-infra.2Fbootstrap/topic/.2F.2F.40.20syntax.20for.20debuginfo.20tests/with/545015582
@rustbot rustbot added A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc A-tidy Area: The tidy tool S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 17, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Enselic Enselic mentioned this pull request Oct 25, 2025
Closed
Zalathar added a commit to Zalathar/rust that referenced this pull request Oct 26, 2025
@Zalathar
Rollup merge of rust-lang#148097 - Enselic:misspelled-cdb-check, r=Za…
c7ebf73 
…lathar tests/debuginfo/closures.rs: Activate misspelled `cdb-check` Split out from rust-lang#147799 because these seemingly simple corrections can turn out to be non-trivial. See rust-lang#147728 for example.
Zalathar added a commit to Zalathar/rust that referenced this pull request Oct 26, 2025
@Zalathar
Rollup merge of rust-lang#148097 - Enselic:misspelled-cdb-check, r=Za…
5999e9c 
…lathar tests/debuginfo/closures.rs: Activate misspelled `cdb-check` Split out from rust-lang#147799 because these seemingly simple corrections can turn out to be non-trivial. See rust-lang#147728 for example.
bors added a commit that referenced this pull request Oct 26, 2025
@bors
Auto merge of #148097 - Enselic:misspelled-cdb-check, r=Zalathar
3bcdb11 
tests/debuginfo/closures.rs: Activate misspelled `cdb-check` Split out from #147799 because these seemingly simple corrections can turn out to be non-trivial. See #147728 for example.
@Enselic Enselic force-pushed the slash-slash-at-debuginfo-tests branch 2 times, most recently from 74887a7 to 1f5cd0c Compare October 31, 2025 16:37
@Enselic Enselic changed the title tests: Use //@ prefixes also for debuginfo test directives compiletest: Use //@ prefixes also for debuginfo test directives Oct 31, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Enselic Enselic force-pushed the slash-slash-at-debuginfo-tests branch from 1f5cd0c to 9ec7434 Compare October 31, 2025 18:10
@Enselic
Copy link
Member Author

Enselic commented Oct 31, 2025

@bors try jobs=x86_64-msvc-1
@rust-bors

This comment has been minimized.

Sign in to view
rust-bors bot added a commit that referenced this pull request Oct 31, 2025
@rust-bors
Auto merge of #147799 - Enselic:slash-slash-at-debuginfo-tests, r=<try>
c89eb6c 
compiletest: Use `//@` prefixes also for debuginfo test directives try-job: x86_64-msvc-1
@Enselic
compiletest: Use //@ prefixes also for debuginfo test directives
10bf1c1 
So that when we later add support for revisions we can use the same syntax for revisions as elsewhere. This also prevents people from making typos for commands since `src/tools/compiletest/src/directives/directive_names.rs` will catch such typos now. Note that we add three FIXMEs for non-trivial changes that need to be done later: ``` // FIXME(148097): Change `// cdb-checksimple_closure` to `//@ cdb-check:simple_closure` // FIXME(147728): Change `// gdbt-check` to `//@ gdb-check` and remove `linelength` ignore above // FIXME(147728): Change `// gdbt-check` to `//@ gdb-check` ```
@rust-bors
Copy link

rust-bors bot commented Oct 31, 2025

☀️ Try build successful (CI)
Build commit: c89eb6c (c89eb6c72bc4a168b32b17a36f56df1e617c3cb3, parent: 51f5892019f8fb07864647d46c4eb577d3b0719f)
@Enselic Enselic force-pushed the slash-slash-at-debuginfo-tests branch from 9ec7434 to 19de8a2 Compare November 1, 2025 08:30
@Enselic
Copy link
Member Author

Enselic commented Nov 1, 2025

@bors try jobs=x86_64-msvc-1
rust-bors bot added a commit that referenced this pull request Nov 1, 2025
@rust-bors
Auto merge of #147799 - Enselic:slash-slash-at-debuginfo-tests, r=<try>
464c055 
compiletest: Use `//@` prefixes also for debuginfo test directives try-job: x86_64-msvc-1
@rust-bors

This comment has been minimized.

Sign in to view
@rust-bors
Copy link

rust-bors bot commented Nov 1, 2025

☀️ Try build successful (CI)
Build commit: 464c055 (464c055969e217e038285dbdafe6bcb4c174f8a0, parent: 17e7324d44c7b310b776302880fdd08d9252118a)
@Enselic
Copy link
Member Author

Enselic commented Nov 1, 2025

x86_64-msvc-1 does not have cdb it seems, but I think aarch64 does:

@bors try jobs=aarch64-msvc-1
@rust-bors

This comment has been minimized.

Sign in to view
rust-bors bot added a commit that referenced this pull request Nov 1, 2025
@rust-bors
Auto merge of #147799 - Enselic:slash-slash-at-debuginfo-tests, r=<try>
8aa08e9 
compiletest: Use `//@` prefixes also for debuginfo test directives try-job: aarch64-msvc-1
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-bors
Copy link

rust-bors bot commented Nov 1, 2025

💔 Test for 8aa08e9 failed: CI. Failed jobs:
@Enselic
Copy link
Member Author

Enselic commented Nov 3, 2025

According to #t-compiler/debuginfo > debuginfo-lldb CI job? we need to run aarch64-apple to confirm that lldb tests can still fail.

@bors try jobs=aarch64-apple
@rust-bors

This comment has been minimized.

Sign in to view
rust-bors bot added a commit that referenced this pull request Nov 3, 2025
@rust-bors
Auto merge of #147799 - Enselic:slash-slash-at-debuginfo-tests, r=<try>
7e46723 
compiletest: Use `//@` prefixes also for debuginfo test directives try-job: aarch64-apple
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-bors
Copy link

rust-bors bot commented Nov 3, 2025

💔 Test for 7e46723 failed: CI. Failed jobs:
@Enselic Enselic force-pushed the slash-slash-at-debuginfo-tests branch from 19de8a2 to 10bf1c1 Compare November 3, 2025 05:43
@Enselic
Copy link
Member Author

Enselic commented Nov 3, 2025

I have now confirmed that gdb, lldb, and cdb tests can still fail, so this is ready for review.

Click to expand list of confirmed test failures. 
2025-10-31T17:14:59.2821529Z failures: 2025-10-31T17:14:59.2821743Z [debuginfo-gdb] tests/debuginfo/basic-types-globals.rs#no-lto 2025-10-31T17:14:59.2822093Z [debuginfo-gdb] tests/debuginfo/basic-types-globals.rs#lto 2025-10-31T17:14:59.2822413Z [debuginfo-gdb] tests/debuginfo/cross-crate-spans.rs 2025-10-31T17:14:59.2822777Z [debuginfo-gdb] tests/debuginfo/lexical-scope-in-unconditional-loop.rs 2025-10-31T17:14:59.2823149Z [debuginfo-gdb] tests/debuginfo/reference-debuginfo.rs 2025-11-03T05:35:52.5258000Z failures: 2025-11-03T05:35:52.5258190Z [debuginfo-lldb] tests/debuginfo/struct-in-struct.rs 2025-11-03T05:35:52.5258470Z [debuginfo-lldb] tests/debuginfo/tuple-struct.rs 2025-11-03T05:35:52.5258780Z [debuginfo-lldb] tests/debuginfo/zst-interferes-with-prologue.rs 2025-11-01T23:05:16.4753232Z failures: 2025-11-01T23:05:16.4753850Z [debuginfo-cdb] tests\debuginfo\basic-types.rs 2025-11-01T23:05:16.4754222Z [debuginfo-cdb] tests\debuginfo\marker-types.rs
@Enselic Enselic marked this pull request as ready for review November 3, 2025 05:46
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 3, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 3, 2025

compiletest directives have been modified. Please add or update docs for the
new or modified directive in src/doc/rustc-dev-guide/.

Some changes occurred in src/tools/compiletest

cc @jieyouxu
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Nov 3, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 3, 2025

r? @wesleywiser

rustbot has assigned @wesleywiser.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc A-tidy Area: The tidy tool S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

4 participants

@Enselic @rust-log-analyzer @rustbot @wesleywiser