tests: activate misspelled gdb-check in function-arg-initialization.rs #147728
+6 −2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
rustbot added S-waiting-on-review 
| rustbot has assigned @Mark-Simulacrum. Use |
This comment has been minimized.
This comment has been minimized.
Enselic force-pushed the gdbt-check-typo branch from ca052c1 to b8c1b25 Compare This comment has been minimized.
This comment has been minimized.
Enselic force-pushed the gdbt-check-typo branch 3 times, most recently from 133bfad to f88ff0b Compare 2 tasks
Enselic commented Oct 17, 2025
| | ||
| fn non_immediate_args(a: BigStruct, b: BigStruct) { | ||
| zzz(); // #break | ||
| std::hint::black_box(|| { let _ = (a, b); }); // Avoid `<optimized out>` prints |
There was a problem hiding this comment.
Some reasonable questions might be: "Why is this needed? Why does aarch64-gnu-llvm-20-1 optimize away the args even with -Copt-level=0?"
I'll look into that to make sure we're not papering over a real bug.
Enselic added S-waiting-on-author Enselic force-pushed the gdbt-check-typo branch 2 times, most recently from d7f871a to 9cfef2e Compare 
…n.rs` In 9253e12 a bunch of `gdbr-check` (for `rust-gdb`) and `gdbg-check` (for plain `gdb`) was added. But in two places the author accidentally wrote `gdbt-check` instead. This commit fixes this typo.
Enselic force-pushed the gdbt-check-typo branch from 9cfef2e to b2af5c5 Compare rustbot added S-waiting-on-review Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
In 9253e12 a bunch of
gdbr-check(forrust-gdb) directives andgdbg-check(for plaingdb) directives were added. But in two places the author accidentally wrotegdbt-checkinstead (tis next toron the keyboard). This commit fixes that typo.#129218 later renamed
gdbr-checkto justgdb-checkwhich is why we rename togdb-checkdirectly.The test still passes locally for me after the change, but fails if I change the
gdb-checkchecks to check for some other string, so the check seems to still perform its intended function.Note that we need to add a
std::hint::black_box()to avoidprints on at least
aarch64-gnu-llvm-20-1.After this there are no more instances of the string
gdbtin the code base:$ git grep gdbt