Skip to content

[mypyc] feat: support constant folding in transform_assignment_expr #19992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

[mypyc] feat: support constant folding in transform_assignment_expr #19992

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mypyc/irbuild/expression.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1097,7 +1097,7 @@ def transform_generator_expr(builder: IRBuilder, o: GeneratorExpr) -> Value:


def transform_assignment_expr(builder: IRBuilder, o: AssignmentExpr) -> Value:
value = builder.accept(o.value)
value = try_constant_fold(builder, o.value) or builder.accept(o.value)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this has any effect. Can you show an example where this changes the generated IR? Constant folding should happen through builder.accept(...) already, and if it doesn't work, this is probably not the right place to do it.
target = builder.get_assignment_target(o.target)
builder.assign(target, value, o.line)
return value
Expand Down