[mypyc] feat: support constant folding in transform_assignment_expr #19992
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
We can't yet fold the expression itself, but we can fold its value expr This PR implements folding for the value expr
JukkaL reviewed Oct 3, 2025
| | ||
| def transform_assignment_expr(builder: IRBuilder, o: AssignmentExpr) -> Value: | ||
| value = builder.accept(o.value) | ||
| value = try_constant_fold(builder, o.value) or builder.accept(o.value) |
There was a problem hiding this comment.
I'm not sure if this has any effect. Can you show an example where this changes the generated IR? Constant folding should happen through builder.accept(...) already, and if it doesn't work, this is probably not the right place to do it.
| agreed. I think I'll convert this to a draft until I have a chance to go thru the AssignmentExpr stuff with a magnifying glass and can fold the entire expr correctly |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
We can't yet fold the expression itself, but we can fold its value expr
This PR implements folding for the value expr