Skip to content

Fix .equalTo, .endAt, and .startAt filters when used without key. #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Fix .equalTo, .endAt, and .startAt filters when used without key. #144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d927c6e
Fix .equalTo, .endAt, and .startAt filters when used without key.
janvogt Nov 18, 2016
65d2635
Use eventType and listener from EmitterSubscription to remove listener.
friedjoff Nov 29, 2016
a3a880b
Merge commit 'dcabc4a' into fix-storage-config
janvogt Dec 21, 2016
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions lib/modules/database.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,14 +312,23 @@ class DatabaseRef extends ReferenceBase {

// Filters
equalTo(value, key) {
if (!key) {
return this.query.setFilter('equalTo', value);
}
return this.query.setFilter('equalTo', value, key);
}

endAt(value, key) {
if (!key) {
return this.query.setFilter('endAt', value);
}
return this.query.setFilter('endAt', value, key);
}

startAt(value, key) {
if (!key) {
return this.query.setFilter('startAt', value);
}
return this.query.setFilter('startAt', value, key);
}

Expand Down
4 changes: 2 additions & 2 deletions lib/modules/storage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,8 +101,8 @@ export class Storage extends Base {
return FirestackStorageEvt.addListener(evt, cb);
}

_removeListener(evt) {
return FirestackStorageEvt.removeListener(evt);
_removeListener(subscription) {
return FirestackStorageEvt.removeListener(subscription.eventType, subscription.listener);
}

setStorageUrl(url) {
Expand Down